natikgadzhi / scrapes Goto Github PK

KindleAPI now can use stubbed network requests (well, I still have to record them), but for previews, we need proper model context setup, because they won't attempt fetching through the API flow on their own.

This would mean making a little struct that provides a ModelContext and shoves a few books and highlights into it. Makes sense to do after I grab the url request records for unit tests.

• Add a navigation title
• Add a loading indicator
• Add an empty state

The current implementation of getHighlights is relies on a very bare bones highlight parser that ignores type, position, page, and does not support pagination.

• Parse additional fields of a highlight on the model level, including HighlightType enum.
• Add unit tests for the decoder.
• Add API pagination support (if the cursor is present, fetch the next page automatically until there is no next page left).

Book and Highlight are parsed from html markup with SwiftSoup. Adding a test would make it easier to see if/when the app breaks because of the website markup change.

Also, consider writing a test that tests KindleAPI and supports taping the API response so it can be used in the tests later.

• Highlight tests should be covered in #3
• Add Book decoder unit tests.

List out the highlights for a book, and support exporting them as a bunch of text or a file.