Giter VIP home page Giter VIP logo

mmiwg2s's People

Contributors

callum-code avatar kjanderson2 avatar mamaro556 avatar mehequanna avatar pavan4 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

mmiwg2s's Issues

Android - Add share with us view after the user taps send to.

Create share page that overlays edit screen after user taps Send to button.
See this figma for view: https://www.figma.com/file/UOBTQ8qkOSJjMf8SeySiPr/Screens?node-id=1528%3A160

The Share Button sends the image and information to us and then move to system share. The image, email, and state should just be passed to an empty function at this point.
The Skip button goes directly to the system share button.
The back button at the top should restart the face editing view.
The grey box should be the user's image they will share. Could be cropped, doesn't have to fit. Could also be shrunk to fit. Do the faster one as the design may change.

Image fails to share on iOS

Reproduction Steps:
Go through the experience and skip the share with us section.
The iOS share sheet will come up.
Tap a social media app.
The screen will flash and then it will fall back to the app.

iOS - Add share with us view after the user taps send to.

Create share page that overlays edit screen after user taps Send to button.
See this figma for view: https://www.figma.com/file/UOBTQ8qkOSJjMf8SeySiPr/Screens?node-id=1528%3A160

The Share Button sends the image and information to us and then move to system share. The image, email, and state should just be passed to an empty function at this point.
The Skip button goes directly to the system share button.
The back button at the top should restart the face editing view.
The grey box should be the user's image they will share. Could be cropped, doesn't have to fit. Could also be shrunk to fit. Do the faster one as the design may change.

Clean up unused files

When things are closer to the end, let's clean up the unused files.
• /MMIW/iOS/MMIWG2S/Face.scnassets/fox_face.scn
• /MMIW/iOS/MMIWG2S/Face.scnassets/[any unused hand pngs]

BUG!

This is a test, this is only a test.

Android - Add Capture button to camera view

  • Use asset from figma
  • Should be tappable

https://www.figma.com/file/FpmBgui9L0VjuLCytJ7fNK/Screens?node-id=1103%3A1

From Kaitlyn's previous review:
The button position would be great if it was moved up a tad. When I hit it, it coincides in position on the screen with the home button if the buttons are brought up from immersive mode so a few times in testing I accidentally hit the home button. I know this isn't the final iteration but that was tricky
Try to find a way to disable the button when it has been hit once. I was able to hit it upwards of 10 times before the share drawer appeared and then I had to hit back 10 times to get rid of it. Should only open the share intent once.
Otherwise, totally works!

Android - Add back and send button to image edit view

If the user does not like the picture they took we should have a way to retake the photo.

To do this add a back button to the edit image view and have that button unpause ARCore.

Also add the send to button to share the image.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.