Comments (3)
I think the issue is a bad regex.
in markdown.js:
const inlineDefRegex = /([!$]?\[((?!\s*\])(?:\\.|[^\[\]\\])+)\])\(([^\n]+)\)/; //Matches 8, 9[10](11)
should be changed to
const inlineDefRegex = /([!$]?\[((?!\s*\])(?:\\.|[^\[\]\\])+)\])\(([^\n)]+)\)/; //Matches 8, 9[10](11)
which adds a )
in the disallowed characters in the third matching group (([^\n)]+)
)
from homebrewery.
@Gazook89 has reportedly tried this combination in other markdown editors without being able to replicate this behaviour, therefore, we are drawn to the conclusion the bug must come from our own code, most likely our table handling code in \shared\naturalcrit\markdown.js
.
Pointed out by @calculuschild, the error might be new and related to variables.
from homebrewery.
Discussed on Gitter, the real issue is this:
As easy as let content = match[11] ? match[11] : null;
, just removing the trim and regex substitution, since we need to do the parenthesis matching to occur before the trim.
homebrewery/shared/naturalcrit/markdown.js
Line 599 in dd82a1b
The trim will then happen afterward here. Note that the if(i > -1)
will always be true since there is no opportunity for i to be equal or less than -1. That was leftover from an earlier piece of code, and so we can just pull the inside of the if
out.
homebrewery/shared/naturalcrit/markdown.js
Lines 615 to 618 in dd82a1b
from homebrewery.
Related Issues (20)
- Multi-page variable use doesn't work when parsed to PDF HOT 2
- Definition List syntax breaks comments
- reporting a problem with saving, since the tool asked me to HOT 2
- The StringArrayEditor component returns error if you `ESC` out of it HOT 3
- A more legible dice font HOT 5
- Brew Theme Extensions HOT 5
- Support for "string" refs will be deprecated HOT 3
- Error saving HOT 1
- Window/Tab freezes on input of H1 header off the "page" (third column or later) - Firefox MacOS HOT 2
- ReactDOM.hydrate() is deprecated, console error HOT 6
- No dead-code elimination console error on live site
- Migrate from Vitreum to Webpack AND/OR other services HOT 7
- New Page: Database statistics HOT 1
- Using Monospace Fonts with any Editor Theme HOT 2
- Provide a Linkable URL to ID Heading HOT 2
- Bump CodeMirror to 6 HOT 1
- Block cloning HOT 5
- Issue while autosaviong the document HOT 1
- Not saving HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from homebrewery.