Giter VIP home page Giter VIP logo

Comments (3)

5e-Cleric avatar 5e-Cleric commented on June 23, 2024

Wow, but if it ain't an obscure bug that could have been laying there for 7 years and we wouldn't have noticed, i'm surprised i didn't find this one.

from homebrewery.

Gazook89 avatar Gazook89 commented on June 23, 2024

I have a fix but not sure it's 100% great yet. But at the same time, I have another question about this:

I would like to set , as a key used to "submit" the current tag and move to the next tag input, the same as the Enter key currently. I don't think this is super controversial, but please let me know if it is.

Further, I am wondering if Tab should do the same. My reflex is that yes, Tab should submit the current tag and move to the next. This would require using Esc to a currently non-existent container around the tags before the user could then use Tab again to move to the next field ("systems"). I am going to look into what specs are relevant for this kind of tag entry. I'm also likely fine with not doing this and just leaving Tab as an option to move to the next field ("systems") without submitting the current tag.

example of tags inside another container:
image

Finally, i think maybe that Tab-ing and Shift + Tab-ing across the tags should activate the 'edit input' state of each tag, rather than sort of skipping them like it does now.

from homebrewery.

Gazook89 avatar Gazook89 commented on June 23, 2024

to go further away from original reported issue, i think the stringArrayEditor could be styled a little better to match the Homebrewery UI. For example, get rid of the rounded corners.

from homebrewery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.