nautls / ergo-graphql Goto Github PK

When we use the following query as example, we can sometimes get an empty box in an input or get null proofBytes.

query Transactions { mempool { transactions { transactionId size timestamp inputs { box { boxId value address } proofBytes } } } }

@aslesarenko on fleet-sdk/fleet#17 (comment)

any wallet, can use it to reduce transactions (which is necessary for ErgoPay)
and the wallet don't need to have interpreter implementation available.

It's good to have some basic and advanced use-case examples in our documentation. This way, new users can dive into this project more quickly.

Currently, there is no way to know if a box is being used as an input in mempool. So I propose to add a boolean field called beingSpent in BoxResolver do address this as a one-query way.

If this field is selected in the query, it should return true if the boxId is present in node_u_inputs.

Observe that using @FieldResolver() decorator is not the best approach for this specific case, since it can result in multiple undesired database queries for a single GraphQL query. You can take a look at AddressResolver specifically at balance field to see a way to avoid this by using isFieldSelected function.

Version 4 of apollo server is out. We have to migrate our server alongside its dependencies to version 4. This could cause some breaking changes as well.

Filter tokens by the the minting box (Token.box field) with the following objects:

{
  ergoTree?: string;
  registers?: AdditionalRegisters;
}

or

{
  address?: string;
  registers?: AdditionalRegisters;
}

I just realized that we do not have an inputs field in the mempool resolver 😅, I think this is something necessary and should be added for the next release.

Fields

UnconfirmedInput contains all we need for now.

Query Args

Initially only indexed ones are required, namely boxId and transactionId.

Add some filters to get tokens containing or starting with a particular string.

This will allow programs to easily scan addresses for updates by using amount of boxes as a parameter. The problem is that since APIs only return around 50 or 500 boxes at most per call, we can't get box amount by getting the length of all boxes returned.

Instead of getting the mempool stuff from the database, we could request an ergo node. This way, we have fewer intermediaries and potentially faster calls.

Some use cases requires querying a box for multiple Token IDs.

Example:

If I want to fetch all boxes which contains tokenA and tokenB, I will pass Token IDs in containsTokens param and only boxes that contains both tokens will be returned.

Remarks

• I think 5 tokenIds per query is a reasonable limit
• Since conventionally we use multiple IDs as OR operator, would be good to make this different than other, so I suggest calling it containsTokens.

We need to complete the project's unit tests and make them run in GH-actions to ensure added code won't break anything.

Take confirmed box resolver as example.

Including mempool

These fields can be fetch from node's /info/ endpoint.

PS: difficulty should be nullable, and as all BigInt, it also should be encoded as string

Currently we have a way to check is an address is used by selecting transactionsCount field, if it is > 0 then the address is used, but I think we can verify this with a less resource spending query.

If used field is selected the resolver should look at node_outputs and return true if at least one box is owned by a given address.

In latest version this is fully broken with a large impact.
Source of the problem is this commit https://github.com/capt-nemo429/ergo-graphql/commit/e9a597855097e6efaa055cab668d730ff3f5f28d where maxHeight was forgotten to be removed from the resolver.

Tests were also not updated and not working atm.

We can retrieve headerId and digest from the extension object but the fields object does not work.
query Extension { blocks { header { extension { headerId digest fields } } } }

Unhandled errors are stopping the server.

While filtering more than one register (Eg. R5 and R6) the box query does not return proper boxes.
Sample query:

{
  boxes(
    spent: true, 
    ergoTree: "100504000400050004000e20011d3364de07e5a26f0c4eef0852cddb387039a921b7154ef3cab22c6eda887fd803d601b2a5730000d602e4c6a70407d603b2db6501fe730100ea02d1ededededed93e4c672010407720293e4c67201050ec5720391e4c672010605730293c27201c2a793db63087201db6308a7938cb2db63087203730300017304cd7202",
  	registers: {
      R5: "0e209060ac3dfc62aa0a14c87b9f45e57f13ea37815db956efb3a0ca5cd49dd37d9f",
      R6: "0590c7949406"
    }
  ){
    additionalRegisters
    ergoTree
  }
}

Currently .env doesn't contain an option for forcing SSL handshake for those DB connections which require it. Unless one is available but I am not aware of it.

Adding minHeight and maxHeight to resolvers would help more powerful filters throughout the code.

It's such a heavy query and not really necessary

With the new testnet, both mainnet and testnet miner fee ErgoTree are the same now. So there is no need to have a NETWORK env variable, as well as MAINNET_MINER_FEE_ERGO_TREE and TESTNET_MINER_FEE_ERGO_TREE constants.

So here is the task:

• Remove NETWORK env var (including from README);
• Rename MAINNET_MINER_FEE_ERGO_TREE to MINER_FEE_ERGO_TREE;
• Remove TESTNET_MINER_FEE_ERGO_TREE; and
• Adapt queries which make use of it to only query for MINER_FEE_ERGO_TREE.

If you try to fetch boxes without params, it will result in a long running query, better to avoid this by requiring at least one query param.

including mempool

Also include mempool