@jongmoon commented on Wed Jun 01 2016

Description

Now the pause/resume is not working on transform. But for more various animation effect, transform support is needed.

Steps to check or reproduce

$el.animate({"transform": "rotate(20deg)"}, 4000);

//before 4000 ms, you can pause or resume
$el.pause(); 

Description

Version information should be exposed on documentation like below.

You should apply following rules.

https://github.com/naver/egjs-flicking/blob/master/src/index.js#L7

Description

Need following job.

1. dist folder SHOULD NOT be omitted in github Tag.
2. dist/pauseresume.js SHOULD NOT be packaged with jquery.
3. dist/pauseresume.js SHOULD NOT be packaged with source map.
4. all dist files SHOULD be compiled with ModuleConcatenationPlugin.

Details

pause/resume is not accessible.
Because two jQuery is loaded.

Related Issue

change repository name and related : naver/egjs-jquery-transform#11

Description

This is jquery plugin. But User can't know that it is jquery plugin because current name(egjs-pauseresume) does not expose it.

It was needless to rename because egjs was developed using jquery. But Other egjs do not depend on jquery anymore.

New Name will be egjs-jquery-pauseresume

TODO

• egjs.yml
• demo.md
• CONTRIBUTING.md
• jsdoc.json
• NOTICE
• package.json
• README.md
• test/manual/index.html
• webpack.config.js
• demo
• repository name
• npm
• travisCI
• coveralls

Description

default keyword is used as normal property. But It makes exception on IE8, Android 2.3.x Browser. So keyword must be treated as a string.

BEFORE

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
var newProp = new _AniProperty2.default(type, el, prop, optall);

AFTER

function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
var newProp = new _AniProperty2["default"](type, el, prop, optall);

Description

Same with naver/egjs-jquery-transform#13

Ref jquery/jquery#2432

Solution

Most crucial issue is jquery version. But we've made egjs-jquery-transform working on 1.x ~ 3.x. And unit/manual test was successful on 3.x. So it is expected to not make problem.

Other dependency is trivial. So we'll update newest version.