naver / fixture-monkey Goto Github PK

View Code? Open in Web Editor NEW

440.0 440.0 73.0 23.86 MB

Let Fixture Monkey generate test instances including edge cases automatically

Home Page: https://naver.github.io/fixture-monkey

License: Apache License 2.0

Java 80.58% Kotlin 19.42%

java kotlin random-populated-object test

fixture-monkey's Introduction

Fixture Monkey

"Write once, Test anywhere"

Fixture Monkey is designed to easily generate controllable arbitrary instances. It allows you to reuse the same configurations of the instances in several tests.

You can write countless tests including edge cases, using just only one instance of the FixtureMonkey type. You can automatically generate instances of complex types and set fields with values from builders of the ArbitraryBuilder type. The well-defined builders can be reused in any test.

Each primitive type property is generated by Jqwik or kotest-property.

Requirements

JDK 1.8 or higher
Jqwik 1.7.3
Kotlin 1.8 or higher
kotest-property 5.6.2

Install

Gradle

Java

testImplementation("com.navercorp.fixturemonkey:fixture-monkey-starter:1.0.16")

Kotlin

testImplementation("com.navercorp.fixturemonkey:fixture-monkey-starter-kotlin:1.0.16")

Maven

Java

<dependency>
    <groupId>com.navercorp.fixturemonkey</groupId>
    <artifactId>fixture-monkey-starter</artifactId>
    <version>1.0.16</version>
    <scope>test</scope>
</dependency>

Kotlin

<dependency>
    <groupId>com.navercorp.fixturemonkey</groupId>
    <artifactId>fixture-monkey-starter-kotlin</artifactId>
    <version>1.0.16</version>
    <scope>test</scope>
</dependency>

Example

Add "lombok.anyConstructor.addConstructorProperties=true" in lombok.config

Java

@Value
public class Order {
    Long id;

    String orderNo;

    String productName;

    int quantity;

    long price;

    List<String> items;

    Instant orderedAt;
}

@Test
void sampleOrder() {
    // given
    FixtureMonkey sut = FixtureMonkey.builder()
            .objectIntrospector(ConstructorPropertiesArbitraryIntrospector.INSTANCE)
            .build();

    // when
    Order actual = sut.giveMeBuilder(Order.class)
            .set(javaGetter(Order::getOrderNo), "1")
            .set(javaGetter(Order::getProductName), "Line Sally")
            .minSize(javaGetter(Order::getItems), 1)
            .sample();

    // then
    then(actual.getOrderNo()).isEqualTo("1");
    then(actual.getProductName()).isEqualTo("Line Sally");
    then(actual.getItems()).hasSizeGreaterThanOrEqualTo(1);
}

Kotlin

data class Order (
    val id: Long,

    val orderNo: String,

    val productName: String,

    val quantity: Int,

    val price: Long,

    val items: List<String>,

    val orderedAt: Instant
)

@Test
fun sampleOrder() {
    // given
    val sut = FixtureMonkey.builder()
            .plugin(KotlinPlugin())
            .build()

    // when
    val actual = sut.giveMeBuilder<Order>()
            .setExp(Order::orderNo, "1")
            .setExp(Order::productName, "Line Sally")
            .minSizeExp(Order::items, 1)
            .sample()

    // then
    then(actual.orderNo).isEqualTo("1")
    then(actual.productName).isEqualTo("Line Sally")
    then(actual.items).hasSizeGreaterThanOrEqualTo(1)
}

Documentation

English

Third-party Modules

Plugins

FixtureMonkey Helper
- IntelliJ plugin that makes it easier to use Fixture Monkey string expressions & Kotlin DSL

Contributors

🐒 ah.jo
🐒 mhyeon-lee
🐒 acktsap
🐒 benelog
🐒 jwChung
🐒 SooKim1110

Thanks to all contributors

More about Fixture Monkey

Deview 2021

Articles

Welcome to write articles about Fixture Monkey!

License

Copyright 2021-present NAVER Corp.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
    http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

fixture-monkey's People

Contributors

Stargazers

Watchers

fixture-monkey's Issues

Unmappable character for encoding Cp1252

Describe the bug

The compilation fails on a system that us Cp1252 encoding due to the Korean comments.

Your environment

Fixture Monkey: 0.4.5
Java 17

Steps to reproduce

Compile the code using Cp1252 encoding.

Expected behaviour

Should compile successfully.

Actual behaviour

Compilation fails.

Comments causing the issue:

fixture-monkey\src\main\java\com\navercorp\fixturemonkey\arbitrary\ArbitraryTraverser.java:296

fixture-monkey\src\main\java\com\navercorp\fixturemonkey\arbitrary\DefaultContainerArbitraryNodeGenerator.java:141

fixture-monkey\src\main\java\com\navercorp\fixturemonkey\generator\ArrayBuilder.java:70

Set Value lazily

Set lazy value which is different when call set and call sample
New operation would determines value when call sample

As is

// given
ArbitraryBuilder<String> variable = fixture.giveMeBuilder(String.class);
ArbitraryBuilder<String> builder = fixture.giveMeBuilder(String.class)
    .set("$", variable.sample());
variable.set("test");

// when
String actual = builder.sample();

then(actual).isNotEqualTo("test");

To-be

// given
ArbitraryBuilder<String> variable = fixture.giveMeBuilder(String.class);
ArbitraryBuilder<String> builder = fixture.giveMeBuilder(String.class)
    .set("$", () -> variable.sample());
variable.set("test");

// when
String actual = builder.sample();

then(actual).isEqualTo("test");

It works even when sampled twice

// given
ArbitraryBuilder<String> variable = fixture.giveMeBuilder(String.class);
ArbitraryBuilder<String> builder = fixture.giveMeBuilder(String.class)
    .set("$", () -> variable.sample());
String expected = builder.sample();

// when
String actual = builder.sample();

then(actual).isEqualTo(expected);

Integration with Mockito

Please comment any features you had been impressed in Mockito, check it out if they could be supported by Fixture Monkey.
We'd like to make Fixture Monkey more friendly to Mockito users by improving fixture-monkey-mockito module

Support jakarta.validation annotations

https://docs.jboss.org/hibernate/stable/validator/reference/en-US/html_single/#validator-gettingstarted-createmodel

Cannot invoke "net.jqwik.api.Arbitrary.asGeneric()" because "this.arbitrary" is null

Describe the bug

Cannot invoke "net.jqwik.api.Arbitrary.asGeneric()" because "this.arbitrary" is null

Your environment

Java 17

FixtureMonkey - 0.4.10

Steps to reproduce

Run abstractTest().

https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/FixtureMonkeyTest.java

Expected behaviour

The test should pass.

Actual behaviour

I get this exception:

Cannot invoke "net.jqwik.api.Arbitrary.asGeneric()" because "this.arbitrary" is null

branch 전략 논의

다음 patch 버전을 올리기 위한 branch 와 과 break change 가 있어 마이너버전을 올리기 위한 branch 가 별도로 관리될 필요가 있을거 같습니다.
branch 전략을 어떻게 가져가면 좋을지 정할 필요가 있습니다.

Figure out why generating empty container in key

#418

Map<Map<String, String>, String>> 처럼 key 값이 컨테이너인 경우 생성할 때 반복적으로 size가 0인 경우가 발생한다.
size가 0이 되어 중복된 키가 발생하여 객체 생성에 실패하게 된다.
원인을 조사하고 정리한다.

컴파일 시점 평가 readonly

fixture-monkey/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/resolver/ArbitraryBuilderContext.java

Line 85 in 501211b

public List<ArbitraryManipulator> getManipulators() {

곁들여서 사용 중인 개인 프로젝트가 실제로 이 곳에서도 도움이 되지 않을까... 궁금해서 이슈를 남겨요.
제안하고자하는 내용은 아래와 같습니다.

Runtime 시점에서 평가되는 read-only collection을 컴파일 시점에서 평가되는 read-only collection으로

컴파일 시점에서의 평가가 생산성에 도움을 준다는 의견입니다.

감사합니다.

Generator for constructor in Java

현재 Java에서는 클래스내에 존재하는 필드를 생성하고 조합하여 객체를 만드는 Generator들만 지원하고 있다.
생성자를 사용하여 객체를 만드는 방법은 ConstructorPropertiesArbitraryGenerator 가 있지만,
생성자 위에 @ConstructorProperties를 명시해주어야 하고 필드에 없는 파라미터를 입력받을 경우 예외처리가 필요하다.

Kotlin에서는 PrimaryConstructorArbitraryGenerator가 생성자를 통해 객체를 생성할 수 있다.

생성자 기반으로 객체를 생성하는 경우를 지원하기 위해 새로운 Generator를 만든다.

Currently, Java only supports generators which create objects by creating and combining fields existing in the class.
There is a 'ConstructorPropertiesArbitraryGenerator' to create an object using the constructor,
'@ConstructorProperties' must be specified above the constructor, and exception processing is required if parameters that are not in the field are input.

In Kotlin, the 'PrimaryConstructorArbitraryGenerator' may generate an object through the generator.

A new generator is created to support the creation of objects based on the constructor.

Generate nested class

Describe the feature you request

Generating nested class.

An example below.

class A {
    class B {
        String value;
    }
}

Could generate an instance of B

(Optional): Suggest A Solution

A concise description of your preferred solution.

Add register and select ArbitraryBuilder by name

여러 종류의 ArbitraryBuilder 를 등록하고 선택할 수 있도록 이름을 부여할 수 있도록 지원합니다.

Add onManipulated

void onManipulated(BuilderManipulator manipulator)
ArbitraryBuilder에 연산을 적용하면 onManipulated 메소드가 실행됩니다.

ArbitraryBuilder 생성시 onManipulated를 manual로 입력할 수 있습니다.
e.g. fixture.giveMeBuilder(Class<?> clazz, Consumer<BuilderManipulator> onManipulated)
onManipulated는 생성할 때만 입력받고, 변경이 불가능해야 예측 가능할 것 같습니다.

사용 예제

특정 필드에 연산을 적용할 경우 후속 처리를 추가할 때 사용할 수 있습니다.
e.g. DeliveryMethodType이 Delivery일 때 필드 설정 등..
e.g. 결제 수단에 따라 달라지는 필드 값들 설정
#31 의 대안이 될 수 있지 않을까 싶습니다.

Labmonkey cannot set field

Replication:

https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/Bug.java

Since we can't generate fields that are interfaces, I'm setting the value manually but using Labmonkey it's always null.
If I use the old FixtureMonkey it works fine, and the value is set correctly.

Support for interface

It seems that FixtureMonkey always returns null for an interface arbitrary builder.
Is there any chance to support interface arbitrary builder?

If it is hard to scan implementation candidates automatically, you can just let users to give the candidates.

If we have an interface I and it's implementations A, B and C, it would be great to support this kind of feature.
(Please consider my code as a kotlin-like pseudo code.)

interface I

class A : I
class B : I
class C : I

val fixtureMonkey: FixtureMonkey

@Test
fun generateI() {
    val sampled: I = fixtureMonkey.giveMeBuilder<I>()
        .sample() // return null or throw an exception
}

@Test
fun generateAOrB() {
    val builder: ArbitraryBuilder<I> = fixtureMonkey.giveMeBuilder<I>(A::class.java, B::class.java)

    val sampled1: I = builder.sample() // return an instance of A or B
    val sampled2: I = builder.sample() // return an instance of A or B

    then(sampled1).is {
        it is A || it is B
    }
    then(sampled2).is {
        it is A || it is B
    }
    then(sampled1).isNotEqualTo(sampled2)
}

Thanks!

Partial build while generating map or set

map 혹은 set과 같이 element의 중복을 허용하지 않는 경우가 있다.
임의로 생성한 element가 중복되는 경우 생성하려는 element 개수보다 적게 생성될 수 있다.
지금은 filtering을 통해 객체 전체를 만족할 때 까지 반복적으로 생성한다.
부분적으로 map 혹은 set만 생성하도록 구현한다.

Incompatibility between BuilderArbitraryCustomizer and manipulating the instance

I have a class with a BuilderArbitraryCustomizer where I set some Arbitraries.
In my tests, I want to use giveMeBuilder(MyClass).set(fieldName_managed_by_arbitrary, myValue).sample() to get an instance with my wished values. This is the arbitrary I use:

.use(Arbitraries.strings().numeric().ofMaxLength(3)).in(MyClass.MyClassBuilder::myField);

Expected
Instance with my entered value

Current result
Instance with random value from the arbitrary

Add Unique operation

배경

Jqwik에서도 unique한 객체 생성을 지원하지만 컬렉션 내에서만 unique가 보장된다.
자식 객체의 컬렉션이 부모 객체 내부에 있을 경우에 jqwik의 기능을 사용해서 unique를 보장할 수 있지만 번거롭다.
Fixture Monkey에서 이 문제를 해결하고자 한다.

완료조건

동일한 ArbitraryBuilder에서 Unique 연산을 적용하여 생성한 객체는 유일함을 보장해야 한다.
Unique 연산은 생성할 객체 뿐만 아니라 생성하는 객체 내부의 객체에도 표현식을 통해 적용이 가능해야 한다.

refactor applying ArbitraryCustomizer not only for type but also for more conditions

As-is

공통으로 적용할 수 있는 ArbitraryCustomizer가 있어도 타입마다 등록을 해주어야 한다.
ex. ApplicationEvent 구현체

To-be

공통으로 적용할 수 있는 ArbitraryCustomizer는 한 번만 등록하면 조건에 해당하는 타입 모두 적용이 가능하다.

As-is

Even if there is an 'ArbitraryCustomizer' that can be commonly applied, registration must be made for each type.

To-be

'ArbitraryCustomizer', which can be commonly applied, can be applied to all types that meet the conditions by registering once.

Add Recorder in fixture-monkey-engine

ArbitraryBuilder 에서 build 시 반환하는 Arbitrary 의 구조를 개선합니다.
ArbitraryValue 가 Validation 과 ConstratinViolationException 등의 역할을 온전히 하지 못해서 구조를 다시 잡을 필요가 있습니다.
ArbitraryValue 는 제거하고 ArbitraryBuilder 에서 Validation Filter 를 주입하도록 합니다.
TooManyFilter... Exception 과 ConstratinViolationException 에 따른 기록과 로깅은 테스트 실패 callback 을 구현해서 기록하게 합니다.
기록을 위한 Recorder 설계가 필요합니다.

#39 (comment)

ArbitraryValue 가 공개 클래스가 아니기 때문에 구조 변경이 사용자에게 영향을 끼치지는 않습니다.

When putting a value through reflect, a permission denied Exception is thrown.

Hello, I am applying fixture monkey and strangely it works fine locally, but I get a complie error on the linux server.

error while writing /home1/irteam/.../P...Test$...Test1$...Test$1.class (Permission denied)

I tried taking a stacktrace, but I can't find any detailed information.
It seems that Permission denied occurs when you put a value through Relection.

fixture.giveMeBuilder(Attachment::class.java)
                .setExp(
                    Attachment::fileType,
                    Arbitraries.of(FileType.FILE, FileType.VIDEO, FileType.IMAGE)
                )
                .sampleList(30)

class Attachment(
    val fileType: FileType,  
)

The fixture monkey version uses a snapshot version as shown below.

testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-starter:0.4.0-dd71410")
testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-kotlin:0.4.0-dd71410")
testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-mockito:0.4.0-dd71410")
testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-jackson:0.4.0-dd71410")

Do you have any solution?

===========================================================================
안녕하세요 fixture monkey 를 적용중인데 이상하게 local 에서는 괜찮은데, linux 서버위에서 complie 에러가 납니다.

error while writing /home1/irteam/.../P...Test$...테스트1$... 테스트한다$1.class (Permission denied)

stacktrace 를 찍어봐도 자세한 정보가 안나오는데요.
Relection 을 통해 값을 넣어줄 때 Permission denied 발생하는 것으로 보입니다.

fixture.giveMeBuilder(Attachment::class.java)
                .setExp(
                    Attachment::fileType,
                    Arbitraries.of(FileType.FILE, FileType.VIDEO, FileType.IMAGE)
                )
                .sampleList(30)

class Attachment(
    val fileType: FileType,  
)

fixture monkey 버전은 아래와 같이 스냅샷 버전을 쓰고 있습니다.

		testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-starter:0.4.0-dd71410")
		testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-kotlin:0.4.0-dd71410")
		testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-mockito:0.4.0-dd71410")
		testImplementation("com.navercorp.fixturemonkey.snapshot:fixture-monkey-jackson:0.4.0-dd71410")

혹시 해결 방법이 있을까요?

Add Expression strict mode

Expression 값이 실제 모델에 매핑되지 않는 다면 에러를 내는 strict mode 를 추가합니다.
모델의 필드명이나 스펙이 변경되었을 때 expression 도 같이 수정해줘야 하는데 놓칠경우 이를 검증하는 용도로 유용하게 사용할 수 있습니다.

size in apply not working when registering size manipulation

테스트

@Property
void applySizeWhenRegisteredWithSize() {
// given
LabMonkey sut = LabMonkey.labMonkeyBuilder()
	.register(
		ListStringObject.class,
		fixture -> fixture.giveMeBuilder(ListStringObject.class).size("values", 5)
	)
	.build();

// when
List<String> actual = sut.giveMeBuilder(ListStringObject.class)
	.apply((it, builder) -> builder.size("values", 10))
	.sample()
	.getValues();

then(actual).hasSize(10);
}

Randomly apply manipulator when applying manipulator with limit

ArbitraryNodes found by expression has fixed ordering.
So applying manipulator with parameter limit, which parameter used as limiting the number of applied ArbitraryNode, always returns same applied ArbitraryNode.
It is not an intuitive result.

In short, this issue is to shuffle all ArbitraryNodes found by ArbitraryExpression.

적용 회수를 입력받는 연산 (limit 을 입력받는 연산)에서 조회한 노드 순서대로 적용하는 게 아니라 랜덤하게 적용하도록 수정합니다.

Add fixture-monkey-engine module for split junit, jqwik engine dependency

junit-platform-engine 과 jqwik-engine 을 분리하기 위해 fixture-monkey-eninge 모듈로 분리합니다.

Test code intermittently fails when using JavaxValidationPlugin

Describe the bug

Test code intermittently fails when using JavaxValidationPlugin

Your environment

version of Fixture Monkey: 0.4.11
version of Java/Kotlin: Kotlin 1.7.22

Steps to reproduce

Repository that reproduced the problem

I wrote 2 test codes. This test code does the same logic. Only the presence or absence of LabMonkey's JavaxValidationPlugin that creates fixtures is different.

@Test
fun getSavedQuestionnaire() {
    val uri = "/test"
    val sut: LabMonkey = LabMonkey.labMonkeyBuilder()
        .defaultNullInjectGenerator { DefaultNullInjectGenerator.NOT_NULL_INJECT }
        .plugin(KotlinPlugin())
        .plugin(JacksonPlugin())
        .build()
    val fixture = sut.giveMeOne<TestDataClass>()
    println(fixture.toString())
    every { testService.test() } returns fixture

    mockMvc
        .perform(MockMvcRequestBuilders.get(uri))
        .andExpect(MockMvcResultMatchers.status().isOk)
        .andExpect(MockMvcResultMatchers.jsonPath("$.id").value(fixture.id))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name").value(fixture.name))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name2").value(fixture.name2))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name3").value(fixture.name3))
        .andDo(MockMvcResultHandlers.print())
}

// Fails intermittently
@Test
fun getSavedQuestionnaireWithJavaxPlugin() {
    val uri = "/test"
    val sut: LabMonkey = LabMonkey.labMonkeyBuilder()
        .defaultNullInjectGenerator { DefaultNullInjectGenerator.NOT_NULL_INJECT }
        .plugin(KotlinPlugin())
        .plugin(JacksonPlugin())
        .plugin(JavaxValidationPlugin())
        .build()
    val fixture = sut.giveMeOne<TestDataClass>()
    println(fixture.toString())
    every { testService.test() } returns fixture

    mockMvc
        .perform(MockMvcRequestBuilders.get(uri))
        .andExpect(MockMvcResultMatchers.status().isOk)
        .andExpect(MockMvcResultMatchers.jsonPath("$.id").value(fixture.id))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name").value(fixture.name))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name2").value(fixture.name2))
        .andExpect(MockMvcResultMatchers.jsonPath("$.name3").value(fixture.name3))
        .andDo(MockMvcResultHandlers.print())
}

Expected behaviour

JavaxValidation plug-in was added, but there is no part where javax.validation-related logic is used in fixture.
Therefore, I expect the same result, i.e. pass both test cases.

Actual behaviour

Test cases using JavaxValidationPlugin fail intermittently.

Additional info

It could be a bug in Spring and related tools, or my lack of proficiency in using it
Not exactly accurate, but the output of the path seems to be a Unicode-related issue.

StackOverflowError

If I have the following classes:

record Author( String name, List<Book> books )

record Book( String name, Author author )

Replication:

https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/StackOverflow.java

If now I try to generate a Book I will get a StackOverflowError since it will keep generating into infinity.

It would be ideal to have some sort of limit.

Cannot set field if class doesn't contain same fields

Describe the bug

When setting a field sometimes it fails.

It seems that if the class generated that will be replaced contains fields that the other class doesn't contain it fails.

Your environment

Java 17 - FixtureMonkey - 0.4.9

Steps to reproduce

Run abstractTest() multiple times until it fails

https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/FixtureMonkeyTest.java

Expected behaviour

Should work all the times and set the field correctly.

Actual behaviour

The field is not set sometimes.

Can not set java.lang.String field com.example.bug.Peter.age to com.example.bug.John
java.lang.IllegalArgumentException: Can not set java.lang.String field com.example.bug.Peter.age to com.example.bug.John
	at java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:167)
	at java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:171)
	at java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:58)
	at java.base/jdk.internal.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36)

EnumMap isn't generated if the number of enum values is less than container min size

If the container size is bigger then the number of enum values it will fail to generate the EnumMap.

This is a special case that should ignore the min container size.

Sample project:
https://github.com/esfomeado/monkey-enum-bug

Two tests are provided:

void testWillAlwaysFail() - It will fail always since the container size is bigger than the number of enum values.

void testSometimesFail() - It will only fail sometimes since sometimes the container size is the same as the number of enum values.

Add ExTree Third-party Module for expression

https://github.com/streamx-co/ExTree
https://github.com/TrigerSoft/jaque#java-query

Is there a way to create a Kotlin data class where all properties have non-nullable values?

Describe your question

Is there a way to create a Kotlin data class where all properties have non-nullable values?

For example...

data class A(
    val id:Long?,
    val name:String?,
    val inner: B?
)

data class B(
    val id:Long?,
    val name:String?,
    val inner: C?
)

data class C(
    val id:Long?,
    val name:String?,
)

When I have the class structure as above and create a fixture of class A with LabMonkey, I want to make all properties of class A non-nullable, and properties of its subclass(in this case, B & C) not only it's properties, but also itself too.

Is there any combination of settings that I can use in a situation like the one above?

FYI, the configuration below seems not work 😭

val sut = LabMonkey.labMonkeyBuilder()
    .defaultNotNull(true)
    .plugin(KotlinPlugin())
    .build()

Add defaultNotEmpty

It would be cool to have a option to always generate the lists with elements similar to how defaultNotNull works but in this case for always generating values on lists.

Add Caching

캐싱을 적용합니다.

동일한 테스트 내에서 같은 객체를 여러 번 생성하는 경우는 드문 경우이기 때문에,
캐싱을 적용해도 큰 성능 차이는 없을 것으로 예상하지만 같은 동작은 하지 않으므로 디버깅이 편해질 것 같다.
작업 우선순위는 높지 않다.

Build

decompose인 경우 캐시를 적용하지 않는다.
build() 에서 tree를 이미 생성한 경우 캐싱하여 사용하도록 수정한다.
traverse할 때 입력한 타입이 이미 가상 클래스 트리를 생성했으면 생성하지 않고 캐싱한 결과를 사용
3.1. 연산 적용하는 경우를 Traverser에서 식별해야 한다. (참조 머클트리, 블룸필터?)
3.2. Traverser는 같은 Fixture Monkey 인스턴스에서 생성한 ArbitraryBuilder에서 공유한다.

3번의 경우, 리스트를 필드로 가지고 있고, 리스트의 타입이 많은 필드를 가질 경우 유의미한 성능 차이를 만들어낼 수 있음. (e.g. 피보나치 DP)
3번을 해결할 때, 양방향 참조 문제도 해결할 것이라 예상. 해결 방식은 추후 고민이 필요.

Sample

fixed()를 적용하고 isDirty()가 아닌 경우, 항상 같은 값을 반환하므로 sample()이 실행될 때 root의 lazyValue 값을 반환한다.

주의 해야할 점

Lazy Evaluation

Upgrade jqwik 1.6.0 version

jqwik 1.6.0 version 으로 upgrade 합니다.
jqwik 의 braking change 를 대응합니다.
#34 #35 가 선행되어야 합니다.

Add InnerSpec Kotlin Exp functions

propertyExp, propertyExpGetter should be supported.

Sample test in README seems not to be working

Describe your question

Looks like an interesting library. I wanted to try it out, but the sample test in the README did not work for me:

    @Test
    void sampleOrder() {
        // given
        LabMonkey sut = LabMonkey.labMonkeyBuilder()
                .objectIntrospector(ConstructorPropertiesArbitraryIntrospector.INSTANCE)
                .build();

        // when
        Order actual = sut.giveMeBuilder(Order.class)
                .set("orderNo", "1")
                .set("productName", "Line Sally")
                .minSize("items", 1)
                .sample();

        System.out.println(actual);
       // produces:
       // Order(id=null, orderNo=null, productName=null, quantity=0, price=0, items=null, orderedAt=null)

        // then
        then(actual.getOrderNo()).isEqualTo("1");
        then(actual.getProductName()).isEqualTo("Line Sally");
        then(actual.getItems()).hasSizeGreaterThanOrEqualTo(1);
    }

Dependency:

testImplementation 'com.navercorp.fixturemonkey:fixture-monkey-starter:0.4.10'

Cannot set field

Describe the bug

When setting a field where the parent is an abstract class and the parent of the parent is also an abstract class it throws an error saying No resolved property is found.

Your environment

Java 17

FixtureMonkey - 0.4.10

Steps to reproduce

Run abstractTest().

https://github.com/esfomeado/fixture-monkey-bug/blob/master/src/test/java/com/example/bug/FixtureMonkeyTest.java

Expected behaviour

Should set the field correctly.

Actual behaviour

Throws error message saying No resolved property is found.

Add Map Expression

Map 타입을 제어할 수 있는 Expression 을 추가합니다.

Display what field failed to generate

It would be useful to know which field failed to generate instead of a generic message since sometimes isn't straightforward to see which field failed to generate and why.

Add PR Builder with various Java Version

아래와 같이 다양한 Java Version 으로 문제가 없는지 PR Builder 를 돌릴 수 있으면 좋을거 같습니다.

JacksonArbitraryIntrospector used instead of FieldReflectionArbitraryIntrospector

Describe the bug

If I set a field to use the JacksonArbitraryIntrospector all the field fields will now use the JacksonArbitraryIntrospector instead the default one.

Your environment

Java 17

FixtureMonkey - 0.4.10

Steps to reproduce

Run invalidIntrospector on https://github.com/esfomeado/fixture-monkey-bug/blob/f5ca2c55e543a04cab279245fddfe6b946f59e5a/src/test/java/com/example/bug/FixtureMonkeyTest.java

Expected behaviour

Should generate the class correctly.

Actual behaviour

Class not generated.

Cannot construct instance of com.example.bug.Condition (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information

Generate anonymous object

Describe the feature you request

Generate an anonymous object from interface or abstract class.

(Optional): Suggest A Solution

Have to find out if it could be a Java feature or just only Kotlin feature.

Abstract class

Have to research more

Interface

Generate object by using dynamic proxy.

NullPointerException when using IterableSpec any()

Bug Report

@Test
void any() {
    // given
    FixtureMonkey fixture = FixtureMonkey.create();
    ExpressionSpec spec = new ExpressionSpec()
        .list("items", it -> {
            it.ofMinSize(2);
            it.any("set");
        }
    );
    
    // when
    Order actual = fixture.giveMeBuilder(Order.class)
        .spec(spec)
        .sample();
    
    then(actual.getItems()).anyMatch(it -> it.equals("set"));
}

it.any()를 사용하기 전에 사이즈를 지정하지 않거나 it.ofMinSize()로 min size만 설정(혹은 max size만 설정)하면 NullPointerException이 발생한다.

IterableSpec을 구현한 DefaultIterableSpec에서 any()를 적용할 노드의 개수 limit을 계산할 때

Arbitraries.longs().between(this.minSize, this.maxSize).sample();

위 코드처럼 minSize와 maxSize를 이용하는데, minSize 또는 maxSize가 미리 설정되지 않아서 NullPointerException이 발생하는 것으로 보인다.

Refactor container builder for scalability

Container를 조합하는 Builder를 사용자가 추가할 수 있도록 구조를 변경합니다.

Generator on kotlin secondary constructor

secondary constructor에 대한 generator

한개만 있으면 그걸 사용하고 여러개가 있을 경우 annotation을 사용해서 mark

data class A(val value: Int) {
     constructor() : this(0) {
         // do something
     }

     @SecondaryConstructor // 이런 식으로
     constructor(val value: String) : this(value.toInt()) {
         // do something
     }

}

Extending generic class results in stack overflow

Describe the bug

I've been playing around with some of the examples and ran into an issue extending a generic class.
Creating an instance of the subclass results in a stack overflow error.
Maybe I am missing some setup for this to work. If so, please let me know.

Your environment

version of Fixture Monkey: 0.4.11
version of Java: 17

Steps to reproduce

class Foo<T> {
    T foo;
}

class Bar extends Foo<String> {
    Double bar;
}

@Test
void example() {
    FixtureMonkey sut = FixtureMonkey.builder()
            .defaultGenerator(BeanArbitraryGenerator.INSTANCE)
            .build();

    Bar actual = sut.giveMeOne(Bar.class);

    assertThat(actual).isNotNull();
}

Expected behaviour

Return an instance of the class

Actual behaviour

java.lang.StackOverflowError
	at java.base/java.util.ArrayList.grow(ArrayList.java:244)
	at java.base/java.util.ArrayList.add(ArrayList.java:454)
	at java.base/java.util.ArrayList.add(ArrayList.java:467)
	at java.base/java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682)
	at org.junit.platform.commons.util.ReflectionUtils.findAllFieldsInHierarchy(ReflectionUtils.java:1204)
	at org.junit.platform.commons.util.ReflectionUtils.findFields(ReflectionUtils.java:1190)
	at com.navercorp.fixturemonkey.TypeSupports.extractFields(TypeSupports.java:92)
	at com.navercorp.fixturemonkey.arbitrary.ArbitraryTraverser.doTraverse(ArbitraryTraverser.java:111)
	at com.navercorp.fixturemonkey.arbitrary.ArbitraryTraverser.doTraverse(ArbitraryTraverser.java:140)
	at com.navercorp.fixturemonkey.arbitrary.ArbitraryTraverser.doTraverse(ArbitraryTraverser.java:140)

Refactor decompose

As-is

현재는 decompose 연산을 실행하면 트리에 값을 설정하고, traverser에서 값을 arbitrary로 변환해서 노드에 할당한다.
노드는 Supplier를 가지고 있고 Lazy하게 값을 반환한다. 실제 Traverser에서 값을 요청할 때 값을 생성한다.
값을 생성하는 시점이 예측 불가하고, 기존 연산과 다르게 동작하여 예상치 못한 예외가 발생하는 경우가 많다.

To-be

개선안은 다음과 같다.
decompose 연산을 기존 Set 연산을 활용하는 방식으로 변경한다.
값을 설정할 때(Set) 값을 분해하여 하위 노드에 설정한다.

이렇게 변경하면 상위 필드 값을 변경한 후에 하위 필드 값을 변경할 수 있다.
e.g.

class Person{
    Company company;
}

class Company{
    String name;
    String description;
}

현재는 아래와 같은 연산을 실행하면 2번 째 연산이 적용되지 않는다.
이는 일반적으로 예측한 동작 결과와 다르다.

.set("company", new Company("NAVER"))
.set("company.name", "NCloud")

예상하는 문제점

이전 구조와 다르게 sample할 때 마다 동적으로 값을 지정할 수 없다.

개선안을 적용하면 이 문제를 해결하고, 복잡도를 크게 줄일 수 있다.

Remove org.junit.platform.x dependencies

Remove org.junit.platform.xx dependencies.
Replace the utility code of org.junit.platform.xx to use internal code.

For example, removing the BeanArbitraryGenerator ReflectionUtils usage code and replace it with a utility code that does the same thing inside.

org.junit.platform.xx 의 유틸리티 사용한 코드들을 내부 코드를 사용하도록 대체합니다.
코드에서 org.junit.platform.xx 의존 코드들을 제거합니다.

예를 들어 BeanArbitraryGenerator 의 ReflectionUtils 사용 코드를 제거하고 동일한 동작을 하는 유틸리티 코드를 내부에 작성해서 대체합니다.

Add a new module supports datafaker

Describe the feature you request

Add a new module supports datafaker

AutoAssign 설정

PR 이 올라오면 AutoAssign 을 걸어도 좋을거 같습니다.

adjust specAny manipulators order

연산은 세 가지 종류가 있다.
MetadataManipulator -> OrderedArbitraryManipulator -> PostArbitraryManipulators 의 순서로 실행이 된다.

MetadataManipulator 는 우선순위에 따라 정렬해서 실행한다.
OrderedArbitraryManipulator, PostArbitraryManipulators 는 연산을 선언한 순서대로 실행한다.

specAny를 사용하면 세 종류의 연산에 설정한 연산 적용 순서가 적용되지 않는다.

There are three types of operations.
It is executed in the order of 'MetadataManipulator' -> 'OrderizedArbitraryManipulator' -> 'PostArbitraryManipulator'.

'MetadataManipulator' is executed in order of priority.
OrderedArbitraryManipulators and PostArbitraryManipulators are executed in the order in which operations are declared.

With specAny, the order of operation application set for the three types of operations is not applied.

naver / fixture-monkey Goto Github PK

fixture-monkey's Introduction

Fixture Monkey

"Write once, Test anywhere"

Requirements

Install

Gradle

Java

Kotlin

Maven

Java

Kotlin

Example

Java

Kotlin

Documentation

Plugins

Contributors

More about Fixture Monkey

Articles

License

fixture-monkey's People

Contributors

Stargazers

Watchers

Forkers

fixture-monkey's Issues

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

As is

To-be

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

Describe the feature you request

(Optional): Suggest A Solution

사용 예제

배경

완료조건

As-is

To-be

As-is

To-be

테스트

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

Additional info

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

Describe your question

Build

Sample

주의 해야할 점

Describe your question

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

Describe the bug

Your environment

Steps to reproduce

Expected behaviour

Actual behaviour

Describe the feature you request

(Optional): Suggest A Solution

Abstract class

Interface

Describe the bug