Is there a way for the DefaultNullInjectGenerator to identify annotations with a CLASS retention policy? about fixture-monkey HOT 5 CLOSED

I have tried your solution. but i think it does not work.

sample code repo: null-inject-test branch

	@Data
	public static class JetBrainAnnotationObject {
		@org.jetbrains.annotations.NotNull
		private String value;

		@ConstructorProperties({"value"})
		public JetBrainAnnotationObject(String value) {
			this.value = value;
		}
	}

FixtureMonkeyTestSpecs.JetBrainAnnotationObject jetBrainAnnotationObject = FixtureMonkey.builder()
	.objectIntrospector(ConstructorPropertiesArbitraryIntrospector.INSTANCE)
	.pushNullInjectGenerator(
		new MatcherOperator<>(
			property -> {
				boolean present = property.getAnnotation(NotNull.class).isPresent();
				return present;
			},
			context -> NOT_NULL_INJECT
		)
	)
	.build()
	.giveMeOne(FixtureMonkeyTestSpecs.JetBrainAnnotationObject.class);

If i check the result of property.getAnnotation(NotNull.class).isPresent(); it is always false.
property does not have jetbrain @NotNull annotation in annotationMap.

from fixture-monkey.

@jbl428
Yes, it sounds great.
If you don't mind, could you make a PR for removing annotations whose retention policy is CLASS in DefaultNullInjectGenerator?
It would be very helpful.

from fixture-monkey.

@jbl428
Hello, I think you'd better to use pushNullInjectGenerator option.

You could use this option as below.

.pushNullInjectGenerator(
	new MatcherOperator<>(
		property -> property.getAnnotation(NotNull.class).isPresent(),
		context -> NOT_NULL_INJECT
	)
)

It would be worked for all properties have @NotNull.
If you have any more questions, please feel free to ask.

from fixture-monkey.

@jbl428
As I know, @org.jetbrains.annotations.NotNull is an annotation for IntelliJ IDEA's static analysis, not for validation.
Due to its purpose, It could not be captured in runtime.

I think It is better to use Bean Validation annotations.
Are there any reasons for using @org.jetbrains.annotations.NotNull instead of Bean Validation annotations?

from fixture-monkey.

@seongahjo
My project is written in Java for the entity classes and uses kotiln for the business logic.
To take advantage of kotiln's null safety, each entity's properties must be annotated to satisfy JSR305 (like @org.jetbrains.annotations.NotNull)

I found that org.springframework.lang.NonNull is another jsr305 compliant annotation and the retention policy is RUNTIME, so I could use this annotation.

My suggestion is to remove annotations whose retention policy is CLASS in DefaultNullInjectGenerator.
What do you think?

from fixture-monkey.