nealium / django-plus.vim Goto Github PK

Add extra options to disable Django Syntax, Python & DjangoHTML independently. (Clashes with my existing color scheme)

Add option to use Sys calls instead of pydo's

Already done, but will make it a separate branch

Fixes conflict specifically with vim-qf's QuickFix functions. QuickFix, in general, should be skipped with this function
Issue could effect other Plugins in similar situations, but this commit only solves QuickFix.

Specs:

• Vim: Vim 9 (64bit)
• OS: Windows 10 & Pop!_OS/Ubuntu

How to recreate

• Install both vim-qf & django-plug
• Goto any Django Project's view.py
• :copen + :cclose + :copen + :cclose
  • Open/Close 2 or more times

Result:

Error detected while processing FileType Autocommands for "*"..function <SNR>7_LoadFTPlugin

• Note: {x}_LoadFTPlugin x changes based on whatever pid vim{v}\ftplugin.vim is in :scriptnames
• Offending command in ftplugin.vim is: legacy exe b:undo_ftplugin

With tinkering, using :make, the error message [below] also shows up

Error detected while processig QuickFixCmdPost Autocommands for "make"..function qf#OpenQuickfix[17]..fileFileType Autocommands for "*"..function <SNR>6_LoadFTPlugin:
Line: 3:
E184: No such user-defined command: Filter

Theory:

# :help undo_ftplugin 
When the user does ":setfiletype xyz" the effect of the previous filetype
should be undone.

When setting the filetype of QuickFix to qf again, it undoes all vim-qf's functions which causes vim-qf to crash.
Seeing most Plugins are designed to define functions one time, Django-Plus should avoid inadvertently removing them; especially with QuickFix which is a special case

Notes of behavior

function! djangoplus#detect#filetype(filename) abort

  " Passed with: djangoplus#detect#filetype(expand('<afile>:p')
  echom 'filename ' . a:filename

  " expanded inside the function
  echom 'expand path ' . expand('%:p')

  " filetype Output 
  echom 'filetype &l ' . &l:filetype

  " ... more stuff

endfunction

1) Opening views.py

filename            /path/to/project/app1/views.py
expand path         /path/to/project/app1/views.py
filetype &l         

2) Opening QuickFix

filename            /path/to/project/quickfix
expand path         
filetype &l         qf

Point:

This illustrates why the original empty(a:filename) isn't catching the QuickFix.

Vim's pydo/py3do functions run the template finder function 3020 times, freezing up vim for ~10 seconds.
py / py3 commands only run it once and freeze vim for < ~1 second
Note: This is problem is only for the initial search, but 10 seconds is a long wait.

Specs:

• Vim: Vim 9 (64bit)
  • Python2 & Python3 versions tested
• OS: Windows 10 & Pop!_OS/Ubuntu

Illustrating the Issue

add Func to django-plus.vim/bin/template_finder.py

def record_start():
    from datetime import datetime
    logger = open('/path/to/my/plugins/django-plus.vim/start_times.txt', 'a')
    logger.write('{0}\n'.format(datetime.now()))
    logger.close()

def djangoplus_find_templates(cwd, app_paths, cmdline=False):
    record_start()

    # do the normal stuff

1. Goto a view's reverse function
2. ci' or ci"
3. Type something
4. Check file

Already fixed with 421aff7

As the original repo is very cold and I don't want to spam pull requests