neatmonster / serveur Goto Github PK

C'est étrange, d'après le log ci-dessous, il n'y a qu'un deregister qui fait ça. Pourtant il me semble que tous les items sont registered et deregistered de la même manière.

L'output de valgrind :

  <tid>1</tid>
  <kind>InvalidFree</kind>
  <what>Invalid free() / delete / delete[] / realloc()</what>
  <stack>
    <frame>
      <ip>0x4C2C2E0</ip>
      <obj>/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so</obj>
      <fn>operator delete(void*)</fn>
    </frame>
    <frame>
      <ip>0x6A18A9</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>Item::deregisterItems()</fn>
    </frame>
    <frame>
      <ip>0x6F8C8C</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>Server::~Server()</fn>
    </frame>
    <frame>
      <ip>0x6F8D39</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>Server::~Server()</fn>
    </frame>
    <frame>
      <ip>0x6F85A7</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>main</fn>
    </frame>
  </stack>
  <auxwhat>Address 0x5cb1e78 is 8 bytes inside a block of size 104 alloc'd</auxwhat>
  <stack>
    <frame>
      <ip>0x4C2B100</ip>
      <obj>/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so</obj>
      <fn>operator new(unsigned long)</fn>
    </frame>
    <frame>
      <ip>0x69ADC2</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>Item::registerItems()</fn>
    </frame>
    <frame>
      <ip>0x6F8A3B</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>Server::Server(unsigned short)</fn>
    </frame>
    <frame>
      <ip>0x6F8593</ip>
      <obj>/home/licks92/Documents/Github/Serveur/bin/Serveur</obj>
      <fn>main</fn>
    </frame>
  </stack>```

Les logs sont très longs, et les stacks encore plus. Il faut absolument trouver un moyen de logger ça efficacement.

Je m'y assigne personnellement.

Cette erreur arrive dans n'importe quel type de déconnexion : Après un bug ou par simple déconnexion du client.

Stack :
Thread 1:
==13014== Invalid read of size 4
==13014== at 0x4ADF5C: Chunk::getX() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AEEAE: World::removePlayer(Player_) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4778A7: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x477923: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x490D9D: PlayerConnection::~PlayerConnection() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x49C32E: NetworkManager::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2CEC: Server::run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2B90: Server::Server() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A27D9: main (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== Address 0x5c86f18 is 8 bytes inside a block of size 1,472 free'd
==13014== at 0x4C2C2BC: operator delete(void_) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==13014== by 0x4AF495: World::unloadChunk(std::pair<int, int>) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AF0C1: World::tryUnloadChunk(std::pair<int, int>) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AEEE1: World::removePlayer(Player_) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4778A7: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x477923: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x490D9D: PlayerConnection::~PlayerConnection() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x49C32E: NetworkManager::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2CEC: Server::run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2B90: Server::Server() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A27D9: main (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014==
==13014== Invalid read of size 4
==13014== at 0x4ADF7C: Chunk::getZ() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AEEBD: World::removePlayer(Player_) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4778A7: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x477923: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x490D9D: PlayerConnection::~PlayerConnection() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x49C32E: NetworkManager::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2CEC: Server::run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2B90: Server::Server() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A27D9: main (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== Address 0x5c86f1c is 12 bytes inside a block of size 1,472 free'd
==13014== at 0x4C2C2BC: operator delete(void_) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==13014== by 0x4AF495: World::unloadChunk(std::pair<int, int>) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AF0C1: World::tryUnloadChunk(std::pair<int, int>) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4AEEE1: World::removePlayer(Player_) (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4778A7: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x477923: Player::~Player() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x490D9D: PlayerConnection::~PlayerConnection() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x49C32E: NetworkManager::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2CEC: Server::run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A2B90: Server::Server() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014== by 0x4A27D9: main (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13014==

Cette fonctionnalité absolument nécessaire devrait nous permettre de prendre l'avantage sur les networks de mini-jeu concurrents.

Featuring Barry White.

Stack (client) :

[20:00:34] [Client thread/INFO]: [CHAT] licks92 a rejoint la partie
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 152122, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 0/WARN]: Biome ID is out of bounds: 151720, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: -1, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: -1, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: -1, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: -1, defaulting to 0 (Ocean)
[20:00:38] [Chunk Batcher 1/WARN]: Biome ID is out of bounds: -1, defaulting to 0 (Ocean)

==13030== Thread 4:
==13030== Source and destination overlap in memcpy(0x5c3f930, 0x5c3f93c, 216)
==13030== at 0x4C2F71C: memcpy@@GLIBC_2.14 (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==13030== by 0x49A47C: ByteBuffer::compact() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4903B9: PlayerConnection::runRead() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x495481: ZNKSt7_Mem_fnIM16PlayerConnectionFvvEEclIJEvEEvPS0_DpOT (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4953E1: _ZNSt12_Bind_simpleIFSt7_Mem_fnIM16PlayerConnectionFvvEEPS1_EE9_M_invokeIJLm0EEEEvSt12_Index_tupleIJXspT_EEE (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x495394: std::_Bind_simple<std::Mem_fn<void (PlayerConnection::*)()> (PlayerConnection)>::operator()() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x49536B: std::thread::_Impl<std::_Bind_simple<std::Mem_fn<void (PlayerConnection::)()> (PlayerConnection*)> >::_M_run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4EE8BEF: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==13030== by 0x565F181: start_thread (pthread_create.c:312)
==13030== by 0x596FEFC: clone (clone.S:111)
==13030==
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 WARNING] Impossible de suivre. Peut-être que le serveur est surchargé ?
[20:00:34 INFO] /78.193.50.69:62914 a reçu un paquet 21PacketPlayerAbilities
==13030== Invalid read of size 8
==13030== at 0x4904CF: PlayerConnection::runRead() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x495481: ZNKSt7_Mem_fnIM16PlayerConnectionFvvEEclIJEvEEvPS0_DpOT (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4953E1: _ZNSt12_Bind_simpleIFSt7_Mem_fnIM16PlayerConnectionFvvEEPS1_EE9_M_invokeIJLm0EEEEvSt12_Index_tupleIJXspT_EEE (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x495394: std::_Bind_simple<std::Mem_fn<void (PlayerConnection::*)()> (PlayerConnection)>::operator()() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x49536B: std::thread::_Impl<std::Bind_simple<std::Mem_fn<void (PlayerConnection::)()> (PlayerConnection)> >::M_run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4EE8BEF: ??? (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19)
==13030== by 0x565F181: start_thread (pthread_create.c:312)
==13030== by 0x596FEFC: clone (clone.S:111)
==13030== Address 0x9035470 is 0 bytes inside a block of size 32 free'd
==13030== at 0x4C2C2BC: operator delete(void) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==13030== by 0x48EB41: PacketClientSettings::~PacketClientSettings() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x491127: PlayerConnection::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x49C3C1: NetworkManager::handlePackets() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4A2CEC: Server::run() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4A2B90: Server::Server() (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030== by 0x4A27D9: main (in /var/lib/jenkins/workspace/Serveur/build/Serveur)
==13030==
[20:00:34 INFO] /78.193.50.69:62914 a envoyé un paquet 20PacketClientSettings

Problème avec l'écriture des tags NBT. Facile à reproduire, il suffit de dropper un livre enchanté pour faire crasher le client. À fixer une fois le refactoring avec les shared_ptrs terminé.

J'avais spécifié le port 25567, voici le log :
[13:08:54 INFO] Démarrage du serveur version 1.8.1
[13:08:54 INFO] Connexion à MongoDB établie avec succès
[13:08:54 INFO] Démarrage du serveur sur le port 25567
[13:11:59 INFO] Extinction du serveur
*** Error in ./Serveur': free(): invalid pointer: 0x0000000002423a88 *** Abandon (core dumped) licks92@licks92-Lubuntu:~/Documents/Github/Serveur/bin$`

Je vais me pencher dessus dans peu de temps.

Plus d'info ici : http://minecraft.gamepedia.com/Hunger#Exhaustion_level_increase

Le système de bouffe semble fonctionner clairement.