nedap / aqlparser Goto Github PK

• octal should go up to 7, not 8
• our date format is more extended than the specification grammar. Probably keep as is (see text in spec!) but note on top of file
• the IDENTIFIER starts with aA subcase is to prevent conflict with at-codes. looks like it's no longer needed in ANTLR4 because of the longest match gaining preference, and the at-code having priority over the IDENTIFIER, as it probably should be?

My first round of feedback:

This is unused.

This is unused.

This is unused. I'm not sure why.

I don't think this works. I think you mean

filter(entry -> primitiveOperand.equals(entry.getValue()))

This is unused.

All protected methods in NodeExpression can be changed to private.

can be changed to

QOMObject object = QOMParserUtil.parse(lookup, parseTree);

Then this class doesn't need to extend AQLBaseVisitor anymore and private Lookup lookup;, the constructor and public QOMObject visitChildren(RuleNode node) { ... } can be removed.

tipped by @boeckers:
remove artifactory part (or clarify it's Nedap specific)
idem for the references to chiron.

Instead of listing all syntax errors, it just throws an exception. Of course I can manually do that by just using the grammar - but shouldn't it just list all of them instead?

Contains extra information only in the message - it should also be in a variable so it can be actually used. Preferably for all errors, even validation errors, so it can be shown in for example an IDE extension.