nedbhq / nedb-core Goto Github PK

I am using nedb in one of my projects. It seems to be matching my needs so far. I see one issue though, when trying to delete a record, instead of deleting the entire record, it does a partial deletion. i.e. it deletes the record and adds $$deleted: true.

{"$$deleted":true,"_id":"5ff56dece70e4d331ca9d724"}

Can the record be deleted permanently?

This is my code:

  db.remove({ name: doc.name }, {}, function (err, numRemoved) {
        // numRemoved = 1
      });

Hi,
in a vue/vuex project, the build fails:

 ERROR  Failed to compile with 1 errors
This relative module was not found:
* ./storage in ./node_modules/nedb-core/lib/persistence.js

My code is as simple as:

var Datastore = require('nedb-core')

Any suggestion?
Thank you

Incorrectly opened

The mkdirp node module has breaking changes from version 0.5 to 1.0 and the package.json for nedb-core is requesting the "latest" version of mkdirp. This breaks nedb-core which relies on mkdirp version 0.5.

There are two options to fix the issue...

1. Change the package.json dependency to mkdirp version 0.5.

2. Update the nedb-core persistence library to use the new mkdirp async methods.

I can put together a pull request but I'm curious which option would be more acceptable. Option 1 would be easy and low risk. Option 2 would be more forward looking but would require code changes that would come with risks.

Thought?