nega0 / xmlrpcpp Goto Github PK

I am currently looking into getting xmlrpcpp to support HTTPS/SSL connections. Thus, I stumbled over your interesting xmlrpcpp patchset. However, looking at the 09_xmlrpc++_xxxx patch file (https://github.com/nega0/xmlrpcpp/blob/master/patches/09_xmlrpc%2B%2B_Support%20for%20SSL%2C%20Multithreading%2C%20and%20building%20as%20RPM.diff.nega) reveals that this patch seems to be incomplete.

E.g., in there a file named XmlRpcConnectionSsl.cpp is referenced, but is not part of the patch itself (see https://github.com/nega0/xmlrpcpp/blob/master/patches/09_xmlrpc%2B%2B_Support%20for%20SSL%2C%20Multithreading%2C%20and%20building%20as%20RPM.diff.nega#L646-L647). It actually seems you have executed the diff without the "-N" option.

Do you still have after all these years your xmlrpcpp patches around and could update the patch files in your repository with the missing pieces. Or can you simply send me your whole xmlrpcpp repository folder including XmlRpcConnectionSsl.cpp and friends so that I can generate a fork of your repository and continue the work you probably haven't touched for many years?!? Thanks.

This is fixed on trunk.

Apple clang missed the self-compare of t1.tm_mday, here. Need to do one or more of:

• confirm llvm/clang catches it
• reformat so apple/clang and/or llvm/clang catches it
• make a local test case (really?)
• make a test case to send upstream