nemanjarogic / designpatternslibrary Goto Github PK

in the motivating example, the birthday rule
discount is ADDED to the current discount. In the example code it is not additive.

https://github.com/nemanjarogic/DesignPatternsLibrary/blob/main/src/AdditionalPatterns/Rules/RulesLibrary/RulesExample/Rules/BirthdayDiscountRule.cs

you should pass in the current discount when looping so the birthday rule can return currentDiscount + .10 for clarity and consistency

Hello, under what license is this project released under ? I would like to study it to learn from it. Thank you.

Hello,

I found a little bit of a nuisance in that if you want to check the output of whichever design pattern it would pass the ouput for the default console because there are too many patterns.

This can be easily fixed by adding a Console.ReadLine() after the execution has completed (see PR)

Its a small fix but might help others to avoid debugging. I originally thought there was a bug since I couldn't see why the app re-entered the loop.