ender-overlay's People
Forkers
paizaiender-overlay's Issues
Overlay mask and horizontal scrollbar
With a visible vertical scrollbar, when overlay (with a mask) is opened, the size of the mask will force browser to show horizontal scrollbar.
You can reproduce this on the demo page of your site - http://nemeseri.com/ender-overlay/demos/basics.html
Make sure you have only vertical scrollbar visible. Now, if you click on any of the images, horizontal scrollbar will appear along with the overlay.
This comes from getDocSize
function's Ender specific implementation. It uses bonzo's $.doc()
method which returns viewport size (includes scrollbars' width/height), instead of the document body size.
I suggest to ditch the Ender specific if clause - if (window.ender) {
- and use the default/fallback functionality that returns document width and height.
onBeforeClose gets triggered on open
For example, if I create an overlay with following code
var box = $('#overlay').overlay({
allowMultipleDisplay: false, // Also the default value.
onBeforeClose: function() {
console.log("Close triggered");
}
});
// Opening the 'box' will output "Close triggered" to console.
box.open();
> "Close triggered"
I did a little digging and found that this if clause
if (opt.onBeforeClose(api) === false ||
this.$overlay.css('display') !== 'block') {
return;
}
executes onBeforeClose
function regardless of overlay's current visibility state.
I think the conditions in the if clause should be the other way around (like they are for onBeforeOpen
function). What do you think?
"Disco mode" on IE10
Hello,
Just noticed a bug on IE10 : the overlay is looping in the "open" function, you won't be able to close the pop-in anymore then. This happens also on the demo page :
http://nemeseri.com/ender-overlay/demos/content-types.html
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.