Unify master-2.x contract metadata attributes with master branch about neo-devpack-dotnet HOT 7 CLOSED

Please @devhawk , Take a look to #161

from neo-devpack-dotnet.

@shargon I have https://github.com/devhawk/neo-devpack-dotnet/tree/devhawk/FeaturesAttribute ready to go, but I will wait on submitting that for PR until #154 goes thru.

from neo-devpack-dotnet.

@shargon I'd appreciate your thoughts on this issue. I started to do this, but I ran into a few incompatibilities:

• FeaturesAttribute is applied to a class while all of the contract attributes I added are applied to the assembly. As far as I understand, NEON doesn't support multiple contracts in a single managed dll - at least for 2.x. If that's the same for NEON 3.x, should FeaturesAttribute be applied to the assembly not the class? Or should all the 2.x attributes apply to class instead of assembly.
  • My preference is to attach these attributes to assembly not class. What does it mean to attach these attributes to classes other than the main contract class?
• FeaturesAttribute uses the ContractFeatures enum, but the 2.x branch already has the ContractPropertyState enum. I don't think we should define to enums with the same values and we can't change the existing ContractPropertyState enum without breaking code. I'm thinking the 2.x branch version of FeaturesAttribute should just take a ContractPropertyState value in its constructor, even though it's not 100% compatible with 3.x branch.

from neo-devpack-dotnet.

should FeaturesAttribute be applied to the assembly not the class?

Yes, I think so. But is not more comfortable for the developer in a class?

even though it's not 100% compatible with 3.x branch.

Don't worry about that, it's ok for me

from neo-devpack-dotnet.

Seems weird to me with smart contracts with one file.

using Neo.SmartContract.Framework;
using Neo.SmartContract.Framework.Services.Neo;

[assembly: Features(ContractFeatures.HasStorage)]

namespace Neo.Compiler.MSIL.TestClasses
{
    class Contract_Storage : SmartContract.Framework.SmartContract
    {

from neo-devpack-dotnet.

Not all contracts are a single file: https://github.com/Moonlight-io/moonlight-ico-template
What would it mean for you to apply the features attribute to the NEP5 class but not the main entrypoint class?

from neo-devpack-dotnet.

@shargon I like #161. Note also that I have a task open to add these attributes for the neo contract templates. So developers starting from scratch will know how to add them.

from neo-devpack-dotnet.