Giter VIP home page Giter VIP logo

Comments (4)

nervetattoo avatar nervetattoo commented on June 27, 2024

In which ways does it fail? Does phantomjs come with touch* handlers?
I guess that kind of fix solves it mostly, but I would prefer to not use device detection as thats a list that needs to be maintained in the future.

from backbone.touch.

jamuhl avatar jamuhl commented on June 27, 2024

Yes. Phantomjs implements some of the touch events. Another option would be to explicit look if it is phantomjs, like here:

https://github.com/cheeaun/tappable/pull/11/files

But actually i'm not sure if it's a good idea - feels wrong.

from backbone.touch.

nervetattoo avatar nervetattoo commented on June 27, 2024

Since it seems like this will be corrected in phantomjs at some point (given the attitude of the maintainer) I think doing specific sniffing of phantomjs for now is my preferred solution. Feel free to do a pull request, if not I will add it later.

from backbone.touch.

jamuhl avatar jamuhl commented on June 27, 2024

added a PR.

from backbone.touch.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.