nervetattoo / backbone.touch Goto Github PK

I just popped touchclick into my project and it seems to work just as well as backbone-touch, without extending backbone, and the bonus .touchactive class added for styling touch events (I can create a 'touchactive' state for increased perceived performance).

Am I missing any benefits that backbone.touch gives over this?

the project's bower.json which is at 0.4.1 in the repo has the correct backbone dependency version, but 0.4.0 which is available to bower apparently does not. Can you update? Thank you.

$ bower install -save backbone.touch#0.4.1
bower backbone.touch#0.4.1  not-cached git://github.com/nervetattoo/backbone.touch.git#0.4.1
bower backbone.touch#0.4.1     resolve git://github.com/nervetattoo/backbone.touch.git#0.4.1
bower backbone.touch#0.4.1     ENORESTARGET No tag found that was able to satisfy 0.4.1

Additional error details:
Available versions: 0.4.0, 0.3.0, 0.2.0

Hi,

I know that we should not have a global var "global" or a DOM node with a "global" ID in browser context, sometimes, old projects with bad practices had and we want add to them good plugins such yours ;-)

I can add a pull request to do that, but maybe you prefer choose how you want to fix it.

Thank you.

Backbone.touch should rather massage the events data before calling to delegateEvents, this allows to mix different backbone plugins that override delegateEvents

I am using backbone with zepto instead of jquery, backbone.touch have a compatibility issue with zepto.
zepto's touch event object does not have 'originalEvent' property, my workaround was to change line 93 and 94 to:

var oe = e.originalEvent || e; 
if (!('changedTouches' in oe)) return;
var touch = oe.changedTouches[0];

This plugin works well when taps are quick.
But when you tap and hold, then release after 1 second, it reloads the page.
I have already used preventDefault, but doesn't seem to help.

Is this a known issue?

I run into an issue testing our site with casperjs (phantomjs). When i added backbone.touch the tests failed.

I changed line 32 to:

isTouch : 'ontouchstart' in this.document && /iPhone|iPod|iPad|Android|BlackBerry|PlayBook/.test(navigator.userAgent),

like this only mobile devices and tablets get the click events changed and all tests green again.

Devices that support touch events and click events will not delegate click events, thereby not allowing certain elements to be clicked, only touched.

I've tested this on Chrome with my Acer Aspire S7 (Windows 8.1), Chrome on Mac OSX (10.9.4) as well as Safari on iPhone 5 (7.1). Mac and iPhone work as expected, however, the Acer is a touchscreen enabled laptop and when using this plugin, any click event that has been registered on an element prevents the handler from being called when clicking as normal, I can only touch the screen for the expected behavior.

similar problem to #13

I have base Dialog view something like that:

var Dialog = Backbone.View.extend({
      events: {
           'click .close' : 'closeDialog'
      },
      closeDialog: function() { /* code goes here */ }
});
// then i extend it
var Dialog1 = Dialog.extend({
     events: _.extend(Dialog.prototype.events, {
           'click .something': 'onDialog1Click'
     }),
     onDialog1Click: function() {}
});

var Dialog2 = Dialog.extend({
     events: _.extend(Dialog.prototype.events, {
           'click .something_else': 'onDialog2Click'
     }),
     onDialog2Click: function() {}
})


var dialog1 = new Dialog1();
var dialog2 = new Dialog2();

//Uncaught Error: Method "onDialog2Click" or "onDialog1Click" does not exist 

I solve this by repeating again all base class events again in child classes. Is there other way to do it?

A regular click event is still fired after the 300 ms delay has passed. See related article here https://developers.google.com/mobile/articles/fast_buttons#ghost