nestdotland / deno-import-intellisense Goto Github PK

The current deno-import-intellisense.json is problematic:

{
  "version": 1,
  "registries": [
    {
      "schema": "/:module([a-zA-Z0-9_]*)@:version/:path*",
      "variables": [
        {
          "key": "module",
          "url": "https://intellisense.nest.land/api/x"
        },
        {
          "key": "version",
          "url": "https://intellisense.nest.land/api/x/${module}"
        },
        {
          "key": "path",
          "url": "https://intellisense.nest.land/api/x/${module}/${version}"
        }
      ]
    }
  ]
}

Which causes code completions in the editor to not work properly. There are a few issues:

• The custom regex for the module ([a-zA-Z0-9_]*) does not require any length. This means that https://x.next.land/@ becomes a valid match and effectively makes the module variable optional. Consider using [a-zA-Z0-9_]+ so the module is at least 1 char long.
• The custom regex for the module ([a-zA-Z0-9_]*) does match real world results returned from the API endpoint (https://intellisense.nest.land/api/x) which means that when someone tries to select a module like node-crawler in the editor, the completion is not calculated properly, because node-crawler or jpeg.ts is allegedly an invalid package name. Consider validating module names against a regex and updating the regex to include valid values. (e.g. [a-zA-z0-9_.\-]+)
• The version variable matches anything between @ and /. This isn't specifically problematic, but it does mean if there are issues elsewhere, the pattern matching can get a bit mixed up. If there is any validation on a version string, consider reflecting it in the pattern.