nestjs / nestjs.com Goto Github PK
View Code? Open in Web Editor NEWThe official website https://nestjs.com ๐
Home Page: https://nestjs.com
License: MIT License
The official website https://nestjs.com ๐
Home Page: https://nestjs.com
License: MIT License
Even though your .htaccess
seems to be configured correctly (= it should redirect http to https), I can still access it through http://nestjs.com (does not redirect to HTTPS)
The Codesandbox.io example on the start page is kinda questionable. The app.controller.ts does inject the AppService
, but does not call anything from it, making it unneeded.
@Controller()
export class AppController {
constructor(private readonly appService: AppService) {}
@Get()
render(@Res() res: Response) {
res.sendFile(`index.html`, { root: __dirname + '/..' });
}
}
I understand that you probably want to render the index.html so it looks more appealing. But maybe we should consider an example which actually uses a service, so the user better understands the benefits of NestJS? Maybe the app service returns a static array of benefits of NestJS which then get rendered by the index.html?
Good day Kamil, I tried subscribing to the NestJS newsletter and noticed that the success icon activates even when the POST request fails. To improve the user experience and code quality, I would love to work on the following changes:
Add an Error Icon: Introduce an error icon to inform users if their subscription request fails, providing clear feedback on the submission status.
Use Fetch API with Async/Await: Update the codebase to utilize the Fetch API and async/await for handling the form submission, replacing the existing method for better readability and modern JavaScript practices.
Just noticed, that content from this page is missing.
https://docs.nestjs.com/techniques/cookies
Sponsors/Partners section is not fully visible
All thee sponsors should be visible
Adding a margin on the container
CSS class may solve the problem.
MacOS Catalin 10.15.3
Chrome Version 85.0.4183.121 (Official Build) (64-bit)
The landing page of nestjs.com website has a live preview running in StackBlitz.
The src/app.controller.spec.ts
unit test is failing:
https://stackblitz.com/edit/nestjs-typescript-starter-pcysqn?file=src%2Fapp.controller.spec.ts
Currently:
describe('getHello', () => {
it('should return "Hello World!"', () => {
const appController = app.get<AppController>(AppController);
// NOTE: Attempting to access the getHello() service method directly (does not exist on appController).
expect(appController.getHello()).toBe('Hello World!');
});
});
Suggested change:
describe('getHello', () => {
it('should return "Hello World!"', () => {
const appController = app.get<AppController>(AppController);
// NOTE: Change the expect to check for valid object response using render() method
expect(appController.render()).toEqual({ message: 'Hello World!' });
});
});
When visiting https://www.nestjs.com/ there is an SSL error.
You should either buy a valid cert for the www domain or fix your config to redirect to non www.
Didn't know where else to submit the issue
You're welcome :-)
Edit: can be closed
Moved to: nestjs/courses.nestjs.com#57
Some of the resources in your homepage (mostly fonts) are requested in an infinite loop.
In the docs, it says that a redis store on the CacheModule must be set up like this:
@Module({
imports: [
CacheModule.register<RedisClientOptions>({
store: redisStore,
// Store-specific configuration:
socket: {
host: 'localhost',
port: 6379,
},
isGlobal: true
}),
],
controllers: [AppController],
})
but when the service is manually injected:
constructor(@Inject(CACHE_MANAGER) private cacheManager: Cache) {}
it gives an instance of the In Memory Cache
I think this is a documentation issue because when i set up the CacheModule in this way without the socket object:
@Module({
imports: [
CacheModule.register({
store: redisStore,
host: 'localhost',
port: 6379,
isGlobal: true
}),
],
controllers: [AppController],
})
it works as expected.
This issue was reproduced with this environment:
This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.
Warning
These dependencies are deprecated:
Datasource | Name | Replacement PR? |
---|---|---|
npm | parcel-bundler |
These updates have all been created already. Click a checkbox below to force a retry/rebase of any.
package.json
copyfiles 2.4.1
parcel-plugin-browserconfig 1.0.5
parcel-bundler 1.12.5
.nvmrc
node 18.19.0
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.