Comments (2)
We do not support a global timeout because it wouldn’t make sense in my eyes. Instead the timeout option can be given to individual health indicators as option.
The option parameter is usually the last parameter of a function.
For example the DNSHealthIndicator:
dns.pingCheck('google', 'https://google.com', { timeout: 800 })
The promiseTimeout
is used for internal stuff, to extend promises with this timeout option, if it is not supported (e.g. DatabaseHealthIndicator uses it when running a SQL check).
I could extend the DNSHealthIndicator example so the users understands that the last parameter contains these kind of optional options. Would that be sufficient?
from terminus.
For the documentation problem, yes this would suffice.
But, about design:
Timeout should be the responsibility of the library, not the responsibility of the author of the healthcheck.
Any healtcheck should be timeout protected, and nest-terminus can bring that as the default. This means that developing a new HealthIndicator would only means implementing the actual call (db, smtp...).
from terminus.
Related Issues (20)
- Bug: Healthcheck Failures Do Not Work as Expected HOT 3
- Ability to run health checks in parallel HOT 3
- After PR #1970 (update from 9.0.0 to 9.1.0) there is an error with TERMINUS_ERROR_LOGGER HOT 2
- NestJS Terminus has an undeclared dependency on Axios HOT 1
- Typescript issues with axios >= 0.27 HOT 1
- Allow custom logger implementation for health check service HOT 10
- Named swagger schema HOT 4
- Optional peerDependencies are not declared in manifest
- Throwing HealthCheckError in synchronous HealthIndicatorFunction does not work properly HOT 5
- Nest could not find MikroORM element (this provider does not exist in the current context) HOT 1
- MicroserviceHealthIndicator pingCheck() failed when error is undefined HOT 2
- MikroOrmHealthIndicator does not work with the `defineConfig` helper HOT 4
- this library does not support Nestjs 10.0.0 HOT 5
- On shutdown, health request before signal interrupted with ECONNREFUSED
- Cached responses 200 -> 304 HOT 6
- HttpHealthIndicator.responseCheck not handles network errors HOT 1
- Adding a gracefulShutdownTimeout option for 0-downtime deployment on Kubernetes HOT 6
- nest10 health check return Service Unavailable Exception HOT 1
- Mikro ORM check returns healthy although not connected HOT 7
- Schema does not match health-indicator-result interface HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminus.