Comments (6)
Option to disable logging.
I would say that option to override logger might be useful as well.
from terminus.
I am using a custom logger as I got to log all messaages in JSOn format. I can confirm that this works :).
from terminus.
Terminus already supports to override the logger, so this should be doable.
As you can see I just took the default NestJS logger
But I can make this configurable in the module option like so, if that is suitable for you:
{
logger: (message) => myawesomelogger.log(message),
endpoints: [
{
url: '/health',
healthIndicators: [
async () => catHealthIndicator.isHealthy('cat'),
],
},
],
}
In case the user does not define any logger, I guess it should take the nestjs logger
from terminus.
@BrunnerLivio Thanks for the clarification. I'm trying to avoid this logging in my health check unit tests. But even when defining a test module with a TestingLogger as follows, Terminus is still logging to console.
const module:TestingModule = await Test.createTestingModule({ imports: [MyModule], }) .setLogger(new TestingLogger()) .compile();
I'm not sure how is it depending on NestJS DI if it instantiates its own logger:
Shouldn't it be injected?
from terminus.
@BrunnerLivio I'm still having the above issue.
from terminus.
@JAZZ-FROM-HELL Please create a new issue for it
from terminus.
Related Issues (20)
- After PR #1970 (update from 9.0.0 to 9.1.0) there is an error with TERMINUS_ERROR_LOGGER HOT 2
- NestJS Terminus has an undeclared dependency on Axios HOT 1
- Typescript issues with axios >= 0.27 HOT 1
- Allow custom logger implementation for health check service HOT 10
- Named swagger schema HOT 4
- Optional peerDependencies are not declared in manifest
- Throwing HealthCheckError in synchronous HealthIndicatorFunction does not work properly HOT 5
- Nest could not find MikroORM element (this provider does not exist in the current context) HOT 1
- MicroserviceHealthIndicator pingCheck() failed when error is undefined HOT 2
- MikroOrmHealthIndicator does not work with the `defineConfig` helper HOT 4
- this library does not support Nestjs 10.0.0 HOT 5
- On shutdown, health request before signal interrupted with ECONNREFUSED
- Cached responses 200 -> 304 HOT 6
- HttpHealthIndicator.responseCheck not handles network errors HOT 1
- Adding a gracefulShutdownTimeout option for 0-downtime deployment on Kubernetes HOT 6
- nest10 health check return Service Unavailable Exception HOT 1
- Mikro ORM check returns healthy although not connected HOT 7
- Schema does not match health-indicator-result interface HOT 7
- DiskHealthIndicator always reports: "Used disk storage exceeded the set threshold" HOT 1
- Logger Enhancements
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminus.