Giter VIP home page Giter VIP logo

quickshop's Introduction

A plug-in for the open-source Minecraft server framework, Bukkit. QuickShop was designed to combine concepts from a number of expired "shop" plugins which had become inactive. The goal of the project was to provide something user friendly to allow players to trade items through the Minecraft server via an economy. It had to be simple, given the target audience and quick to use.

The plugin was conceptually done through inspiration from other plugins which had unique ways of displaying sales, interfacing with shops and monitoring stock. The implementation of this plugin managed to successfully combine these ideals and became a hit with 117,000 downloads at time of writing. The project has now been discontinued, and only works on older versions of Bukkit due to changes in the framework.

Download available at http://dev.bukkit.org/bukkit-plugins/quickshop/

The Predecessors

Showcase was abandoned. Chestshop needed a display, with signs whose order you could never remember. SCS has too many commands. I'm yet to find someone who uses essentials shops.

Don't get me wrong though, they're all awesome plugins each in a few ways.

QuickShop

So, I set out to write this. QuickShop. QuickShop is a shop plugin, that allows players to sell items from a chest with no commands. It allows players to purchase any number of items easily. In fact, this plugin doesn't even have any commands that a player would ever need!

Features

Easy to use Togglable Display Item on top of chest NBT Data, Enchants, Tool Damage, Potion and Mob Egg support Unlimited chest support Blacklist support & bypass permissions Shops that buy items and sell items at the same time are possible (Using double chests) Herochat support Checks a player can open a chest before letting them create a shop!

No longer accepting feature requests For those people that hate reading, here's an awesome video from UltiByte:

https://www.youtube.com/watch?feature=player_embedded&v=6NpkVd2mA7Y

Installation Guide:

http://www.youtube.com/watch?v=eJsv7fqaXNk

How to Create a Shop

Place a chest on the ground Hit the chest with the item you want to trade Type in price for the item (As prompted) in chat Fill the chest with the items you wish to sell

Advanced

Face the chest Type either /qs sell or /qs buy to make the shop buy/sell instead (Optional: use /shop instead of /qs) Stock the shop accordingly, if necessary.

How to Buy/Sell to a Shop

Find a shop Hit / Left click the shop Enter the amount you wish to trade in chat Menu Example: Menu

See it in action: http://maxgamer.org or play.maxgamer.org:25571 and /warp market!

Commands

/qs unlimited - Makes the shop you're looking at become unlimited.
/qs setowner  - Changes shop owner to .
/qs buy - Changes your shop you're looking at to one that buys items
/qs sell - Changes your shop you're looking at to one that sells items
/qs price  - Change the price of your shop that you're looking at
/qs clean - Removes any existing shop that has 0 stock.
/qs find  - Use to find the nearest shop that begins with  - E.g. '/qs find dia' will find the nearest diamond shop.
/shop - Alias (Optional) of /qs

Permissions

Player Nodes
quickshop.use - Required to use ANY quickshop
quickshop.create.sell - Required to make a QuickShop (At all)
quickshop.create.buy - Required to use /qs buy (Change the shop type from Sell -> Buy)
quickshop.create.double - Required to make doublechest shops.
quickshop.create.changeprice - Required to use /qs price (Ability to change the price of a shop without destroying it. This may allow for some scammers to quickly change the price while someone is buying.
quickshop.bypass.ItemID - Required to sell blacklisted items (E.g. bedrock)
quickshop.find - Required to use /qs find 
Admin Nodes
quickshop.unlimited - Required to use /quickshop unlimited
quickshop.setowner - Allows use of /qs setowner
quickshop.other.destroy - Allow breaking other peoples QuickShops if they're locked by this plugin
quickshop.other.open - Allow opening (And stealing/Stocking) other players QuickShops
quickshop.other.price - Allow changing price of other people's shops
quickshop.refill - Ability to refill chests using a command (=Unlimited items)
quickshop.empty - Ability to empty chests of all items
quickshop.clean - Permission to purge any shops that have 0 stock.

quickshop's People

Contributors

netherfoam avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

quickshop's Issues

Not able to create shops

QuickShop 3.7.1

Latest

Hi there,

I'm having an issue with your great plugin I try to install.
There is no possibility to create one. I put a locker on the ground, then sneak (I enabled it in the config) or even when I dont sneak I right click or left click with wool for example, it breaks the locker or places the wool on it.
I did some troubleshooting be removing ALL plugins, trying with different economy plugins, with and without Vault, nothing works, same issue.

The plugin dho is well started, I can type in games commands without any problem, like /qs sell but it keeps telling me of course that he can't find any shop.

He is the no error log from the start of my server with nearly no plugins enabled :

17:41:25 [INFO] Starting minecraft server version 1.4.7
17:41:25 [INFO] Loading properties
17:41:25 [INFO] Default game type: SURVIVAL
17:41:25 [INFO] Generating keypair
17:41:25 [INFO] Starting Minecraft server on 77.111.253.45:25565
17:41:26 [INFO] This server is running CraftBukkit version git-Bukkit-1.4.7-R1.0-b2624jnks (MC: 1.4.7) (Implementing API version 1.4.7-R1.0)
17:41:26 [INFO] [QuickShop] Loading QuickShop v3.7.1
17:41:26 [INFO] [BOSEconomy] Loading BOSEconomy v0.7.3.1
17:41:26 [INFO] [Vault] Loading Vault v1.2.23-b301
17:41:26 [INFO] [PlayerMarkers] Loading PlayerMarkers v0.2.0
17:41:26 [INFO] [Vault] Enabling Vault v1.2.23-b301
17:41:26 [INFO] [Vault][Economy] BOSEconomy7 found: Waiting
17:41:26 [INFO] [Vault][Permission] SuperPermissions loaded as backup permission system.
17:41:26 [INFO] [Vault] Enabled Version 1.2.23-b301
17:41:26 [INFO] [Vault][Economy] BOSEconomy hooked.
17:41:26 [INFO] Preparing level "world"
17:41:26 [INFO] Preparing start region for level 0 (Seed: 1464975645)
17:41:26 [INFO] Preparing start region for level 1 (Seed: -7207106060178318338)
17:41:27 [INFO] Preparing start region for level 2 (Seed: -7207106060178318338)
17:41:27 [INFO] [QuickShop] Enabling QuickShop v3.7.1
17:41:27 [INFO] [QuickShop] Hooking Vault
17:41:27 [INFO] [QuickShop] Starting item scheduler
17:41:27 [INFO] [QuickShop] Loading shops from database...
17:41:27 [INFO] Item column type: null, converting to BLOB.
17:41:27 [INFO] Converting shops to 3.4 format...
17:41:27 [INFO] Loading shops...
17:41:27 [INFO] Loading complete. Backing up and deleting shops table...
17:41:27 [INFO] Conversion complete.
17:41:27 [INFO] Conversion success. Continuing...
17:41:27 [INFO] [QuickShop] Loaded 0 shops.
17:41:27 [INFO] Cleaning purchase messages from database that are over a week old...
17:41:27 [INFO] [QuickShop] Registering Listeners
17:41:27 [INFO] [QuickShop] Metrics started.
17:41:27 [INFO] [QuickShop] QuickShop loaded!
17:41:27 [INFO] [BOSEconomy] Enabling BOSEconomy v0.7.3.1
17:41:27 [INFO] BOSEconomy: Automatically created the default bracket 'default'.
17:41:27 [INFO] BOSEconomy v0.7.3.1 enabled.
17:41:27 [INFO] [PlayerMarkers] Enabling PlayerMarkers v0.2.0
17:41:27 [INFO] PlayerMarkers version 0.2.0 enabled
17:41:27 [INFO] Server permissions file permissions.yml is empty, ignoring it
17:41:27 [INFO] Done (1.272s)! For help, type "help" or "?"

It just doesnt work and I dont know why.

Please help me out !

If any relevant:

  • What version of Vault are you running? LATEST
  • What economy and economy version are you running? BOSE or anyother, same problem

Add option to buy items you have zero of

If I want to create a buying shop I need at least one item to hit the chest with so if I have zero I can't set up the shop. I would like to be able to pick the item from a list or something.

https://github.com/snowgears/Shop implemented it by letting you hit the chest with your hand and then locking you in creative mode where you can pick from the list of items the one you're buying.

Missing Shop interface?

Hi,

I am using you plugin and currently writing a plugin based on it, but I cannot find the Shop interface in your code, is it dynamically generated when you build your JAR?

Can you please include it?

Also, are you ok with push request?
I would like to do few (minor) changes, to expand usage for external plugins.

[Feature] Permission Based notifications

Feature Request: permission based notification, meaning that multiple staff users who are responsible for refilling the stock get the purchase/sell transaction notifications.

Missing Shop class

Hello!

I'm using ur plugin and I can see here is not Shop class in package:

org.maxgamer.QuickShop.Shop

Can you add this class?

Add option to limit how much a shop can buy

I'd like to be able to set up a buying shop that will buy X amount of the specified item and no more so I don't end up with much more than I need and zero money. Right now the only workaround I've found is filling the chest with other stuff and leaving only one stack free so it doesn't buy more than 64 of the item.

Search shops buying an item

Could there be an option to search the nearest shop that buys an item? Just like you can search shops selling an item.

Bug: QS is checking the Account-Balance of Unlimited-Shop-Owners

If a player trys to sell to a unlimited Shop and the Total-Price is higher than the Account-Balance of the owner, the transaction is canceled with there error "Owner doesn't have enough money".
I dont see any sense in checking the Account-Balance, since pay-unlimited-shop-owners is set to false in the cfg and so I think its a Bug.

Thx for this great plugin anyway! ;)

Getting encoding error when using unicode characters and MySQL.

QS throws an error every time it tries to load itemConfig during start which contains UTF-8 encoded character:

org.bukkit.configuration.InvalidConfigurationException: unacceptable character '�' (0xFFFD) special characters are not allowed
in "", position 130

Problem: itemConfig type is BLOB and it does not support CHARACTER SET utf8.
Fixed: By running this in MySQL CLI client

ALTER TABLE shops MODIFY itemConfig TEXT CHARACTER SET utf8;

QS Version: 4.4
CraftBukkit version git-Bukkit-1.5.2-R0.1-b2771jnks

Enhancement: Buy/Sell ALL

Situation
I want to sell all Cobblestone in my inventory to a shop but I am to lazy to count the stacks.
So I am just typing 1000 - Hoping that QS interprets this as "All". But unfortunately QS tells me that I dont have enough items, rather than just selling All. Samething when Buying from the shop.

My Suggestion
Allow the Keyword "All" (maybe customizable for localization) for the quantity! ;)

[Unverified] Tax on unlimited shops [Buying]

As you suggested i made some "admin shop", now i have another problem. No idea if its a bug or its supposed to be like that but when i set a shop to unlimited tax are not added to tax account but they are subtract to price (tryied while selling with another account ofc).

example to explain better just to be sure, my english is bad sorry ;)

BALANCES: admin: 100 player: 100 tax: 0

player sell item to admin shop unlimited for 10$

NEW BALANCES: admin: 100 <- RIGHT, no change if unlimited shop | player: 109.5 <- RIGHT, 10$-tax | tax: 0 <- WRONG, still 0, must be 0.5 |

Is that a bug? How i can fix that?

Enhancement: Autoset owner to "AdminShop" for unlimited shops

It would be great, if there were an option in the cfg to autoset the owner of a unlimited shop to "AdminShop" or something similiar, so people understand, that this isn't a Player-to-Player-Trade!
For the Space/Stock there could be an "∞"(Symbol for endless).

display-items can't

The config.yml file inside the display-items option is true, using the 1.9.4 version of the client can see, but can not see the use of 1.9.4-forge1.9.4-12.17.0.1976. What should I do?

Enhancement: Logging

Logging of every Quickshop-Action, like it in Essentials Eco for example, would be awesome!
In case a player is using some exploit or just to keep track with the eco.

[Feature] Item frames display

Place item frames on the available 3 sides of a chest when creating one.

Stop players breaking the item frames, and remove the item frames when removing the QuickShop.

Right-Click

Okay, so I've been using QuickShop for a while now, and it is by far the best shop plugin there is. However, it's ease of use has made one issue crop up a lot on my server, and it has everything to do with shop interactions being defined by a left-click.

Whenever someone tries to hit their chests, for example, to destroy them, they're spammed with shop creation messages, which is obviously not what they intended to do. Now, I'm not here to just tell you to change it to a right-click instead, so that this doesn't happen. I actually changed it in the code to a right-click and compiled it myself and saw firsthand exactly why a right-click also has it's own issues. However, I did find a way for a right-click to work, for the chest not to open when trying to create/interact with the shop, and still allow normal chest operations. It does add one extra step to the shop creation process, but it still requires no commands at least.

For this to work, first, a blank sign must be placed on a chest. From there on, all interactions are done through that sign. Right-clicking with an item to create a shop is done by right-clicking the sign with an item in hand. Right-clicking to interact with the shop is done through the sign as well.

I know left-clicking can work without the issue I stated above by enabling sneak, but because that also includes not just making a shop but interacting with one as well, a lot of players don't even understand how to use the shops on my server and completely avoid them. I turned off sneaking to fix this and now everyone complains about not being able to destroy their chests without being spammed by shop creation messages. Perhaps another way to fix the issue with left-clicking would be to require sneak just for creating the shop.

I hope you'll consider this fix. I'd code it myself, but I stumbled through getting the right-click to work, and was stumped for a while because of the specific libraries the plugin calls for. I got it to compile and run, but was still met with some NMS related errors, to name a few. Thank you for all your work. When I have the funds, I intend to donate a few dollars. Keep up the excellent work!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.