Giter VIP home page Giter VIP logo

dhl-module-carrier-paket's Introduction

DHL Paket Shipping Carrier Extension

The DHL Paket extension for Magento® 2 integrates the DHL Business Customer Shipping API into the order processing workflow.

Description

This extension enables merchants to request and cancel shipping labels for incoming orders via the DHL Business Customer Shipping API (DHL Geschäftskundenversand-API).

Requirements

  • PHP >= 7.2
  • PHP SOAP extension

Compatibility

  • Magento >= 2.3.0+

Installation Instructions

Install sources:

composer require dhl/module-carrier-paket

Enable module:

./bin/magento module:enable Dhl_Paket
./bin/magento setup:upgrade

Flush cache and compile:

./bin/magento cache:flush
./bin/magento setup:di:compile

Uninstallation

To unregister the carrier module from the application, run the following command:

./bin/magento module:uninstall --remove-data Dhl_Paket
composer update

This will automatically remove source files, clean up the database, update package dependencies.

Support

In case of questions or problems, please have a look at the Support Portal (FAQ) first.

If the issue cannot be resolved, you can contact the support team via the Support Portal or by sending an email to [email protected].

License

OSL - Open Software Licence 3.0

Copyright

(c) 2023 DHL Paket GmbH

dhl-module-carrier-paket's People

Contributors

andreasmueller75 avatar magicsunday avatar mam08ixo avatar ngolatka avatar powli avatar sebastian80 avatar

Stargazers

avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

phoenix-bjoern a-t-s ndlinh-celtic

dhl-module-carrier-paket's Issues

PHP Fatal Error at updating to 2.5.0

at bin/magento setup:upgrade

i got the fowolling error:

PHP Fatal error: Class Dhl\Paket\Model\Webservice\ShipmentService contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Dhl\Sdk\Paket\Bcs\Api\ShipmentServiceInterface::validateShipments) in /pathToWeb/vendor/dhl/module-carrier-paket/Model/Webservice/ShipmentService.php on line 18

Magento: 2.4.3
PHP: 7.4.28

Compatibility with Magento 2.4 / PHP 7.4

Hi,

there is already an info when the modules support PHP 7.4.

  Problem 1
    - dhl/module-carrier-paket 1.1.0 requires php ~7.0.6 || ~7.1.3 || ~7.2.0 || ~7.3.0 -> your PHP version (7.4.7) does not satisfy that requirement.
    - dhl/module-carrier-paket 1.1.0 requires php ~7.0.6 || ~7.1.3 || ~7.2.0 || ~7.3.0 -> your PHP version (7.4.7) does not satisfy that requirement.
    - Installation request for dhl/module-carrier-paket 1.1.0 -> satisfiable by dhl/module-carrier-paket[1.1.0].

LocationFinderServiceFactory uses ServiceFactory instead of ServiceFactoryInterface

Hi,

I think this should be the ServiceFactoryInterface instead of the ServiceFactory? (+di.xml config)
https://github.com/netresearch/dhl-module-carrier-paket/blob/master/Model/Webservice/LocationFinderServiceFactory.php#L28

In every other module the implementation is with di.xml + ServiceFactoryInterface.
Problem for me is now, I want to override the ServiceFactory, but I cannot do this like the other implementations.

Electronic Export Notification

The checkbox "Electronic Export Notification"
is described as "If enabled, DHL will automatically send a customs declaration electronically to the customs offices for dutiable shipments."

while in fact is sets a flag, that the user himself has to do that electronic export declaration and accompany the shipment with the respective document "Ausfuhrbegleitdokument".
While the user would assume that DHL would do that declaration given the entered content and the customer's customs reference and
the printed documents (that include a CN23) would be complete.
If the EAD is not included with the shipment, the shipment is returned by DHL.

Proposal:

  • The checkbox should not be set by default
  • The descriptive text of this checkbox should be updated to not be misleading
  • if the checkbox is set, uppon creating postage for an export, the user should be reminded about his duty to do the electronic declaration and to attach the "Export Accompanying Document (EAD)"/"Ausfuhrbegleitdokument" (possibly with a [x] do not show again)

Street containing slash parsed wrongly

Description

A street containnig a slash is parsed wrongly by the DHL module, resulting in a wrong (but valid) address send to DHL, resulting in a failed delivery. There are two slightly different cases.

Preconditons

  • Magento 2.4.1
  • DHL dhl/shipping-m2 1.5.1

Case 1

Steps to reproduce

  • Create an order with address 'Kollmitz 1 1/3, 93466 Chamerau'

Expected Behavior

  • The address is split in:
  • Street: 'Kollmitz'
  • Housenumber: '1 1/3'
  • Addition: ''
  • OR:
  • Street: 'Kollmitz'
  • Housenumber: '1'
  • Addition: '1/3'
  • The shipping label contains the correct street, housenumber and addition 'Kollmitz 1 1/3'

Actual Behavior

  • The address is split in:
  • Street: 'Kollmitz'
  • Housenumber: '11'
  • Addition: '3'
  • The shipping label contains 'Kollmitz 11'
  • --> false number and even the addition is not added (which would be wrong anyway)
    Kollmitz

Case 2

Steps to reproduce

  • Create an order with address 'Hauptstraße 4/1, 73557 Mutlangen'

Expected Behavior

  • The address is split in:
  • Street: 'Hauptstraße'
  • Housenumber: '4/1'
  • Addition: ''
  • OR:
  • Street: 'Kollmitz'
  • Housenumber: '4'
  • Addition: '1'
  • The shipping label contains the correct street, housenumber and addition 'Hauptstraße 4/1'

Actual Behavior

  • The address is split in:
  • Street: 'Hauptstraße'
  • Housenumber: '4'
  • Addition: '1'
  • The shipping label contains 'Hauptstraße 4'
  • --> This is not an issue of wrong parsing, but of not adding the addition to the label
  • Hauptstrasse

Disclaimer

We already had a discussion in another issue about the complexity of address parsing, so I know this can be a highly difficult issue. Just as a remark, these are two examples of existing german addresses, but admittetly rather rare. In Austria it is way more common that the housenumber contains a slash.

`printOnlyIfCodeable` flag removed

In 2.9.0 the changelog states:

The printOnlyIfCodeable flag can no longer be set for individual packages. The module configuration setting ("Shipment Defaults") always applies.

Was there a technical or business reason for removing this flag? It was often quite handy for us, which now requires manual creation of shipping labels in those scenarios.

'Sperrgut'-remark not added to label if created via mass-action in sandbox mode

Hello Netresearch-team,
during the update to the latest version of this module we ran into an issue regarding the bulky-goods service:

Preconditions:

  • Version 2.4.3 of Magento (Commerce)
  • version 2.1.0 of dhl/shipping-m2 installed (resulting in version 2.2.0 of netresearch/dhl-module-carrier-paket)
  • DHL Parcel Germany configurations: Use Bulky Goods Service - yes

Steps to reproduce:

  • create label via mass-action from order-grid
  • print label (e.g. via mass-action)
  • check the content of the label

Expected result:

  • resulting label contains a 'Sperrgut'-remark

Actual result:

  • resulting label contains no 'Sperrgut'-remark

Thank you in advance and best regards

Argument #1 ($storeId) must be of type int, string given

We are using the mollie magento 2 module (https://github.com/mollie/magento2/) and when clicking "mark as paid" button we get the following error:

TypeError: Dhl\Paket\Model\AdditionalFee\AdditionalFeeProvider::getAmounts(): Argument netresearch/dhl-shipping-m2#1 ($storeId) must be of type int, string given, called in vendor/dhl/module-carrier-paket/Model/AdditionalFee/AdditionalFeeConfiguration.php on line 46 and defined in vendor/dhl/module-carrier-paket/Model/AdditionalFee/AdditionalFeeProvider.php:27
Stack trace:
#0 vendor/dhl/module-carrier-paket/Model/AdditionalFee/AdditionalFeeConfiguration.php(46): Dhl\Paket\Model\AdditionalFee\AdditionalFeeProvider->getAmounts('1')
netresearch/dhl-shipping-m2#1 vendor/dhl/module-carrier-paket/Model/AdditionalFee/AdditionalFeeConfiguration.php(83): Dhl\Paket\Model\AdditionalFee\AdditionalFeeConfiguration->calculateAdjustmentAmount(Object(Magento\Quote\Model\Quote\Interceptor))
netresearch/dhl-shipping-m2#2 vendor/netresearch/module-shipping-core/Model/AdditionalFee/AdditionalFeeManagement.php(46): Dhl\Paket\Model\AdditionalFee\AdditionalFeeConfiguration->isActive(Object(Magento\Quote\Model\Quote\Interceptor))
netresearch/dhl-shipping-m2#3 vendor/netresearch/module-shipping-core/Model/AdditionalFee/Total.php(109): Netresearch\ShippingCore\Model\AdditionalFee\AdditionalFeeManagement->isActive(Object(Magento\Quote\Model\Quote\Interceptor))
netresearch/dhl-shipping-m2#4 vendor/magento/module-quote/Model/Quote/TotalsCollector.php(261): Netresearch\ShippingCore\Model\AdditionalFee\Total->collect(Object(Magento\Quote\Model\Quote\Interceptor), Object(Magento\Quote\Model\ShippingAssignment), Object(Magento\Quote\Model\Quote\Address\Total))
netresearch/dhl-shipping-m2#5 vendor/magento/module-quote/Model/Quote/TotalsCollector.php(156): Magento\Quote\Model\Quote\TotalsCollector->collectAddressTotals(Object(Magento\Quote\Model\Quote\Interceptor), Object(Magento\Quote\Model\Quote\Address))
netresearch/dhl-shipping-m2#6 vendor/magento/module-quote/Model/Quote.php(2021): Magento\Quote\Model\Quote\TotalsCollector->collect(Object(Magento\Quote\Model\Quote\Interceptor))
netresearch/dhl-shipping-m2#7 generated/code/Magento/Quote/Model/Quote/Interceptor.php(743): Magento\Quote\Model\Quote->collectTotals()
netresearch/dhl-shipping-m2#8 vendor/magento/module-sales/Model/AdminOrder/Create.php(1634): Magento\Quote\Model\Quote\Interceptor->collectTotals()
netresearch/dhl-shipping-m2#9 vendor/magento/module-sales/Model/AdminOrder/Create.php(1622): Magento\Sales\Model\AdminOrder\Create->collectRates()
netresearch/dhl-shipping-m2#10 vendor/magento/module-sales/Model/AdminOrder/Create.php(596): Magento\Sales\Model\AdminOrder\Create->collectShippingRates()
netresearch/dhl-shipping-m2#11 vendor/mollie/magento2/Service/Order/Reorder.php(160): Magento\Sales\Model\AdminOrder\Create->initFromOrder(Object(Magento\Sales\Model\Order\Interceptor))
netresearch/dhl-shipping-m2#12 vendor/mollie/magento2/Service/Order/Reorder.php(125): Mollie\Payment\Service\Order\Reorder->recreate(Object(Magento\Sales\Model\Order\Interceptor))
netresearch/dhl-module-ui#6 vendor/mollie/magento2/Controller/Adminhtml/Action/MarkAsPaid.php(59): Mollie\Payment\Service\Order\Reorder->createAndInvoice(Object(Magento\Sales\Model\Order\Interceptor))
netresearch/dhl-shipping-m2#14 vendor/magento/framework/Interception/Interceptor.php(58): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid->execute()
netresearch/dhl-module-ui#4 vendor/magento/framework/Interception/Interceptor.php(138): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->___callParent('execute', Array)
netresearch/dhl-shipping-m2#16 vendor/magento/framework/Interception/Interceptor.php(153): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->Magento\Framework\Interception\{closure}()
netresearch/dhl-shipping-m2#17 generated/code/Mollie/Payment/Controller/Adminhtml/Action/MarkAsPaid/Interceptor.php(23): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->___callPlugins('execute', Array, Array)
netresearch/dhl-shipping-m2#18 vendor/magento/framework/App/Action/Action.php(111): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->execute()
netresearch/dhl-shipping-m2#19 vendor/magento/module-backend/App/AbstractAction.php(151): Magento\Framework\App\Action\Action->dispatch(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#20 vendor/magento/framework/Interception/Interceptor.php(58): Magento\Backend\App\AbstractAction->dispatch(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#21 vendor/magento/framework/Interception/Interceptor.php(138): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->___callParent('dispatch', Array)
netresearch/dhl-shipping-m2#22 vendor/magento/module-backend/App/Action/Plugin/Authentication.php(145): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#23 vendor/magento/framework/Interception/Interceptor.php(135): Magento\Backend\App\Action\Plugin\Authentication->aroundDispatch(Object(Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#24 vendor/magento/framework/Interception/Interceptor.php(153): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#25 generated/code/Mollie/Payment/Controller/Adminhtml/Action/MarkAsPaid/Interceptor.php(32): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->___callPlugins('dispatch', Array, Array)
#26 vendor/magento/framework/App/FrontController.php(245): Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#27 vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse(Object(Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor), Object(Magento\Framework\App\Request\Http))
netresearch/dhl-module-carrier-paket#2 vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest(Object(Magento\Framework\App\Request\Http), Object(Mollie\Payment\Controller\Adminhtml\Action\MarkAsPaid\Interceptor))
netresearch/dhl-shipping-m2#29 vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#30 vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
netresearch/dhl-shipping-m2#31 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
netresearch/dhl-shipping-m2#32 generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, Array)
netresearch/module-shipping-core#3 vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
netresearch/module-shipping-ui#1 vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\Http->launch()
netresearch/dhl-shipping-m2#35 vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\Http\Interceptor->___callParent('launch', Array)
netresearch/dhl-shipping-m2#36 vendor/justbetter/magento2-sentry/Plugin/GlobalExceptionCatcher.php(89): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}()
netresearch/deutschepost-module-internetmarke#1 vendor/magento/framework/Interception/Interceptor.php(135): JustBetter\Sentry\Plugin\GlobalExceptionCatcher->aroundLaunch(Object(Magento\Framework\App\Http\Interceptor), Object(Closure))
netresearch/dhl-shipping-m2#38 vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}()
netresearch/dhl-shipping-m2#39 generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http\Interceptor->___callPlugins('launch', Array, NULL)
netresearch/dhl-shipping-m2#40 vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
netresearch/dhl-shipping-m2#41 pub/index.php(30): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
netresearch/dhl-module-carrier-paket#7 {main}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.