netscaler / netscaler-helm-charts Goto Github PK

Hi.
Currently it's not possible to override only the image repository or registry, it's only possible to override the full image reference.
In a setting where the images are mirrored it would be great if we could just specify a different repository but use the default chart tag like so:

values.yaml

image:
  registry: quay.io
  repository: citrix/citrix-k8s-ingress-controller
  tag: 1.26.7 

And then we could override it:

override-values.yaml

image:
  registry: myregistry.com
  repository: mirrors/citrix/citrix-k8s-ingress-controller

See an example here https://github.com/bitnami-labs/sealed-secrets/blob/main/helm/sealed-secrets/values.yaml

Hello,

we want to install multiple ingress controller for different kind of service (eg. one ADC/VPX for external services and one ADC/VPX for internal services)

The first app can be installed via cloud-native-chart, when i install the second with different namespace and serviceAccount names therre comes the error
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "kube-cnc-router" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-namespace" must equal "citrix-ingress-internal": current value is "citrix-ingress-external"

Is the daployment of multiple instances for connecting different ADC's/VPX's in the same cluster supported?

Thanks!

The citrix-k8s-ingress-controller added --update-ingress-status in 1.8.19, however, the citrix-ingress-controller helm chart does not provide a way to set this arg. It would be nice to have the ability to set this arg via helm, so it doesn't need to be manually added after the fact.

Hi

Seems that #3 introduced some problems for us, because of the read-only setting, now when certificates are being "created" in citrix-k8s-ingress-controller pod it throws the error.

ERROR - [kubernetes.py:create_cert_data:2927] (MainThread) Could not create certificate file /tmp/foobar.crt: [Errno 30] Read-only file system: '/tmp/foobar.crt'

This lead to no https conf is setup for the ingress. Is it working as intended and we are missing something?

Thanks

After the last commit (1 hour ago) there comes a parse error while downloading the chart

Failed to parse response from https://citrix.github.io/citrix-helm-charts/index.yaml
Chart loaded with Rancher 2.6.8 on RKE2 Cluster

and loaded with Helm CLI the folling error comes

Error: looks like "https://citrix.github.io/citrix-helm-charts" is not a valid chart repository or cannot be reached: error converting YAML to JSON: yaml: line 2: mapping values are not allowed in this context

I attempted to install the helm chart for the ingress controller and it failed with the following error:

kubernetes@k8s-node-01:~$ helm install cic citrix/citrix-ingress-controller --set nsIP=10.0.0.137,license.accept=yes,adcCredentialSecret=nslogin
Error: chart requires kubeVersion: >=v1.16 < v1.22 which is incompatible with Kubernetes v1.21.3-3+6343a564e351b0

Can you please add -0 to the kubeVersion in order to allow this to be used with complex version strings?

For example, replace
kubeVersion: ">=v1.16 < v1.22"
with
kubeVersion: ">=v1.16-0 < v1.22-0"

Helm bug for reference: helm/helm#9371

Thanks!

Warren

Wrong values in:

in cnc chart it is .name

caused this error: template: netscaler-node-controller/templates/deployment.yaml:63:20: executing "netscaler-node-controller/templates/deployment.yaml" at <include "netscaler-k8s-node-controller.nsncConfigMap" .>: error calling include: template: netscaler-node-controller/templates/_helpers.tpl:89:37: executing "netscaler-k8s-node-controller.nsncConfigMap" at <63>: wrong type for value; expected string; got map[string]interface {}]

Attempt to install citrix-ingress-controll via helm 3.

Get the error:

Wait helm template failed. Error: apiVersion 'v2' is not valid. The value must be "v1" : exit status 1

This implies that even though the Chart.yaml is set to use helm 3, there is something within this deployment that does not properly validate against helm 3.

Attempting to use on Kubernetes v1.18.6

https://github.com/citrix/citrix-helm-charts/blob/master/citrix-ingress-controller/templates/cic_crds.yaml contains duplicate keys:

Resulting in the failure for it to be parsed into JSON and used within Helm

• https://github.com/citrix/citrix-helm-charts/blob/master/citrix-ingress-controller/templates/cic_crds.yaml#L389
• https://github.com/citrix/citrix-helm-charts/blob/master/citrix-ingress-controller/templates/cic_crds.yaml#L389

In file netscaler-node-controller/templates/serviceaccount.yaml is a wrong value named nncRouterName. In the values and other yaml's are named as nsncRouterName

Tolerations are useful for when you want to assign a pod to specific nodes. Currently it is not possible to set tolerations with these helm charts. This would be a nice addition as its extremely useful for when you want to pods to only run on specific nodes.

https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/

Hello!
Can you add possibility to add custom extra labels to service monitor when exporter enabled?
This feature need for target autodiscovering when prometheus operator is using.
I can write simple patch to helm chart if needed

Running the controller with provided configs produces the errors:

2020-04-06 01:40:02,018 - ERROR - [crdinfrautils.py:update_crd_status:35] (MainThread) Exception during CRD status update for logging-operator: 403 Client Error: Forbidden for url: https://10.112.0.1:443/apis/apps/v1/namespaces/kube-system/deployments/logging-operator/status
2020-04-06 01:39:41,137 - ERROR - [crdinfrautils.py:update_crd_status:35] (MainThread) Exception during CRD status update for istio-pilot: 403 Client Error: Forbidden for url: https://10.112.0.1:443/apis/apps/v1/namespaces/istio-system/deployments/istio-pilot/status

I was able to correct the problem by adding "namespaces/status" and "deployments/status" to the clusterrole/cic-k8s-role.

If you are reading this, there are two other minor changes you should consider:

• There should be a helm variable to configure the --ipam argument.
• The default-ssl-certificate argument value doesn't seem to be escaped properly and rendering the template leaves the value as "{{ .Release.Namespace }}/default-cert"

thanks

thanks