Giter VIP home page Giter VIP logo

baselines's People

Contributors

daveey avatar dsctt avatar jsuarez5341 avatar kywch avatar markhaoxiang avatar nikhilpinnaparaju avatar nishaanthkanna avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

baselines's Issues

AssertionError: CLI argument: scale is not a Config property

At https://neuralmmo.github.io/build/html/rst/baselines.html the suggest that you could change "scale".

But trying the suggested commandline:

python main.py train --config=baselines.Medium --scale=Baseline --RESTORE=None

You are just getting the error:
AssertionError: CLI argument: scale is not a Config property

My guess is that it happens because the order of the commands.
If you take a look at https://github.com/NeuralMMO/baselines/blob/main/main.py#L188

Those lines should probably be placed before:

      config = attrgetter(config)(base_config)()
      config.override(**kwargs)

Or else the "scale"-Parameter will be passed directly to the config-class ...

[Potentially a Bug] Scripted Agents won't purchase poultices or rations

I found a potential faulty implementation in the buy action. I implemented my agents based on this script and found out that my agents aren't buying any supplies from the market despite them being readily available on the market at affordable prices.

It seems that purchase isn't being used anywhere and because rations and poultices aren't in the buy_upgrade, it is likely that the itm got skipped and the buy action is never updated. This is given that the agents haven't put poultices or rations into the wishlist, but from my understanding, the wishlist and supplies are meant to be separated.

I am willing to work on a small PR if you are busy doing something else.

AssertionError: Missing evaluation key. Patch RLlib as per the installation guide

Failure # 1 (occurred at 2022-04-25_11-36-54)
Traceback (most recent call last):
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/tune/trial_runner.py", line 893, in _process_trial
results = self.trial_executor.fetch_result(trial)
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/tune/ray_trial_executor.py", line 707, in fetch_result
result = ray.get(trial_future[0], timeout=DEFAULT_GET_TIMEOUT)
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/_private/client_mode_hook.py", line 105, in wrapper
return func(*args, **kwargs)
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/worker.py", line 1733, in get
raise value.as_instanceof_cause()
ray.exceptions.RayTaskError(AssertionError): �[36mray::PPO.train()�[39m (pid=449, ip=172.22.54.224, repr=PPO)
File "/home/zsd/nmmo/baselines/rllib_wrapper.py", line 243, in train
stats = super().train()
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/tune/trainable.py", line 315, in train
result = self.step()
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 982, in step
raise e
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 963, in step
step_attempt_results = self.step_attempt()
File "/home/zsd/anaconda3/envs/nmmo/lib/python3.9/site-packages/ray/rllib/agents/trainer.py", line 1066, in step_attempt
step_results.update(self.evaluate())
File "/home/zsd/nmmo/baselines/rllib_wrapper.py", line 253, in evaluate
assert 'Raw_Policy_IDs' in stats, err
AssertionError: Missing evaluation key. Patch RLlib as per the installation guide

[Bug Report] DirectoryPolicyStore missing in pufferlib

In clean_pufferl.py, there is one line: "self.policy_store = pufferlib.policy_store.DirectoryPolicyStore". However, in pufferlib.policy_store, there is only PolicyStore instead of DirectoryPolicyStore. I tried to use PolicyStore to bypass this problem. But later I encounter


) for p in self.policy_store.select_policies(self.policy_selector)

AttributeError: 'PolicyStore' object has no attribute 'select_policies'


Question about nips2023nmmo

hello, I have been paying attention to the progress of the neuralmmo environment, thank you for your contribution. I have few questions about 2023nips neuralmmo competition.

I wonder if we need to submit the team decision model which makes decision for 8 agents, while I didn’t find any message about ‘Team’ on Alcrowd page. And it is unclear that how to get team message in baseline.
If the submitted models are based on teams, it is unclear how the competition will be ranked and what kind of task file will be used for evaluating and ranking.
Is there some clearer tutorials and instructions about this game like last year? I would like to express my gratitude again and hope that I can get more clear information to help me participate in this competition.

[Bug Report] AttributeError: module 'nmmo.lib.material' has no attribute 'Forest'

OS: Ubuntu 16.04

Description:

  1. mkdir neural-mmo && cd neural-mmo
  2. git clone https://github.com/neuralmmo/environment.git
  3. git clone https://github.com/neuralmmo/baselines.git
  4. cd environment && pip install -e .[all]
  5. cd baselines && pip install -r requirements.txt
  6. python train.py
    Then, the error occurred:
Traceback (most recent call last):
  File "/home/xxx/neural-mmo/baselines/train.py", line 14, in <module>
    from model.realikun.baseline_agent import BaselineAgent
  File "/home/xxx/neural-mmo/baselines/model/realikun/baseline_agent.py", line 10, in <module>
    from model.realikun.policy import BaselinePolicy
  File "/home/xxx/neural-mmo/baselines/model/realikun/policy.py", line 5, in <module>
    from env.nmmo_team_env import NMMOTeamEnv
  File "/home/xxx/neural-mmo/baselines/env/nmmo_team_env.py", line 8, in <module>
    from feature_extractor.feature_extractor import FeatureExtractor
  File "/home/xxx/neural-mmo/baselines/feature_extractor/feature_extractor.py", line 6, in <module>
    from feature_extractor.map_helper import MapHelper
  File "/home/xxx/neural-mmo/baselines/feature_extractor/map_helper.py", line 9, in <module>
    from nmmo.io import action
ModuleNotFoundError: No module named 'nmmo.io'
  1. I solved the error ModuleNotFoundError: No module named 'nmmo.io' by changing from nmmo.io import action to from nmmo.core import action in /home/xxx/neural-mmo/baselines/feature_extractor/map_helper.py", line 9.
  2. However, another error occurred when I run python train.py:
Traceback (most recent call last):
  File "/home/xxx/neural-mmo/baselines/train.py", line 14, in <module>
    from model.realikun.baseline_agent import BaselineAgent
  File "/home/xxx/neural-mmo/baselines/model/realikun/baseline_agent.py", line 10, in <module>
    from model.realikun.policy import BaselinePolicy
  File "/home/xxx/neural-mmo/baselines/model/realikun/policy.py", line 5, in <module>
    from env.nmmo_team_env import NMMOTeamEnv
  File "/home/xxx/neural-mmo/baselines/env/nmmo_team_env.py", line 8, in <module>
    from feature_extractor.feature_extractor import FeatureExtractor
  File "/home/xxx/neural-mmo/baselines/feature_extractor/feature_extractor.py", line 6, in <module>
    from feature_extractor.map_helper import MapHelper
  File "/home/xxx/neural-mmo/baselines/feature_extractor/map_helper.py", line 34, in <module>
    material.Forest.index: material.Scrub.index,
AttributeError: module 'nmmo.lib.material' has no attribute 'Forest'

9. Thus, there are some bugs, can the baselines repository run successfully?

main.py causes typeerror involving wandb

Followed the installation instructions, running main.py throws 'TypeError: Object of type property is not JSON serializable' from wandb.init. Any advice would be appreciated

full traceback:

Traceback (most recent call last):
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 931, in init
run = wi.init()
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 579, in init
ret = backend.interface.communicate_run(run, timeout=30)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 209, in communicate_run
run = self._make_run(run_obj)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 164, in _make_run
self._make_config(data=config_dict, obj=proto_run.config)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 146, in _make_config
update.value_json = json_dumps_safer(json_friendly(v)[0]) # type: ignore
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/util.py", line 750, in json_dumps_safer
return json.dumps(obj, cls=WandBJSONEncoder, **kwargs)
File "/usr/lib/python3.9/json/init.py", line 234, in dumps
return cls(
File "/usr/lib/python3.9/json/encoder.py", line 199, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/usr/lib/python3.9/json/encoder.py", line 257, in iterencode
return _iterencode(o, 0)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/util.py", line 705, in default
return json.JSONEncoder.default(self, obj)
File "/usr/lib/python3.9/json/encoder.py", line 179, in default
raise TypeError(f'Object of type {o.class.name} '
TypeError: Object of type property is not JSON serializable
wandb: ERROR Abnormal program exit
Traceback (most recent call last):
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 931, in init
run = wi.init()
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/wandb_init.py", line 579, in init
ret = backend.interface.communicate_run(run, timeout=30)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 209, in communicate_run
run = self._make_run(run_obj)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 164, in _make_run
self._make_config(data=config_dict, obj=proto_run.config)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/sdk/interface/interface.py", line 146, in _make_config
update.value_json = json_dumps_safer(json_friendly(v)[0]) # type: ignore
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/util.py", line 750, in json_dumps_safer
return json.dumps(obj, cls=WandBJSONEncoder, **kwargs)
File "/usr/lib/python3.9/json/init.py", line 234, in dumps
return cls(
File "/usr/lib/python3.9/json/encoder.py", line 199, in encode
chunks = self.iterencode(o, _one_shot=True)
File "/usr/lib/python3.9/json/encoder.py", line 257, in iterencode
return _iterencode(o, 0)
File "/home/dannysollo/.local/lib/python3.9/site-packages/wandb/util.py", line 705, in default
return json.JSONEncoder.default(self, obj)
File "/usr/lib/python3.9/json/encoder.py", line 179, in default
raise TypeError(f'Object of type {o.class.name} '
TypeError: Object of type property is not JSON serializable

KeyError: 3 at time: 1.65088e+09

[2022-04-25 18:24:10,728 E 4497 4497] core_worker.cc:1274: Pushed Error with JobID: 01000000 of type: task with message: ray::RolloutWorker.sample()::Exiting (pid=4497, ip=172.17.0.3, repr=<ray.rllib.evaluation.rollout_worker.modify_class..Class object at 0x7f8f95c8cc40>)
File "/root/miniconda3/lib/python3.8/site-packages/ray/rllib/evaluation/rollout_worker.py", line 761, in sample
batches = [self.input_reader.next()]
File "/root/miniconda3/lib/python3.8/site-packages/ray/rllib/evaluation/sampler.py", line 104, in next
batches = [self.get_data()]
File "/root/miniconda3/lib/python3.8/site-packages/ray/rllib/evaluation/sampler.py", line 266, in get_data
item = next(self._env_runner)
File "/root/miniconda3/lib/python3.8/site-packages/ray/rllib/evaluation/sampler.py", line 634, in _env_runner
_process_observations(
File "/root/miniconda3/lib/python3.8/site-packages/ray/rllib/evaluation/sampler.py", line 963, in _process_observations
callbacks.on_episode_end(
File "/root/neural-mmo/baselines/rllib_wrapper.py", line 305, in on_episode_end
policy = inv_map[policy_id].name
KeyError: 3 at time: 1.65088e+09

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.