newfold-labs / wp-module-data Goto Github PK

When a site attempts to self-connect, we increment the throttle counter. This helps with the back-off timing for successive connection failures to prevent performance issues on a site, or a site sending many repeated Hiive connection requests.

However, once a site is successful in connecting (a new token is stored) we should clear this throttle counter value, or reset it to 0.

This is located in the src/Listeners/BluehostPlugin.php file:

// Site Launched - Coming Soon page disabled
add_filter( 'pre_update_option_mm_coming_soon', array( $this, 'site_launch' ), 10, 2 );

We need to create a Listeners/ComingSoon.php file in the coming soon module and register it as a listener via the newfold_data_listeners hook.

In some cases, a token may get injected into the database without being properly encrypted. We should add a check for this and automatically encrypt it.

We'll need to run a regex check for ^\d+| and then encrypt.

Currently, our auto-encryption only works via a filter for updating. We should add a filter for adding as well or even use the sanitize_option_{$option} filter.

We have a version number constant as NFD_DATA_MODULE_VERSION, we need to keep it synced with the actual tagged release version.

This will help track bugs down and add upgrade routines like what we'll could put in place for #8

There should be a standard and a specification for pageviews and events. And all of that should be sent from various clients to the hiive. Then hiive can send it to GA, Data Warehouse, whatever else.

Each consumer shouldn't have to figure it out themselves or look at an existing implementation and figure out how to use it for a new use case.

The shape needs to have some default key values, and then a way for additional meta, so that it can support all use cases easily.

This might already exist, but we need documentation for the wp rest api for collecting events, a JS example, a PHP example. Engineers shouldn't have to reverse engineer an existing implementation, we should be able to just reference the docs.

Documentation should live in confluence.

Tracking number 0a14f99f-0e66-49fb-a77f-16fe591fb1cd

This module is conflicting with any other plugin which uses the $_SERVER['HTTP_AUTHORIZATION'] header. Your code references a data_get function which is not present in most WordPress installs:

cc @wpscholar

This is located in the src/Listeners/BluehostPlugin.php file:

// SSO (Legacy)
add_action( 'eig_sso_success', array( $this, 'sso_success' ), 10, 2 );
add_action( 'eig_sso_fail', array( $this, 'sso_fail' ) );

// SSO
add_action( 'newfold_sso_success', array( $this, 'sso_success' ), 10, 2 );
add_action( 'newfold_sso_fail', array( $this, 'sso_fail' ) );

We need to create a Listeners/SSO.php file in the SSO module and register it as a listener via the newfold_data_listeners hook.