newlandsvalley / chord-editor Goto Github PK

We use the names in three contexts but with different formats - titling, file naming and URI components.

I think it makes sense to rename FrettedInstrumentExample as FrettedInstrumentName, use this in the config and write functions to generate the correct string in each context.

Hi, how hard would it be to add tenor guitar?

It's tuned in 5ths: C G D A

https://en.wikipedia.org/wiki/Tenor_guitar

https://www.youtube.com/watch?v=aTjm60tm2WY

Fantastic app which is just what I was looking for (a piano choard equivalent to the chordpic app). However, for the piano chord image, the text for the name of the chord is a little small when it is resized for adding to a song sheet. If the name text could be made the same size as used for the piano chords used by many of the Ultimate Guitar songsheets that would be brilliant: https://tabs.ultimate-guitar.com/tab/steely-dan/do-it-again-chords-3035016

@newlandsvalley

The idea would be to have the app rebuilt and deployed to GitHub Pages on every commit to master via the CI pipeline.

You can use your current domain of tradtunedb.org.uk and the SSL would probably be handled automatically for you so that you have https configured without having to worry about setting it up yourself or renewing with the certificate authority.

I currently have this set up on SourceHut for this website: https://whereis.みんな/

This is the deploy script for that website: https://git.sr.ht/~whereiseveryone/website/tree/master/item/.build.yml

What do you think?

Hi,

GitHub Discussions can facilitate a way for the community and/or prospective chord-editor contributors to discuss directions for the project without opening an issue that is really a discussion topic.

Can you enable this feature?

See the guide here for doing that:

https://docs.github.com/en/discussions

It's simpler and safe to calculate it from the string count.

This is an open issue to consolidate code in order to avoid duplication when adding more string instruments to chord-editor in the future.

@newlandsvalley What do you suggest we consolidate?

Might be cool to have note names rendered when you click on the fret or do you think it would be bloat?

Some perl inspiration:

https://github.com/mizlan/guitar-scale-chart#readme

I think this is to do with translation to and fro between the URI string component and the FrettedInstrumentExample data type. I think we need to decide on whether or not the URI component is tenorGuitar or tenorguitar. I suspect it will be a lot more straightforward to change it to the latter.

https://www.youtube.com/watch?v=sfmAeijj5cM

Hi,

The difference between a tenor banjo and a tenor guitar is just the timbre or sound (e.g. a different MIDI instrument).

How should we add this and introduce the tenor banjo?

Now that this has grown from being a small thing for Sturla and other people are interested.

What do you think of having interactive documentation for chord-editor similar to this component library (same applies to other purescript/halogen component libraries):

For example, the action sheet component in the mint-ui library:

https://ui.mint-lang.com/components/ui-action-sheet

src:

https://github.com/mint-lang/mint-ui-website

mint is a language inspired by elm.

mint has ffi syntax similar to ruby's backtick shelling out syntax:

fun handleClick (event : Html.Event) : Void {
    `alert("Hello")`
  }

The above mint code does ffi with alert.