newsuk/times-components#266

ideally failing the one test with component that does not exist

component loader should be able to handle a showcase file without a default, and when a showcase file causes an error, we should be able to log this out somehow. I'd imagine we need to tell the client somehow

lib-904da1664780380f.js:1 Uncaught TypeError: Cannot read property 'filter' of undefined
at lib-904da1664780380f.js:1
at Array.forEach ()
at t.default (lib-904da1664780380f.js:1)
at lib-904da1664780380f.js:1
at _ (lib-904da1664780380f.js:1)
at R (lib-904da1664780380f.js:1)
at c (lib-904da1664780380f.js:1)
at f (lib-904da1664780380f.js:1)
at HTMLUnknownElement.l (lib-904da1664780380f.js:1)
at Object.Oo (lib-904da1664780380f.js:1)

"We recommend looking at the examples for web and native as there are slight differences."

This line in your ReadMe has broken links.

in /fructose/packages/test-helpers/src/index.js
this sets up the withComponent global

withComponent should report the component name not description

Fructose does not currently handle sending different messages to different app clients. This means it can't run parallel tests.

Perhaps we could add a unique identifier as a property on the components and use that to pull up our components from within the fructose app.

I believe this is a more defensive method as we are not as reliant on the format of the react native components.

The down side of this is in the components them selves you will need to add some testing prop. Similar in concept to CSS ID tags.

the events being sent between the client, server and app I feel are a bit messy and could use better naming

Logs are logging all previous 'loaded components' as well as the currently loaded one. We only want the currently loaded one.

The throw new Error("should be the hobbit!"); is only thrown when the text here eg. "The Hobbit" is different to that of a if (a !== "The Hobbit") {
If "The Hobbit" text is different here: <Text style={styles.title} fructoseID="hobbit">The Hobbit</Text>,
or here await driver.waitForVisible('//*[@text="The Hobbit"]', 6000);
or here const a = await driver.getText('//*[@text="The Hobbit"]');
then only a plain Error is shown, see the attached screenshots.
Should errors at these points have better descriptions?

withComponent(
  <Text style={styles.title} fructoseID="hobbit">The Hobbit</Text>,
  "basic text",
  fructose => {
    beforeEach(async () => {
      await fructose.loadComponent();
    });

    test("simple test", async () => {
      await driver.waitForVisible('//*[@text="The Hobbit"]', 6000);
      const a = await driver.getText('//*[@text="The Hobbit"]');
      if (a !== "The Hobbit") {
        throw new Error("should be the hobbit!");
      }
    });
  }
);

swap

const directory = program.buildDir ? program.buildDir : ".fructose";
const upperConfig = require( `../../../../../../${directory}/webpack.config.js`);// eslin

for
const upperConfig = require( ${directory}/webpack.config.js);

and fix broken things

We should listen on events for the child process packager, if the packager is terminated the tests should be become aware of this and terminate correctly

If a showcase file has no default export defined then it will throw an error saying that it cannot find children of undefined.

Should be more defensive around this. 👍

packages/client/client.test.js
FructoseClient
✓ e2e test (34ms)

No fructoseID prop found on the component. Please add a fructoseID prop.

In times components our ignored showcase file looks like this

const ignoredShowcases = [
  "Brightcove",
  "brightcove",
  "Provider",
  "provider",
  "Video",
  "video",
  "Tracking",
  "tracking",
  "Loading",
  "Pages/Long Article",
  "Pages/Default"
];

we should sanitize our component input before we use it

and report back to user why the test are unable to run

In package.json you have:

  "bin": {
    "compile-tests": "packages/test-helpers/bin/writeComponentsTests.js",
  }

That file does not appear to exist in packages/test-helpers/bin/ and causes an error when trying to run npm i @times-components/fructose:

npm ERR! enoent ENOENT: no such file or directory, chmod '/my/project/node_modules/@times-components/fructose/packages/test-helpers/bin/writeComponentsTests.js'

withComponent(, desc, tests)

description is not being used

Fructose should have a cli like mocha or jest so that we don't have to work around the idiosyncrasies of jest. With a custom cli we can make the fructose experience smoother.

Issue:
Web tests fail when dependencies are installed in a certain order.

Steps to reproduce:

1. Yarn within the root fructose directory
2. Change to the e2eTests directory
3. Yarn again.
4. Run the web tests yarn test:web

Expected:
Web tests to pass

Actual:
Web tests fail