Giter VIP home page Giter VIP logo

Comments (16)

LukeOwlclaw avatar LukeOwlclaw commented on May 18, 2024 1

@AndyScherzinger Yes, of course! Thank you! @tobiasKaminsky Sorry for not pushing my changes. Too busy....

from android.

bes1002t avatar bes1002t commented on May 18, 2024

mh I don't know whether this is an good idea or not. In my opinion we should implement an account management system in our android application. That would be much cleaner than creating a new instance for every account.

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

Multiple instances of the app are not possible.
I remember that there is a PR in ownCloud that, at least, shows to which account the instant upload is set.
Technical background: the instant upload is not always to the current accout, but to the account which was in use when the instant upload is defined.

So my proposal is to make the account to which instant upload is bound to easier to choose.
@jancborchardt for designing.

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

owncloud/android#1637
@LukeOwncloud maybe you want to help us here? I promise that your PR will be handled much faster 👍

from android.

jgrete avatar jgrete commented on May 18, 2024

Hello,

I'm the OP from help.nextcloud.com.
I've learned multiple instances of an app are not possible. OK, an account managment would do also.
The following are just my thoughts:

  • the active account should be visible all the time (maybe next to "Nextcloud" ?)
  • choosing the active account is misplaced in the settings and would be better placed in the left
    menu at toplevel as a dropdown, so changing an account is easier
  • the account used for uploading should be marked as such in the dropdown
  • if the upload account is not the active acount no instant upload would happen, wouldn't it?
    That was the reason many of my instant uploads didn't work. Is there a better solution?

As I said - just my thoughts :-)

Thank you very much
Jürgen

from android.

LukeOwlclaw avatar LukeOwlclaw commented on May 18, 2024

If I understant correctly, this should be handled by owncloud/android#1637. @tobiasKaminsky Sorry, I cannot contribute in these days.

from android.

jancborchardt avatar jancborchardt commented on May 18, 2024

choosing the active account is misplaced in the settings and would be better placed in the left
menu at toplevel as a dropdown, so changing an account is easier

@jgrete there is already a pull request for that and it will be in shortly I assume. :) cc @AndyScherzinger

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

This seems a very easy PR, so adding it to next milestone.

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

@LukeOwncloud the mentioned PR is only in your repository.
Can you push it to this repository.
Then I can have a look, update it and so on.

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

To get a 1.1.0 a little quicker we postpone this to 1.2.0

from android.

jgrete avatar jgrete commented on May 18, 2024

The latest beta2010621 works quite well - no crashes so far.
A minor bug seems to be that there is no "instant" update of the files list after choosing a different account from the dropdown. One have to wait until the screen gets locked. After unlocking the screen the files list is getting updated (caused by an event ?). Manually updating the account (via '...' menu) works well. In no case there's any visual feedback (except the changing files list) which might be suboptimal.

Thank you
Jürgen

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

@jgrete this is is a different issue so please report it as a new issue

from android.

AndyScherzinger avatar AndyScherzinger commented on May 18, 2024

I moved Luke's changes to a branch within the nextcloud repo. I hope this is fine with you @LukeOwncloud ? --> #98

from android.

AndyScherzinger avatar AndyScherzinger commented on May 18, 2024

It seems one issue has been found with this one: If the user enables the instant upload and doesn't change the default folder, no account is saved as target account and the upload is not done. The broadcast receiver logs:

07-13 11:07:55.544 14302-14302/com.owncloud.android W/com.owncloud.android.files.InstantUploadBroadcastReceiver: No account found for instant upload, aborting

from android.

mario avatar mario commented on May 18, 2024

Fixed at least for Auto Upload, and that's pretty much all we care about anyway.

from android.

tobiasKaminsky avatar tobiasKaminsky commented on May 18, 2024

To explain it to other users: we will replace InstantUpload on all devices with Auto Upload.

from android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.