nextcloud / ocsms Goto Github PK

View Code? Open in Web Editor NEW

189.0 30.0 52.0 14.54 MB

📱 Nextcloud/ownCloud PhoneSync server application

Home Page: https://play.google.com/store/apps/details?id=fr.unix_experience.owncloud_sms

License: GNU Affero General Public License v3.0

PHP 43.32% CSS 3.31% JavaScript 52.71% Shell 0.61% Dockerfile 0.04%

nextcloud phone-sync

ocsms's Introduction

Phone Sync (for Nextcloud & ownCloud)

Phone Sync provides a webinterface to display your SMS conversations. SMS conversations are pushed by your Android devices using the Android client, available on F-Droid.

▶️ Access

The app is available on the Nextcloud App Store, so installing is as easy as:

Navigate in your Nextcloud instance to the "Apps"
Select the category "Multimedia"
Click "activate"

❓ Solve encoding errors on MySQL

If you are on MySQL or MariaDB and have the following issue with the database:

Incorrect string value: '\xF0\x9F\x98\x89' for column 'sms_msg' at row 1

The cause may be that you have to enable 4-byte support.

Here is a guide: https://docs.nextcloud.com/server/11/admin_manual/maintenance/mysql_4byte_support.html

❓ Solve InnoDB 'Index column size too large' error on MySQL

If you are on MySQL or MariaDB and have the following issue with the database:

Index column size too large. The maximum column size is 767 bytes.

You should reconfigure your MySQL server to support a such column size.

Here are some informations: https://stackoverflow.com/questions/30761867/mysql-error-the-maximum-column-size-is-767-bytes/30767600

❓ Solve the synchronisation issues

If you are using FastCGI you must enable buffering in FastCGI but commenting the following line:

fastcgi_request_buffering off;

❓ Using the Android App With 2FA Enabled

If you've enabled 2FA (Two Factor Authentication) logins you may be hit with an incorrect password error. The android client doesn't support logging in with 2FA credentials. Here is a guide to do so, although it says Managing Devices it is the same process for App Passwords: https://docs.nextcloud.com/server/11/user_manual/session_management.html#managing-devices

👀 Screenshot

🔗 Requirements

A Nextcloud or ownCloud instance
An Android phone

❗ Reporting issues

Server: https://github.com/nextcloud/ocsms/issues
Client: https://github.com/nerzhul/ownCloud-SMS-App/issues

📓 License

Phone Sync web application is currently licensed under AGPL license.

📓 External Libraries

Twemoji Code licensed under the MIT License, Graphics licensed under CC-BY 4.0. libphonenumber-for-php Code licensed under the Apache 2.0 License.

ocsms's People

Contributors

Stargazers

Watchers

ocsms's Issues

Android Client: installed but no laucher to launch

Android version: 4.4.4
Phone: kltevzw (Galaxy S 5 verizon)

An exception occurred while executing INSERT INTO oc_ocsms_smsdatas

solved in file apps/ocsms/db/smsmapper.php by adding :
on line +262 $today = date("Y-m-d H:i:s");
and change on line +264 "NOW()","NOW()" with $today, $today

Server

ownCloud version: 7.0.4 (stable)
PHP version: PHP 5.6.5
HTTPd server: Apache/2.4.10
HTTPS: Apache/2.4.10
mysqld : 5.6.17

Client

Android version: 4.2.2
Phone: -
ownCloud SMS app version: 0.17.0

Content of /owncloud/data/owncloud.log

{"reqId":"54e48640cdc96","app":"index","message":"Doctrine\DBAL\DBALException: An exception occurred while executing 'INSERT INTO oc_ocsms_smsdatas (user_id, added, lastmodified, sms_flags, sms_date, sms_id,sms_address, sms_msg, sms_mailbox, sms_type) VALUES (?,?,?,?,?,?,?,?,?,?)':\n\nSQLSTATE[22007]: Invalid datetime format: 1292 Incorrect datetime value: 'now()' for column 'added' at row 1","level":4,"time":"2015-02-18T12:32:00+00:00","method":"POST","url":"/index.php/apps/ocsms/push?format=json"}
{"reqId":"54e486415309f","app":"index","message":"Doctrine\DBAL\DBALException: An exception occurred while executing 'INSERT INTO oc_ocsms_smsdatas (user_id, added, lastmodified, sms_flags, sms_date, sms_id,sms_address, sms_msg, sms_mailbox, sms_type) VALUES (?,?,?,?,?,?,?,?,?,?)':\n\nSQLSTATE[22007]: Invalid datetime format: 1292 Incorrect datetime value: 'now()' for column 'added' at row 1","level":4,"time":"2015-02-18T12:32:01+00:00","method":"POST","url":"/index.php/apps/ocsms/push?format=json"}
{"reqId":"54e48641a272d","app":"index","message":"Doctrine\DBAL\DBALException: An exception occurred while executing 'INSERT INTO oc_ocsms_smsdatas (user_id, added, lastmodified, sms_flags, sms_date, sms_id,sms_address, sms_msg, sms_mailbox, sms_type) VALUES (?,?,?,?,?,?,?,?,?,?)':\n\nSQLSTATE[22007]: Invalid datetime format: 1292 Incorrect datetime value: 'now()' for column 'added' at row 1","level":4,"time":"2015-02-18T12:32:01+00:00","method":"POST","url":"/index.php/apps/ocsms/push?format=json"}

Controller push method not CSRF protected

https://github.com/nerzhul/ocsms/blob/master/controller/smscontroller.php#L233

You should in general only use @NoCSRFRequired for the index method.

SMSs to same person shows as different conversations

For some conversations, it seems there are two entries for the same person. I see that the urls are '/owncloud/index.php/apps/ocsms/?phonenumber=+12 34 56 789#' vs '/owncloud/index.php/apps/ocsms/?phonenumber=+123456789#' -- notice the additional space. I don't know where the space comes from, but I assume it should be stripped, and that both conversations show as the same conversation?

I'm using ownCloud 8, ocsms git 75e3e40 and ownCloud-SMS 0.17.0 from fdroid.

there isn't any conversation

i have OC 7.04 and ocsms 1.3.2, apps it's install ok
i have a smartphone with ocsms owncloud, downloaded recently
my onwcloud instance is running ubuntu server 12.04, it works fine
there isn't any conversation yet

in sms-owncloud smartphone menu, synchronise is activated and up, no error displayed

Add sort by date or alphabetical option to left pane

It would be nice to have 'sort by' option at the top of the left pane to choose by date or alphabetical.

indexes on database

i was quite astonished to see no indexes on the database. i would suggest the following.

(numbers in the index rows reflect the ordinal position of the field within the index

PREFIXocsms_config

function	key	user
set	x	x
hasKey	x	x
getKey	x	x
suggested index
PRIMARY	2	1

❗ this is not possible, unless the datatype of key is changed. but i don't see any reason for a mediumtext in the first place. i guess varchar(255) would be enough.

PREFIXocsms_smsdatas

function	user_id	sms_mailbox	sms_address	sms_date
getAllIds	x
getAllIdsWithStatus	x
getLastTimestamp	x			max()
getAllPeersPhoneNumbers	x	x
getAllPhoneNumbersForFPN	x	x
getAllMessagesForPhoneNumber	x	x	x	>
countMessagesForPhoneNumber	x	x	x	count()
getLastMessageTimestampForAllPhonesNumbers	x	x
getNewMessagesCountForAllPhonesNumbers	x	x	group by	>
writeToDB	x
suggested index
ocsms_user_addr_date_mbox_index	1	4	2	3
ocsms_user_mbox_index	1	2

PREFIXocsms_user_datas

function	user_id	datakey	datavalue
getLastReadDate	x		max()
setLastReadDate	x	x
suggested index
ocsms_user_key_index	1	2
ocsms_user_value_index	1		2

if there is a consent on these indices i will try to make an update script. if anyone can give me a hint on where to start it would be appreciated.

Update ownCloud SMS with ownCloud Server updates

Today, you have to update ownCloud SMS manually.

It would be much better to get automatic updates, and update when ownCloud comes out with a new release.

FYI It's possible through ocsid

Is the client going to be open sourced?

This bothers me because I don't like apps which don't have source code available on my phone... Is there a plan to open source the client? If you want to sell it for money, actually opening it under a non-free license is a possible option -- claim it open source so people can see what's in the code, and no one can build it legally so that you can be the only seller on Google play or other stores.

Sync photos of contacts

Use the Contacts app information to sync the photos of contacts in your adress book.

How do I translate?

Is this project on Transifex?

@nerzhul

Exception: js file not found: script:js/public/app formfactor: serverroot:/var/secure/owncloud

Hello,

Sorry for beeing so annoying. The Issue #35 is solved. But there is another problem.

I installed the app, everything worked fine. But when i start it, i get a blank page an following errors.

{"reqId":"54c637de1e4d7","app":"index","message":"Exception: js file not found: script:js/public/app formfactor: serverroot:/var/secure/owncloud","level":4,"time":"2015-01-26T12:49:34+00:00","method":"GET","url":"/owncloud/index.php/apps/ocsms/"}
{"reqId":"54c637de1e4d7","app":"PHP","message":"js file not found: script:js/public/app formfactor: serverroot:/var/secure/owncloud at /var/secure/owncloud/lib/private/template/resourcelocator.php#49","level":3,"time":"2015-01-26T12:49:34+00:00","method":"GET","url":"/owncloud/index.php/apps/ocsms$

Thank you for helping.

Error in smsmapper.php and Appframwork

I reeally wonder what this is:

{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T00:20:43+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T01:20:34+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T04:20:35+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T07:21:05+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T10:22:06+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T13:22:06+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T16:22:08+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:10:33+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:10:37+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:10:39+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:11:05+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:11:07+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:11:23+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:11:24+00:00"}
{"app":"PHP","message":"call_user_func() expects parameter 1 to be a valid callback, class 'OCA\\OcSms\\Db\\Config' not found at \/var\/www\/owncloud\/lib\/public\/appframework\/db\/mapper.php#250","level":3,"time":"2015-01-30T18:11:26+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T19:22:08+00:00"}
{"app":"PHP","message":"Undefined index: 3 at \/var\/www\/owncloud\/apps\/ocsms\/db\/smsmapper.php#45","level":3,"time":"2015-01-30T22:22:35+00:00"}

Running 1.4.2.

Mobile CSS is wrong

http://goo.gl/rhvE3F

You can't swipe to see the conversations.

"No app name specified" when try to enable ocsms v1.4 in my owncloud apps webpage

I downloaded your v1.4 zip and opened my owncloud apps webpage, press the Enable button, but it fails to enable and says: "No app name specified". Also when looking up the link "See application page on apps.owncloud.com" (http://apps.owncloud.com/content/show.php?content=ocsms) it has an empty app page with text "Content not found".

Server

ownCloud version: 7.0.4
PHP version: 5.6.5
HTTPd server: Apache 2.4.10
HTTPS: openssl 1.0.1l

Client (irrelevant for this issue)

Content of /owncloud/data/owncloud.log

Warning core XCache opcode cache will not be cleared because "xcache.admin.enable_auth" is enabled. 2015-01-26T10:11:10+00:00
Error core No app name specified 2015-01-26T10:03:13+00:00
Fatal core Invalid OCS content returned for app ocsms 2015-01-26T10:03:13+00:00
Error core No app name specified 2015-01-26T10:00:43+00:00
Fatal core Invalid OCS content returned for app ocsms 2015-01-26T10:00:43+00:00
Error core No app name specified 2015-01-26T10:00:37+00:00
Fatal core Invalid OCS content returned for app ocsms 2015-01-26T10:00:37+00:00

Can't install ownCloud app

error message in owncloud.log :

{"app":"core","message":"App "ocsms" is using a not allowed call "OC_DB::". Installation refused.","level":3,"time":"2014-10-06T09:36:04+00:00"}

Feature-request: backing up sms from messagins apps other than the default

i do not use the default messaging app. an option to change the source [app] to back up would be nice

Lot of timeout with nginx

Server

ownCloud version: 7.0.4
PHP version: 5.4.36
HTTPd server: nginx
HTTPS: yes

Client

Android version: 4.4
Phone: HTC Wildfire
ownCloud SMS app version: 1.4.1

Content of /owncloud/data/owncloud.log : nothing in owncloud.log

I have a lot of error message in nginx/error.log concerning timeout

2015/01/27 22:32:16 [error] 26577#0: *6559 upstream timed out (110: Connection timed out) while reading response header from upstream, client: X.X.X.X, server: cloud.server.net, request: "GET /index.php/apps/ocsms/get/conversation?phoneNumber=%2B3399999999 HTTP/1.1", upstream: "fastcgi://unix:/run/php-fpm.sock", host:…

I've change fastcgi_read_timeout to 120 without any success

Spaces in phone numbers don't resolve in adressbook

It seems that Ocsms is unable to match phone numbers written with spaces (XX XX XX XX XX) with the ones of contacts.

(Of course, the corresponding contacts also have their number writtent with spaces in the addressbook.)

[Android] Force close parameters on Andoird 4.4.4

Hi,

I juste install owncloud sms app, I can configure new account but when I re-click on the owncloud sms account I had a force close. I send you report bug.

My phone : nexus 4 on Android 4.4.4.

Like you say, the problem seem due to an api update between android 4.2 and 4.4.

Thank in advance

Can not enable the OcSms app because the App Framework App is disabled

I installed ocsms on my Owncloud 7.0.4 (https = on). PHP Version is unknown.

I get following error: "Can not enable the OcSms app because the App Framework App is disabled"

This is an excerpt of the owncloud.log

...
$
{"reqId":"54c5ed6866f25","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:52+00:00","method":"POST","url":"/owncloud/index.php/core/ajax/translations.php"}
{"reqId":"54c5ed6903c0b","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:53+00:00","method":"GET","url":"/owncloud/index.php/apps/files/ajax/getstoragestats.php?dir=%2F$
{"reqId":"54c5ed69400a2","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:53+00:00","method":"GET","url":"/owncloud/index.php/core/ajax/share.php?fetch=getItemsSharedStat$
{"reqId":"54c5ed6c278f9","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:56+00:00","method":"GET","url":"/owncloud/index.php/settings/help"}
{"reqId":"54c5ed6cb4dc2","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:56+00:00","method":"GET","url":"/owncloud/index.php/core/js/oc.js?v=4d742f3ec26b3bafbc63c30655d2$
{"reqId":"54c5ed6d41012","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:57+00:00","method":"POST","url":"/owncloud/index.php/core/ajax/translations.php"}
{"reqId":"54c5ed6e9b0e0","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:58+00:00","method":"GET","url":"/owncloud/cron.php"}
{"reqId":"54c5ed6ec0da2","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:58+00:00","method":"POST","url":"/owncloud/index.php/core/ajax/translations.php"}
{"reqId":"54c5ed6f09cf2","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:59+00:00","method":"GET","url":"/owncloud/index.php/avatar/thomas/32?requesttoken=93a92c6e164187$
{"reqId":"54c5ed6fc9463","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:31:59+00:00","method":"GET","url":"/owncloud/index.php/avatar/thomas/128?requesttoken=93a92c6e16418$
{"reqId":"54c5ed75d8e1d","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:05+00:00","method":"GET","url":"/owncloud/index.php/settings/admin"}
{"reqId":"54c5ed76f3381","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:06+00:00","method":"GET","url":"/owncloud/index.php/core/js/oc.js?v=4d742f3ec26b3bafbc63c30655d2$
{"reqId":"54c5ed777e6ea","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:07+00:00","method":"POST","url":"/owncloud/index.php/core/ajax/translations.php"}
{"reqId":"54c5ed791ca97","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:09+00:00","method":"GET","url":"/owncloud/cron.php"}
{"reqId":"54c5ed7944468","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:09+00:00","method":"POST","url":"/owncloud/index.php/core/ajax/translations.php"}
{"reqId":"54c5ed797fd4a","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:09+00:00","method":"GET","url":"/owncloud/index.php/avatar/thomas/128?requesttoken=93a92c6e16418$
{"reqId":"54c5ed79de359","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:09+00:00","method":"GET","url":"/owncloud/index.php/avatar/thomas/32?requesttoken=93a92c6e164187$
{"reqId":"54c5ed7a5e95c","app":"ocsms","message":"Can not enable the OcSms app because the App Framework App is disabled","level":3,"time":"2015-01-26T07:32:10+00:00","method":"GET","url":"/owncloud/index.php/settings/ajax/checksetup"}
...

[bug] Synced Conversations splitted in two

Server

ownCloud version: 7.0.6
PHP version: 5.4
HTTPd server: NGINX
HTTPS: Y

Client

Android version: 4.3.2
Phone: Samsung GS2
ownCloud SMS app version: latest up2date

Like i said in here : #1 (comment)
I have a few more problems about sync : the first one is that the large conversation that I have by text message with my GF are split in two. The first part is her talking, the second, in a second conversation, is mine.

ownCloud.log is flooded with errors and it doesn´t sync

Issue template

Server

ownCloud version: 7.0.2
PHP version: PHP 5.3.10-1ubuntu3.15 with Suhosin-Patch (cli) (built: Oct 29 2014 12:19:04)
HTTPd server: ?
HTTPS: yes (trusted)

Client

Android version: 4.4.4
Phone: Google Nexus 5
ownCloud SMS app version: 0.15.3

{"app":"core","message":"Invalid OCS content returned for app ocsms","level":4,"time":"2014-11-02T01:31:16+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:22+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:50+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:53+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:31:57+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:32:17+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:32:17+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#60","level":3,"time":"2014-11-02T01:32:17+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#64","level":3,"time":"2014-11-02T01:32:17+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#68","level":3,"time":"2014-11-02T01:32:17+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:32:18+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:32:18+00:00"}
{"app":"PHP","message":"Call to a member function getContacts() on a non-object at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#92","level":3,"time":"2014-11-02T01:32:18+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:32:43+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:32:43+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:32:44+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:32:44+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:32:44+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:32:44+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:33:00+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:33:00+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#60","level":3,"time":"2014-11-02T01:33:00+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#64","level":3,"time":"2014-11-02T01:33:00+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#68","level":3,"time":"2014-11-02T01:33:00+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:33:01+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:33:01+00:00"}
{"app":"PHP","message":"Call to a member function getContacts() on a non-object at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#92","level":3,"time":"2014-11-02T01:33:01+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#60","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#64","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#68","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Call to a member function getContacts() on a non-object at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#92","level":3,"time":"2014-11-02T01:36:41+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:42:43+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:42:43+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#60","level":3,"time":"2014-11-02T01:42:43+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#64","level":3,"time":"2014-11-02T01:42:43+00:00"}
{"app":"PHP","message":"Cannot modify header information - headers already sent at \/var\/www\/owncloud\/lib\/private\/appframework\/app.php#68","level":3,"time":"2014-11-02T01:42:43+00:00"}
{"app":"PHP","message":"Undefined variable: this at \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php#51","level":3,"time":"2014-11-02T01:42:44+00:00"}
{"app":"PHP","message":"Argument 5 passed to OCA\\OcSms\\Controller\\SmsController::__construct() must be an instance of OCA\\OcSms\\AppInfo\\OcSmsApp, null given, called in \/var\/www\/owncloud\/apps\/ocsms\/appinfo\/ocsmsapp.php on line 51 and defined at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#29","level":3,"time":"2014-11-02T01:42:44+00:00"}
{"app":"PHP","message":"Call to a member function getContacts() on a non-object at \/var\/www\/owncloud\/apps\/ocsms\/controller\/smscontroller.php#92","level":3,"time":"2014-11-02T01:42:44+00:00"}

Please fix all of them.

Conversations divided in 2 conversations

some conversations are cut in two "conversations": one contains all words sorted by contact, and the other contains my words. The apparent phone number changes: the contacts phone numbers begin with +33 (french indicative, it's normal my contacts are as french as I am), and the other conversation begins with +49 (Germany??), followed with the right phone number.

All my OC zone parameters are France or Paris.

Thanxx

Allow two-way sync

Enhancement

Add an option to allow downloading the conversations from the server and syncing them on the phone - I just upgraded and it would be nice to sync all my old conversations.

contacts photos mixed

Hello!
With the new (and excellent) 1.3.6 version, I have a little issue: some sms are matched with the photos of contacts stored on OC contact functions.

But they are mixed.... For most of them, photos don't match with the right author of conversations

Feature-request: sending sms from ocsms app

Hello,
Since you've asked for it, i might have a feature idea :
Why not add a prompt to send sms from owncloud to your cellphone ? Kind of a 2-way sync between the apps.

sql error "added" || "lastmodified"

values "added" || "lastmodified" in sql is zero "0000-00-00 00:00:00"

Add a delete button to delete messages or converstions

As it is today you can only read messages. But it should also be possible to delete:

Whole conversations
Separate SMS

The most simple soulution would be to use the svg-icon that ownCloud uses to delete things. Of course this should be synced with Also sync deleted messages with 2-way sync

Cropped text messages from iOS.

Hey,
when I get sms from iphone with emoticon, on page appears only text in front of emoticon.
Regards
Torer

android app: 0.16.0
owncloud: 7.0.4-3
ocsms: 1.3.2

Ability to deal with contacts with multiple numbers

It would be very useful to be able to deal with multiple numbers from a single contact, either in a single thread (but marked per number), or let the user have a choice whether to combine these messages.

Ability to store delivery information and dates

At present the app seems to merely record a single timestamp for each message.

It would be good for incoming and outgoing messages to store: 1) sent timestamp, 2) received timestamp, 3) delivery status.

For incoming messages this information is static. Obviously for outgoing messages, the delivery status is dynamic, and the timestamp is not marked until it has been delivered (or not).

This information would enable users to properly archive messages and conversations.

Version 1.4.2 shows as 1.4.1

appinfo/info.xml should read

<?xml version="1.0"?>
<info>
    <id>ocsms</id>
    <name>ownCloud SMS</name>
    <description>A app to sync SMS with your ownCloud</description>
    <licence>AGPL</licence>
    <author>Loic Blot</author>
    <version>1.4.2</version>
    <requiremin>7</requiremin>
</info>

phone numbers are not matched with contacts if formatted differently

The contact is matched only if the phone number is formatted exactly as in the sender of the sms. Otherwise the phone number is displayed as sender/receiver, not the contact name.

The sms phone number and the contact phone number should be converted to the same format (no spaces) and then compared to match the Contact.

No content in web apps

Hi,
I have no conversation or message in web apps, but if I look ocsms_smsdatas mysql table, all info are present without apparent error (user_id is good). If you are a idea, you're welcome.

Server
ownCloud version: 7.0.2
ownCloud SMS app version: 1.1.0
PHP version: 5.5.9
HTTPd server: Apache 2.4.7
HTTPS: Apache 2.4.7

Client
Android version: 4.2.2
Phone: Wiko Rainbow
ownCloud SMS app version: 0.15.2

Friendlier error message when ocsms app is not installed on server

Hi,

it may seems dumb, but I stucked because of the error:
Error #15: Unable to parse server response

As I downloaded and installed from f-droid, I missed the server part. If it is possible, an error message precising that the server app part is missing may save some time.

Fails to load conversations (Contact not found [404])

Hi,

I really like the idea of your extension/app, but I'm having some troubles with it.
The ownCloud-side app fails to load conversation list and throws exception:
Exception: Contact not found [404]

Messages are being pushed to server correctly.

I've noticed that in database (column sms_address) addresses are stored differently. Some are being stored with whitespaces (ex. +380 11 222 3333) and some without (ex. +380112223333).
Sometimes my mobile operator sends SMS notification and uses it's name "Kyivstar" as sender ID instead of phone number.

I've tried deleting operator's messages from phone and DB and removing whitespaces from phone numbers, but it didn't help.

Contacts are synced between phone and ownCloud using DAVdroid.

Error PHP Undefined offset: 0 at /var/www/owncloud/apps/contacts/lib/backend/shared.php#90

This error shows up in log when getting information about the contacts in ownCloud. Related to ownCloud SMS. I think it could be the photos that trigger this. It spams my log so hard that the server almost stops, and my server is quite powerful. When I deactivate ownCloud SMS the error stops.

Error   PHP Undefined offset: 0 at /var/www/owncloud/apps/contacts/lib/backend/shared.php#90    2015-02-18T23:53:09+00:00

@martin-rueegg Wanna hunt bugs? ;)

Already read messages don´t sync with server

Steps to reproduce

Get a SMS on your phone
Read it
Go to server
Message is unread.

This should be synced, but I guess that comes with the 2-way sync in 2.0?

Android App won't sync

Hello there,
Nothing logged on the server side, and the android apps simply says sync encountered errors and will be restored soon ... N.B. it's a poor translation of the french version of the message, but you get the idea :)
FYI :

Android 4.3.1 (Cyanogenmod 10.2-20131229-NIGHTLY-i9100)
Samsung GT-I9100

Server side :

ownCloud 7.0.2
nginx/1.6.2
PHP-FPM (5.4)

Add country code

Hello,

Please add South Africa (+27) to lib/countrycodes.php

Thanks.

Conversation not sorted by last message timestamp

I don't know if this is a feature or a bug, but the conversation appears to be more or less randomly sorted in the left pane's list in my installation of ocsms.

It would be more usefull to have the conversations with the more recent messages on top of the list.

Missing App from webview

Hi, just updated ocsms from 1.3 to 1.4 on my owncloud 7.0.4.
The application is listed and enabled in the application list, but my user is unable to access to it (it is not listed in the published apps for user).
Thank you

Not able to install: not allowed code in the App

Don't know whether it's caused by this app or a configuration problem, but it's better to be listed in README even it's a configuration problem.

The error message is

App can't be installed because of not allowed code in the App

Relavant log:

App "ocsms" is using a not allowed call "OC_L10N::". Installation refused.

Version 1.4.2 cannot be enabled in OC 8.0.0

i've tried to enable the app from /index.php/settings/apps and get No app name specified (see owncloud.log below).

Version info

Server

ownCloud version: 8.0.0 (ubuntu 8.0.0-5)
PHP version: 5.5.9-1ubuntu4.5 
HTTPd server: apache2 2.4.7-1ubuntu4.1 amd64
HTTPS: yes
ocsms version: 1.4.2 (displayed as 1.4.1)
Download: https://codeload.github.com/nerzhul/ocsms/zip/v1.4.2
Install Dir: /var/www/owncloud/apps2/ocsms-1.4.2

Client

Android version: n/a
Phone: n/a
ownCloud SMS app version: n/a

Content of /owncloud/data/owncloud.log

{"reqId":"be6169f4612840cd3ce78ccd3459dd35","remoteAddr":"80.238.130.55","app":"core","message":"Invalid OCS content returned for app ocsms","level":4,"time":"2015-02-12T06:43:15+00:00","method":"POST","url":"\/owncloud\/index.php\/settings\/ajax\/enableapp.php"}
{"reqId":"be6169f4612840cd3ce78ccd3459dd35","remoteAddr":"80.238.130.55","app":"core","message":"No app name specified","level":3,"time":"2015-02-12T06:43:15+00:00","method":"POST","url":"\/owncloud\/index.php\/settings\/ajax\/enableapp.php"}

Clean up bad practices in code

Some things while reading through the code:

https://github.com/nerzhul/ocsms/blob/master/appinfo/ocsmsapp.php#L82 : This is called a service locator pattern, do not use it, its an anti pattern. Instead just pass in an object that gets the stuff done for you, e.g. create a ContactService which has this method on it https://github.com/nerzhul/ocsms/blob/master/appinfo/ocsmsapp.php#L94 and pass it into the controller
https://github.com/nerzhul/ocsms/blob/master/controller/smscontroller.php#L58 : use OCP\IURLGenerator->linkToRoute('apps.ocsms.page', ['feed' => 'drafts']);
https://github.com/nerzhul/ocsms/blob/master/controller/smscontroller.php#L241 : use HTTP error codes instead of your ok flag. By default the 200 status code is set which means OK. 400 means error, you can specify it better by using 404 (not found) etc

Add support for US number format

I am having same issue as #13 but with US formatted phone numbers.

It is common in US to format numbers with parentheses and hyphen like (XXX) XXX-XXXX. This causes split listings in OCSMS, one matched to the contact (sender, with US format number) and the other listed as the 10 digit number with no formating (XXXXXXXXXX). This problem can be fixed by adding the phone number to contact without US formatting but it would be nice for the app to do this for you.

CSRF check failed

Hi,
when my phone try to sync with my server, my phone say :
Error #9 : Server set unhandled HTTP return code.

And my server say :
no app in context CSRF check failed

Server

ownCloud version: 7.0.3
PHP version: 5.5.9
HTTPd server: 2.4.7
HTTPS: yes

Client

Android version: 4.4.2
Phone: Wiko Rainbow
ownCloud SMS app version: 0.15.3

Unable to create new database entries

After dropping the two tables that were for OCSMS it seems that the app cannot recreate them.
Instructions for updating would be helpful, and a method to fix this would be awesome. :P

No time stamps are added in MySQL

I just noticed that there is no time stamps in MySQL. This will lead to that the SMSes are not in order.

Using master-build, and latest Android App.

nextcloud / ocsms Goto Github PK

ocsms's Introduction

Phone Sync (for Nextcloud & ownCloud)

▶️ Access

❓ Solve encoding errors on MySQL

❓ Solve InnoDB 'Index column size too large' error on MySQL

❓ Solve the synchronisation issues

❓ Using the Android App With 2FA Enabled

👀 Screenshot

🔗 Requirements

❗ Reporting issues

📓 License

📓 External Libraries

ocsms's People

Contributors

Stargazers

Watchers

Forkers

ocsms's Issues

PREFIXocsms_config

PREFIXocsms_smsdatas

PREFIXocsms_user_datas

Issue template

Steps to reproduce

Version info

Server

Client

Content of /owncloud/data/owncloud.log

Recommend Projects

Recommend Topics

Recommend Org