nextgeoss / ckanext-kpis Goto Github PK

The repo should have an AGPL-3.0 license.

The number of Total Datasets in the kpis page in Total Datasets tab displays wrong number of datasets that are available in the portal

The dataset count displayed by CKAN at {site_url}/dataset and anywhere else the count is derived in the same way only counts datasets that the user has the right to see. For example, the user is annonymous and there are 5 public and 5 private datasets, the count displayed will be 5. An admin user would see count == 10. The dataset count also (as one would expect) does not include datasets that are in the trash ({site_url}/ckan-admin/trash).

The dataset count for the KPIs just counts datasets created – datasets deleted, regardless of whether they're public or private or restricted to members of certain groups.

The dataset count for the KPIs also doesn't filter out datasets with status == deleted.

As a result, if there are 5 public and 5 private datasets with active status and 1 dataset (with deleted status (that still hasn't been purged):

• An annonymous user would see 5 datasets on the site but see a total KPI dataset count of 11
• An admin user would see 10 datasets on the site but see a total KPI dataset count of 11

Two questions:

1. Should the KPI dataset count default to public datasets only, or public+private?
2. How should we treat deleted-but-not purged and purged datasets? If we're really charting the weekly dataset count, then it should be possible to keep the count consistent as things change. For example, if the count is 10 in week 1 and 5 in week two because 5 datasets were deleted, we should see counts equal to 10 and 5, respectively. But if purging a dataset can remove it from the count entirely, then we might end up with counts equal to 5 and 5, respectively. The final count would be correct, but the picture of how we arrived at the final count would be wrong.