Hi everyone,

Just a few comments on what is working/ready in detsim from my point of view in this first "version" that I've added you all to.

The only executable script (city-like based on FANAL/Olivia) is position_signal.py which is written with the idea of reading the full simulation output of nexus and sorting the information into buffers. It does essentially what the full simulation mode of the C++ based detsim did with the addition of being able to split a long G4 event into multiple buffers under certain circumstances.

The simulation/buffer_functions functions are the main tools used to do this. In that file there are a few suboptimal things (that I know of but probably others). The trigger_finder function maybe needs to have a different name and currently only looks for samples above a threshold which is maybe a bit too simple. I need to check with more data to see where the fail modes are. Then on a more stylistic front, the calculate_buffers function which is the final step is overly long and complicated and needs to be refactorised.

There are some bits of code written that are not currently in use:
In utility_functions there's a function to allow scaling of the signal for when tuning. I haven't got round to adding this option into the executable though.

There are a few functions related to the old style parameterisation in scintillation_functions.py but since the current thinking is to wait I haven't developed the more.

I'd appreciate people taking a look when they get a chance before developing much more but understand that there's a fair amount of code to assess.

Cheers,

A