Giter VIP home page Giter VIP logo

Comments (12)

micobarac avatar micobarac commented on September 21, 2024 1

I have tried the 1.2.0 version from NPM and it works like a charm.

Thanks a lot.

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

Yes, makes sense. While TranslateService is provided in the root, the lazy module makes a copy of HttpClientModule and corresponding providers if any.

Thanks for reporting, I will try to fix this issue and move HttpClientModule to the app level.

from translate.

micobarac avatar micobarac commented on September 21, 2024

As the library requires that HttpClientModule should be imported in app.module.ts, HttpClientModule imports should be removed from all the internal files.

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

@micobarac the unit tests are fine, those need to import HTTP module into the TestBed. Feel free to check this PR and see if that fixes your issue: #15

from translate.

micobarac avatar micobarac commented on September 21, 2024

@DenysVuika I have tried the commit you suggested and it still doesn't work.

My HttpInterceptor provided inside app.module.ts still doesn't fire.

I think that you haven't removed HttlClientModule from all files but app.module.ts. Can you please check it again? Thanks.

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

The 1.2 is not published to NPM yet. I removed the file from module but leaving in unit tests, those have nothing to do with your application.

from translate.

micobarac avatar micobarac commented on September 21, 2024

I added the latest commit from the git repository, not from NPM.

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

I may need some example to reproduce the issue. So far the library code has no direct imports of the HttpClientModule if you check the repo.

from translate.

micobarac avatar micobarac commented on September 21, 2024

Perhaps I haven't imported the latest commit well. How do I do it with Yarn, using your Git commit with fix?

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

I am publishing 1.2.0 right now, you will be able to check in a while directly from NPM

from translate.

micobarac avatar micobarac commented on September 21, 2024

Ok, thanks :)

from translate.

DenysVuika avatar DenysVuika commented on September 21, 2024

1.2.0 is out: https://www.npmjs.com/package/@ngstack/translate/v/1.2.0

from translate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.