Comments (17)
I've also added a CHANGELOG.md file, which should be filled for earlier versions you've made.
from translate.
Planned but you can create a pull request instead of a fork.
from translate.
Can you please add me to collaborators as I do not have sufficient permissions to create pull request right now?
from translate.
Ah yes, sorry. I think easier would be to fork and then create a PR if everything works ok for you locally.
from translate.
I've already cloned your original project, as you've suggested, made changes and tested. All seems to work fine.
from translate.
I've created a new branch, with master unchanged.
from translate.
Shall I create a fork and do it all over again?
from translate.
You should be able to collaborate now, thanks.
from translate.
from translate.
You may need to accept invitation: https://github.com/ngstack/translate/invitations
from translate.
Ah, ok thanks :)
from translate.
I've pushed the new branch angular8 successfully. I hope it's ok.
from translate.
Thanks a lot! You can create a PR for the master, and I will try to review it as soon as possible
from translate.
In the root package.json there was a version 0.0.0. I've changed it to 1.2.2. I hope that was ok to change.
from translate.
The one that goes to NPM is here: https://github.com/ngstack/translate/blob/master/projects/translate/package.json
from translate.
I know that, I've upgraded also that one for the NPM, but this root one should reflect the latest version too. At least it's a good practice.
from translate.
I agree, thanks.
from translate.
Related Issues (20)
- Take browser culture into account
- Compile failed because of unknown pipe HOT 1
- Improvement suggestions HOT 6
- HttpInterceptor not triggering with lazy loaded modules HOT 12
- Problem with using parameters HOT 2
- Translations default to default language until language file is loaded HOT 2
- How do I extend TranslateService to add local storage support? HOT 1
- Is it possible to add languages and translations after initialisation? HOT 1
- Emit activeLangChanged always when activeLang is changed HOT 3
- Wrong version number HOT 1
- Angular 9 support? HOT 5
- Fallback language not loaded with unsupported active lang
- [QUESTION] Library-Monorepo problem HOT 5
- translate pipe transforming not working HOT 2
- Angular v13 support HOT 3
- Support MessageFormat
- Multiple files per language HOT 3
- Attribute directive
- Element text as an i18n key for attribute directive
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from translate.