Giter VIP home page Giter VIP logo

Comments (17)

micobarac avatar micobarac commented on September 27, 2024 1

I've also added a CHANGELOG.md file, which should be filled for earlier versions you've made.

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

Planned but you can create a pull request instead of a fork.

from translate.

micobarac avatar micobarac commented on September 27, 2024

Can you please add me to collaborators as I do not have sufficient permissions to create pull request right now?

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

Ah yes, sorry. I think easier would be to fork and then create a PR if everything works ok for you locally.

from translate.

micobarac avatar micobarac commented on September 27, 2024

I've already cloned your original project, as you've suggested, made changes and tested. All seems to work fine.

from translate.

micobarac avatar micobarac commented on September 27, 2024

I've created a new branch, with master unchanged.

from translate.

micobarac avatar micobarac commented on September 27, 2024

Shall I create a fork and do it all over again?

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

You should be able to collaborate now, thanks.

from translate.

micobarac avatar micobarac commented on September 27, 2024

image

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

You may need to accept invitation: https://github.com/ngstack/translate/invitations

from translate.

micobarac avatar micobarac commented on September 27, 2024

Ah, ok thanks :)

from translate.

micobarac avatar micobarac commented on September 27, 2024

I've pushed the new branch angular8 successfully. I hope it's ok.

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

Thanks a lot! You can create a PR for the master, and I will try to review it as soon as possible

from translate.

micobarac avatar micobarac commented on September 27, 2024

In the root package.json there was a version 0.0.0. I've changed it to 1.2.2. I hope that was ok to change.

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

The one that goes to NPM is here: https://github.com/ngstack/translate/blob/master/projects/translate/package.json

from translate.

micobarac avatar micobarac commented on September 27, 2024

I know that, I've upgraded also that one for the NPM, but this root one should reflect the latest version too. At least it's a good practice.

from translate.

DenysVuika avatar DenysVuika commented on September 27, 2024

I agree, thanks.

from translate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.