nhn / tui.code-snippet Goto Github PK

Version

1.5.0

Development Environment

Windows, Linux, Chrome, Firefox
Running the image editor using the latest releases of the color picker, image editor and code snippet.

Current Behavior

The code snippet script is sending usage statistics to www.google-analytics.com
Setting tui.usageStatistics = false right before or after loading the script does not prevent that.

Here is an example: https://fiddle.sencha.com/#view/editor&fiddle/2p07
You can see that it silently sends a request to https://www.google-analytics.com/collect?v=1&t=event&tid=UA-115377265-9&cid=fiddle.sencha.com&dp=fiddle.sencha.com&dh=color-picker if you inspect the network traffic.

Expected Behavior

Setting tui.usageStatistics to false should reliably disable Google Analytics completely! This is absolutely crucial as it is illegal to collect such data without user consent in the EU and other countries.

• There are Korean inside jasmine test files
• Need to change English

Version

v2.0.0

Development Environment

$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux bullseye/sid
Release:        unstable
Codename:       sid
$ node --version
v12.13.0

Current Behavior

[askdna@bebop-i5 tui.code-snippet master]$ git checkout v2.0.0
Note: switching to 'v2.0.0'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at fb0d71e Merge branch 'master' into production
[askdna@bebop-i5 tui.code-snippet (v2.0.0)]$ yarn install
yarn install v1.19.1
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
info fsevents@1.2.9: The platform "linux" is incompatible with this module.
info "fsevents@1.2.9" is an optional dependency and failed compatibility check. Excluding it from installation.
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 2.28s.
[askdna@bebop-i5 tui.code-snippet (v2.0.0)]$ npm run bundle

> tui-code-snippet@2.0.0 bundle /tmp/askdna/tui.code-snippet
> webpack & webpack --production

Hash: 451d148498b0218ba862
Version: webpack 1.15.0
Time: 13ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./src/js/index.js in /tmp/askdna/tui.code-snippet
Hash: 4cc2c8905467c5a2eeb0
Version: webpack 1.15.0
Time: 13ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./src/js/index.js in /tmp/askdna/tui.code-snippet
[askdna@bebop-i5 tui.code-snippet (v2.0.0)]$

Expected Behavior

I expect npm run bundle generates built result, but the build fails. Since d04b9cb commit removes the webpack entry file which is index.js, then webpack complains about that.

Version

2.3.2

Development Environment

iOS Chrome

Current Behavior

• iOS Chrome userAgent
  • Mozilla/5.0 (iPhone; CPU iPhone OS 13_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/84.0.4147.122 Mobile/15E148 Safari/604.1
• codesandbox test code

// browser result
chrome : false,
....
others : true,
version : 0

Expected Behavior

// browser result
chrome : true,
....
others : false,
version : 84

Can we cut a new release of this? I'd like to see tui-calendar use a version of this library that includes the fix in #27, and that hasn't yet made it to a released version.

Version

2.3.2

Development Environment

MacOS 10.15.6
Chrome 84.0.4147.135

Current Behavior

toast-ui color-picker를 web components로 만들어서 사용할 때 아래와 같은 문제가 발생.

palette 영역 클릭 시, getTarget 함수가 e.target을 반환하는데, 이때 target이 palette 영역이 아닌 web component가 반환되어, click에 대한 이벤트핸들러에서 오류가 발생
(lotstar87/twc-color-picker#1)

// domEvent/getTarget.js
function getTarget(e) {
  return e.target || e.srcElement; 
}

Expected Behavior

getTarget 함수가 e.composedPath()[0]을 반환하도록 변경

// domEvent/getTarget.js
function getTarget(e) {
  return e.composedPath()[0];
}

• Major update
• remove HashMap class

1. path의 순서와 상관없이 동작해야 한다.

defineNamespace('ne.util.common')
defineNamespace('ne.util')

1. 덮어쓰는 것을 기본으로

Version

Development Environment

Current Behavior

A module with a potential security vulnerability is found on package-lock.json file.
This module is marked related to jsdoc and this module's version should be updated.

Reference :

• https://nvd.nist.gov/vuln/detail/CVE-2017-17461
• https://nvd.nist.gov/vuln/detail/CVE-2017-1000427

Expected Behavior

Remove node_modules folder and package-lock.json file on local environment.
Install all packages and confirm to update version of marked on package-lock.json.

참고: underscore

Version

latest

Development Environment

All

Current Behavior

browser() occurs an error in Node.js

// ReferenceError: window is not defined
if (window && window.navigator) {
  detectBrowser();
}

Expected Behavior

If browser() runs in Node.js, do not execute detectBrowser().

Version

Development Environment

Current Behavior

// Write example code

Expected Behavior

• nhnent -> nhn

Version

Update a major version

Development Environment

Current Behavior

// Write example code

Expected Behavior

• Separate functions into individual files
• Add/Remove some functions

Version

v2.3.0

Development Environment

Internet Explorer 8

Current Behavior

Expected Behavior

Do not access xhr.status before xhr.readyState becomes 4 (=DONE)

아래의 버그가 있음.

1. 특정 상황에서 off(context, type) 이 context를 구분하지 않고 모든 이벤트를 제거
   👉 context에 해당하는 type 의 이벤트만 제거해야 함
2. '_play' 이벤트와 'play' 이벤트를 등록하고 off('play') 실행 시 모든 이벤트를 제거
   👉 _play 이벤트는 제거하지 않아야 함

There are any plans to register this library at https://cdnjs.com/ to use it via CND. Same as tui-editor and tui-calendar

// current condition
isValidYear = (year > -1 && year < 100) || ((year > 1969) && (year < 2070));

Fix condition for formatting over 2070 years

Version

1.3.0

Development Environment

ALL

Current Behavior

1. The every tui components make duplicated request image ping multiple times.
2. The every tui components have to have an option for it.(usageStatistics)
   • It can be set on global space

Expected Behavior