nhsx / antibody-web Goto Github PK

OS: Mac Catalina 10.15.2
Branch: Master (Latest - 08/06/2020)

In the middle of trying to run the antibody-web client by following the README.md.

Currently getting the following error 'Command "dev" not found.' From looking in the package.json looks like you are missing the dev script

"scripts": { "build": "node_modules/.bin/rimraf dist && tsc", "test": "node_modules/.bin/jest" }

Not sure if this is intentional, but I was wondering if the README.md needs updating. README.md currently states the following:

Running the service locally

Create your client/.env file - rename example.env -> .env for local development

yarn dev

Runs the front and back end app in development mode. This will run serverless in offline mode, and you will hit localhost endpoints.

File:client/src/components/TestRun/ContentComponent/ ReportKit.tsx
Line: 26

See full details here (gitHub login required, no need to enable any repos for review at first): https://www.deepcode.ai/app/gh/nhsx/antibody-web/cf6264b4adb7f795ea5e23ef367ac34e951383ba/_/%2Fclient%2Fsrc%2Fcomponents%2FTestRun%2FContentComponent%2FReportKit.tsx/javascript%2Fdc%2FReactMissingArrayKeys/26/code
and how 2606 other repos have already fixed that.

More details on the problem are explained here: https://reactjs.org/docs/lists-and-keys.html

There are 2 other suggestion detected: https://www.deepcode.ai/app/gh/nhsx/antibody-web/cf6264b4adb7f795ea5e23ef367ac34e951383ba/_/dashboard
-"No catch method for promise. This may result in an unhandled promise rejection."
-"for in loop is looping over all property names of this object, including properties defined in super classes. Consider filtering out only the own properties of the object by using hasOwnProperty."

as of terraform 12, only string interpolation actually needs "${...}" syntax, and while this currently just throws a warning in the console, in future versions of terraform it will become an error.

I'm happy to submit a PR to clean up a few of the unnecessary usages of "${...}"in the tf files, just wanted to confirm that terraform 12+ is being used, otherwise better to leave as is.