Comments (1)
I hear ya! Review overload sucks. It's something that Dev Efficiency and the Software Discipline have been and are still addressing, especially in drivers.
Note however: If you are added to a review as an owner, alternate, or reviewer -- in other words, you're listed in an niconfig file -- your approval is required 100% of the time. Alternatively, you may be removed/declined from the review by another owner/alternate/review (but not the code author). Alternatively, a tech lead can "vouch" for the changes and bypass the owner review process (a process that is currently specific to AzDO). Either way, your approval or removal is required for the review to complete and for the code to go in. It is further expected that you reply within 24 business hours (with at least a comment of any sort). All DevCentral Git repos have tooling to remind reviewers to do their reviews if over a day has passed.
For more info on this policy, see this doc.
I also understand that this policy hasn't been communicated equally among teams onboarding to niconfig. I know @zhindes will have more on this topic very soon, including curating the various docs we have on this topic. Here's some preliminary comms on this topic.
Because your review is required, sorting the dashboard based on your specific role (owner/alt/reviewer) is not necessary, because all reviews have the same requirement to complete. Furthermore, all reviews -- regardless of whether you're listed in an niconfig file for the review -- have the 24 business hour expectation for first response.
If you'd like to chat more about the policy, let's sync up on Teams. Afterward, if you believe you still want this feature, let's reopen the issue, easy :)
from reviewboard-userscripts.
Related Issues (20)
- Change draft review header color to yellow/orange HOT 3
- Long review comments give overly wide summary boxes when you click OK HOT 1
- Review information sidebar needs to be reorganized HOT 2
- Somehow include issue count in the person's approval
- With no incoming requests, counter can still say 1
- Diffs associated with comments on Reviews page overrun the width of the main column HOT 5
- A .niconfig reviewer gave a Ship It but it is only reflected in Reviewers, not Note to Reviewers HOT 3
- Diff scrollbars and word wrap
- For screenshots, horizontal scrollbar only visible at bottom of the image HOT 2
- See if requests have issues directly from the dashboard
- Button to "ping" reviewers HOT 1
- Links for all comments
- Odd repetition of date with new display HOT 1
- Review in inbox even after user removed HOT 1
- Re-organization of my dashboard is applied to Outgoing reviews HOT 1
- Link formatting with inline code is broken
- Edit pencil is missing for main description
- Use the NI JS styleguide
- Empty outgoing review list tallies 1 for Incomplete HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewboard-userscripts.