Giter VIP home page Giter VIP logo

Comments (1)

alejandro5042 avatar alejandro5042 commented on September 25, 2024

I hear ya! Review overload sucks. It's something that Dev Efficiency and the Software Discipline have been and are still addressing, especially in drivers.

Note however: If you are added to a review as an owner, alternate, or reviewer -- in other words, you're listed in an niconfig file -- your approval is required 100% of the time. Alternatively, you may be removed/declined from the review by another owner/alternate/review (but not the code author). Alternatively, a tech lead can "vouch" for the changes and bypass the owner review process (a process that is currently specific to AzDO). Either way, your approval or removal is required for the review to complete and for the code to go in. It is further expected that you reply within 24 business hours (with at least a comment of any sort). All DevCentral Git repos have tooling to remind reviewers to do their reviews if over a day has passed.

For more info on this policy, see this doc.

I also understand that this policy hasn't been communicated equally among teams onboarding to niconfig. I know @zhindes will have more on this topic very soon, including curating the various docs we have on this topic. Here's some preliminary comms on this topic.

Because your review is required, sorting the dashboard based on your specific role (owner/alt/reviewer) is not necessary, because all reviews have the same requirement to complete. Furthermore, all reviews -- regardless of whether you're listed in an niconfig file for the review -- have the 24 business hour expectation for first response.

If you'd like to chat more about the policy, let's sync up on Teams. Afterward, if you believe you still want this feature, let's reopen the issue, easy :)

from reviewboard-userscripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.