The default view of information looks like this:

With the userscript it looks like this:

The most glaring issue is that the Reviewers label seems completely out of place.

Is your feature request related to a problem?

I'd like the ability to easily link to any arbitrary review comment. Currently, clicking an issue in the issues list for a review will link to (and highlight, but that's less important) the relevant comment. I'd like to have a way to link to specific comments without having to inspect the page source and find the comment ID myself.

Describe the solution you'd like

For comments on issues, make the timestamp text a link to the issue:

For issues, add some element to each issue which is also a link to the comment. The timestamp doesn't make as much sense here since all of the issues from one review will have the same timestamp, but it may be worth having for consistency.

Describe alternatives you've considered

None.

Additional context

Add any other context or screenshots about the feature request here.

NI has an official JS style guide that is in-work, based on Airbnb. We should upgrade to use it:

https://github.com/ni/javascript-styleguide/

It makes sense to organize my incoming reviews around whether I have responded or given a ship it, but this doesn't make sense for outgoing reviews. I did try removing the 'My Comments' column in the Outgoing view, but apparently this setting is global, since it was also then removed from the Incoming view.

Screenshots

Context

• Extension Version: 2.42.0
• Browser: Google Chrome Version 83.0.4103.116 (Official Build) (64-bit)
• URL: https://review-board.natinst.com/dashboard/?view=outgoing

Is your feature request related to a problem?

Since I recolored submitted reviews to green, there is now a conflict with the existing green banner representing a draft review.

Describe the solution you'd like

Color the draft review banner yellow.

Describe alternatives you've considered

Reverting the green back to gray, but it should be green to better match AzDO and societal expectation of what green means (success).

Additional context

Userscript version: v1.1.10

With this script enabled, there's no distinguishable link formatting for links that are also code segments. Example markdown:

[`boost::none`](https://www.boost.org/doc/libs/1_74_0/boost/none.hpp)

Screenshots

With the script disabled/enabled:

Logs

None

Context

• Extension Version: 1.18.1
• Browser: Firefox 79.0 (64-bit) for Windows
• URL: None

In Firefox 76.0.1 on Windows, the dashboard (incoming review list / default landing page) doesn't take up the full windows width that it does without the plugin (seems optimized for mobile?), and the far right status column is cut off by the scrollbar. See screenshot. This is all if you have not enabled the My Comments column.

Workaround

Follow the instructions on the nag dialog about dashboard sorting by adding the My Comments column. With the My Comments field added, the width rendering becomes more sane. If you don't have that field enabled, it will nag you on every reload and have the messed up width. If you remove that column, the problem will come back.

Screenshots

If applicable, add screenshots to help explain your problem.

Nag dialog:

Comparison of workaround after adding the sortability "My Comments" column:

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.

Context

• Extension Version: 1.1.2
• Browser: Firefox 76.0.1 64-bit on Windows 10 v1809 64-bit,
• URL: N/A

I have a minor bug report with the new extension: I'm seeing an "Incomplete" count of (1) even though I have no incoming requests. See screenshot below. (This is in Firefox if that matters)

Screenshots

Context

• Extension Version: ?
• Browser: Firefox
• URL: Dashboard

In a current review, the latest Linux prebuild run suceeded, yet it still shows an X in the meta-data

For some reason, the latest prebuild reviews are not being parsed as build results.

Context

• Extension Version: v1.1.10
• Browser: Chrome
• URL: https://review-board.natinst.com/r/337119/ (NI Internal)

I can't see the full width of the diff associated with a comment on the Reviews page of a review. It wraps sometime later, but I can't see the full file path or the rightmost part of the diff.

Screenshots

I'm wondering if it's related to this rendering oddity where the comments are narrower than the review summary:

Context

• Extension Version: 1.4.0
• Browser: Chrome 83.0.4103.97 (Official Build) (64-bit)
• URL: https://review-board.natinst.com/r/329115/

The dark theme uses a midnight blue / inky color but the categories view in the RB dashboard for what review groups you belong to are still rendered in black, so they are almost impossible to read as dark text on a dark background unless you zoom way in.

Screenshots

Screenshot has group names censored, but the Incoming categories "Open" and "To Me" show the problem just as well. Not sure why we have weird negative counts in some cases but I don't believe it's anything to do with this userscript.

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
N/A

Context

• Extension Version: 1.1.2
• Browser: Firefox 76.1
• URL: outgoing RB dashboard

Is your feature request related to a problem?

No

People aren't reviewing my code fast enough.

Describe the solution you'd like

A button like we have in AzDo to remind them to review my code.

Describe alternatives you've considered

None

With the new "intelligent" timestamp display I'm seeing some... less-than-intelligent displays 😄

Screenshots

If applicable, add screenshots to help explain your problem.
.

Context

• Extension Version: 1.18.0
• Browser: Chrome 83.0.4103.97
• URL: (if any)

When viewing incoming reviews, if I select a review and archive/unarchive it, the page stops filtering reviews until I refresh the page. Is this a known limitation? I see a text box pop up that says "When you are done changing/rearranging columns, reload the page to refresh the review list", but I'm archiving reviews, not rearranging columns.

We should change the text or be able to handle a review being archived/unarchived.

Context

• Extension Version: v1.1.10
• Browser: Chrome

When leaving a comment to a review, if you have a longer string (multi-line? Not sure if it' sa character cutoff or line thing), the summary box shown after you click OK but before you click Publish/Discard/Close will get really wide and shift to the right, regardless of your setting for review with to be optimized for readability or full width (original)

Steps to reproduce:

1. On an active review, click the Review button at the top to get a dialog box prompt
2. Enter a long comment in there which spans at least 2 lines
3. Click OK to preview the comment before publish/discard/close

Screenshots

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.

Context

• Extension Version: 1.4.0
• Browser: Firefox 76.0.1 on Win 10 x64 1809

Is your feature request related to a problem?

Yes. Review overload. My team gets a lot of reviews (as I'm sure most teams do). In our retrospective, most people expressed wanting to be alerted to the reviews, but also want to be able to sort reviews that they have to review vs reviews where they are optional.

Describe the solution you'd like

Be able to sort reviews on the reviewboard mainpage based on whether you're an owner, an alternate, or a reviewer.

Describe alternatives you've considered

An email rule that flags a reviewboard email if you're an owner.

The edit pencil is missing for the main description. This includes when initially adding the review, and double clicking doesn't always enable editing.

Screenshots

With script enabled

With script disabled

Logs

Context

• Extension Version: 1.18.1
• Browser: New Microsoft Edge: Version 84.0.522.61 (Official build) (64-bit)
• URL:

(Tracking the work I did here in this issue.)

I have zero outgoing reviews open in RB, but counter on the Outgoing dashboard shows incomplete 1.

Screenshots

Comparing Chrome with no extension to Firefox with this extension

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.

Context

• Extension Version: 1.18.1
• Browser: Firefox 82.0.2 (64-bit)
• URL: .../dashboard/?view=outgoing

rossh is a Reviewer and gave a Ship It, but the Note to Reviewers doesn't have a check next to his name, even though it is there in the Reviewers section on the right-hand side

Screenshots

Context

• Extension Version: 1.12.4
• Browser: Chrome 83.0.4103.61
• URL: https://review-board.natinst.com/r/337938/

I was removed (declined) from a review by another reviewer/alternate, but the review still appears in my incoming list. I assume that if I've been removed from the review, I wouldn't still need to see it in my incoming list.

In this review: https://review-board.natinst.com/r/339057/
Valerie Juarez declined jdowns (out of office) on June 15, but on June 17, I still see the review in the Incomplete bucket of the incoming review list.

When viewing a large screenshot, both vertical and horizontal scrollbars are always visible. However, with this user script, only the vertical scrollbar is visible at all times; the horizontal scrollbar is only visible when you scroll to the bottom of the image.

Screenshots

Without userscript, both scrollbars are always visible:

With userscript, only vertical scrollbar is visible at first:

...but when I scroll to the bottom of the image, the horizontal scrollbar is also visible.

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.

Context

• Extension Version: 1.4.0
• Browser: Google Chrome Version 83.0.4103.61 (Official Build) (64-bit)
• OS: macOS 10.14.6
• URL: https://review-board.natinst.com/r/338456/s/211667/

On a 4k monitor, using Firefox, the 'My Dashboard' window does not scale to fit the whole window width, making it hard to read.

Screenshots

Logs

If applicable, add any relevant messages or errors you see in the browser's JavaScript console.

Context

• Extension Version: (found in the userscript dashboard)
  TamperMonkey running script v1.1.2

• Browser: (name and version)
  

• URL: (if any)

As an overloaded code owner, I would like a way to automatically re-classify / re-prioritize reviews that have open issues from other reviewers, so that I can focus on the reviews that are ready for my attention.

Perhaps by adding a fourth category, in addition to "Incomplete", "Reviewed" and "Ship It!"

Kiran: if i give a ship it... then a fix it... on my dashboard the review shows up as in the "ship it" section. not sure if there is anything you can do about that, just FYI
Me: just by having open issues?
Kiran: yes

Context

• Extension Version: N/A
• Browser: N/A
• URL: https://review-board.natinst.com/r/337710/