nicklockwood / standardpaths Goto Github PK

i was thinking about using this library but it sort of appears that it is no longer being maintained, so when i went to roll my own solution i found myself wondering why you can't just do something like this and let NSBundle's internals take care of it (swift 3):

func normalizedPathForFile(_ path:String) -> String {
    let base = path.stringByDeletingLastPathComponent()
    let file = path.lastPathComponent().stringByDeletingPathExtension()
    let ext = path.pathExtension()
    return Bundle(path: base)?.path(forResource:file, ofType:ext) ?? path
}

in my testing i put files named "plugin~iphone.xml" and "plugin~ipad.xml" in the documents directory and called it like:
normalizedPathForFile("/full/path/to/documents/dir/plugin.xml")

and it found the correct files on both iphone and ipad

Edit: Doh, this is addressed in the README, but I still think exposing the option in the podspec is good.

It would be nice to make the swizzling on view loading and other places optional.
This could be done with a subspec in the podspec. I'm not sure if the subspec has to include the swizzling, or if it can exclude it.
Alternatively, the swizzling could be tied to a class method to set it all up - but that is a breaking change.

I'm seeing people get confused when they have IBOutlet key-value coding errors in their Interface Builder files and the exception pauses the debugger inside the StandardPaths source code - leading to accusations / rabbit holes before realising the error is in IB.

In iOS prior to 8.3:

/* The UI_USER_INTERFACE_IDIOM() macro is provided for use when deploying to a version of the iOS less than 3.2. If the earliest version of iPhone/iOS that you will be deploying for is 3.2 or greater, you may use -[UIDevice userInterfaceIdiom] directly.
 */
#define UI_USER_INTERFACE_IDIOM() ([[UIDevice currentDevice] respondsToSelector:@selector(userInterfaceIdiom)] ? [[UIDevice currentDevice] userInterfaceIdiom] : UIUserInterfaceIdiomPhone)

But in iOS 8.3:

/* The UI_USER_INTERFACE_IDIOM() function is provided for use when deploying to a version of the iOS less than 3.2. If the earliest version of iPhone/iOS that you will be deploying for is 3.2 or greater, you may use -[UIDevice userInterfaceIdiom] directly.
 */
static inline UIUserInterfaceIdiom UI_USER_INTERFACE_IDIOM() {
    return ([[UIDevice currentDevice] respondsToSelector:@selector(userInterfaceIdiom)] ?
            [[UIDevice currentDevice] userInterfaceIdiom] :
            UIUserInterfaceIdiomPhone);
}

As a result I can't build 😕 Errors in StandardPaths.h:

• (NSString *)heightSuffix in line 671 checks for suffix "h" but that means that it will return YES to xibs with name ending in h. (Eg. Path)

Should be checked if the detected h is preceded by a number or that the words until "/" have a dash "-".

I think the iOS version compare in offlineDataPath should be:
if ([[[UIDevice currentDevice] systemVersion] compare:@"5.0.1" options:NSNumericSearch] == NSOrderedAscending)
to allow version older than "5.0.1" to fallback to use /Library/Caches.

NSOrderedAscending == [@"5.0" compare:@"5.0.1" options:NSNumericSearch]
NSOrderedSame == [@"5.0.1" compare:@"5.0.1" options:NSNumericSearch]
NSOrderedDescending == [@"5.0.2" compare:@"5.0.1" options:NSNumericSearch]

The podspec has the key requires_arc set to false. I'm pretty sure this is wrong.

We don't have a test project integrating via pods. The FileSuffixesTest project has ARC on.

Hi there,

I'm using this library for an AppleTV project and seems the spec on the main Cocoapods for StandardPaths is out of dated, it will be nice if it could be updated.

Hello,

The docs say that for iOS5 the offlineDataPath will fall back to using Library/Caches/Offline Data.
However in the code it just returns [self cacheDataPath].

Is this a feature of the code or the docs ;-)

Thanks for sharing the code.
Regards,
Steven

Hi Nick,
Thanks for sharing this great component! When I read the code,

- (NSString *)temporaryDataPath
{
    static NSString *path;
    static dispatch_once_t onceToken;
    dispatch_once(&onceToken, ^{

        //temporary directory (shouldn't change during app lifetime)
        path = NSTemporaryDirectory();

        //apparently NSTemporaryDirectory() can return nil in some cases
        if (!path)
        {
            path = [[self cacheDataPath] stringByAppendingPathComponent:@"Temporary Files"];
        }

        //retain path
        path = [[NSString alloc] initWithString:path];
    });

    return path;
}

I don't know why need to add this line

//retain path
path = [[NSString alloc] initWithString:path];

Will you explain it a little bit more?

        NSString *url = @"http://www.example.com/image.jpg";

        NSLog(@"url: %@", url);
        NSLog(@"[url stringByAppendingScaleSuffix]: %@", [url stringByAppendingScaleSuffix]);
        NSLog(@"[url stringByDeletingLastPathComponent]: %@", [url stringByDeletingLastPathComponent]);

Output:
url: http://www.example.com/image.jpg
[url stringByAppendingScaleSuffix]: http:/www.example.com/[email protected]
[url stringByDeletingLastPathComponent]: http:/www.example.com

Function [NSString stringByDeletingLastPathComponent] removes second slash from http://.

It's possible to add NSURL functions to your category?

Hi Nick,

I think this is an issue, but it is the first time I have had to localise image resources so I might just be missing something.

If an image is localised then it is stored in Base.lproj, fr.lproj etc folders inside the MainBundle of the app.
All the lookup in normalizedPathForFile:ofType seems to be based on the resourcePath which is just got from the MainBundle. So it does not find then find any of the images when it gets with fileExistsAtPath:.

So it then eventually falls back to just the original filename for a normal image lookup.

I am happy to have a bit more of a poke around if you think this is a real issue.

Thanks,
Steven