nickurt / laravel-pwned-passwords Goto Github PK

Hi 👋

Laravel 8 has arrived this week, and when upgrading my application, noticed this package wasn't updated yet.

Are you currently looking at doing that? Would you like a pull request to add support?

Doesn't look like there's any significant changes, just a composer.json update to upgrade the dependency versions for laravel/framework and guzzlehttp/guzzle

Thanks

In your documentation you have this code snippet to show how to use this package as a validation rule:

public function rules()
{
    return [
        'password' => ['required', new \nickurt\PwnedPasswords\Rules\IsPwnedPassword(20)]
    ];
}

However if I do that I get this error in the latest stable release (1.2):

Symfony\Component\Debug\Exception\FatalThrowableError: Too few arguments to function nickurt\PwnedPasswords\Rules\IsPwnedPassword::__construct(), 0 passed in /var/www/app/Components/CommonApiValidationRules.php on line 101 and at least 1 expected in file /var/www/vendor/nickurt/laravel-pwned-passwords/src/Rules/IsPwnedPassword.php on line 27

if I look at the IsPwnedPassword.php class I see that it's requiring a password as the first argument with frequency being the second. When I compare it to your master I see that you have already fixed this file and I would imagine it works.

I am including this package via composer and am not able to include the latest dev master version of this package. Would you be able to create a new release or backport this fix to 1.2? That would be very much appreciated.

Thank you for your time! This is a very nice modern package.