nickurt / zf-bugsnag Goto Github PK

I noticed that you're setting the error/exception handlers in the sendException method of the bugsnag service, however, I believe this is only ever encountered when a dispatch.error is handled (or a user calls the method directly).

https://github.com/nickurt/zf-bugsnag/blob/master/src/ZfBugsnag/Service/BugsnagService.php#L46

The PHP error/exception handlers should probably be configured in the constructor of the service so that they can catch errors/exceptions thrown outside of the dispatch cycle.

I'm currently testing implementing this plugin in a ZF2 app, I'll try to submit a PR after I'm done with some testing.

Argument 1 passed to ZfBugsnag\Service\BugsnagService::sendException() must be an instance of Exception, instance of Error given, called in **vendor/nickurt/zf-bugsnag