"aria-controls" attribute on buttons about jquery-accessible-hide-show-aria HOT 7 CLOSED

Hello,

it can already be set up, at the beginning of the script:

    var attr_control = 'data-controls',
        attr_expanded = 'aria-expanded',
        attr_labelledby = 'data-labelledby',
        attr_hidden = 'data-hidden',

However, for "practical reasons" (especially on voice over, to avoid application mode if I remember well - ping @goetsu you will probably be able to explain why), it has been decided not to follow exactly the DP.

;)

from jquery-accessible-hide-show-aria.

I understand the reason but another accessibility expert, in an audit, told me to add "aria-controls", so...
I don't like to modify a library but if we have to... :-)

Thank you for your answer.

from jquery-accessible-hide-show-aria.

@juliemoynat you don't have to modify it because it's already something you can choose to add or not in the configuration ;)
@nico3333fr yes you remember well

from jquery-accessible-hide-show-aria.

In fact, if I remember well, for Voice over: if it detects certains ARIA attributes, it switches to application mode, and this mode implies more complicated keyboard combinations for the user.

As this component should be simple, this is why we set it up like mentionned before: it works without being more complicated for the users (difference between "accessibilité de terrain" - don't know how to say it in english and "accessibilité des référentiels").

However, your a11y expert and mine's are not wrong, it depends on the environment of the project and the point of view.

In a near future, I will rewrite this plugin in the same style of coding that the accordion one, allowing to pass a config on the call, and it should fix this issue without updating the code of the plugin.

from jquery-accessible-hide-show-aria.

Ok, so I was not so wrong about the fact that we have to modify plugin's code. Adding a variable will not just work, so we have to modify several lines of code (or maybe I'm wrong about the way I should do it...?).

from jquery-accessible-hide-show-aria.

At the beginning of the script, you need to replace

var attr_control = 'data-controls',

by

var attr_control = 'aria-controls',

that's all ;)

from jquery-accessible-hide-show-aria.

Ok!! So cool :-)
Thank you

from jquery-accessible-hide-show-aria.