nico3333fr / van11y-accessible-hide-show-aria Goto Github PK

Hi there,

It would be great to mention and demonstrate that this script might be used for dropdowns :)
As far as I understand, it should only be a style variant.

Thanks :)

This avoid problems in sharepoint and in forms

Hi @nico3333fr, I hope you're doing well :)

I have the same issue with this script as nico3333fr/van11y-accessible-modal-tooltip-aria#3 and nico3333fr/van11y-accessible-accordion-aria#6

I'm working on a PR.

At some point hopefully all the van11y scropts will be fixed ;)

Hi!
I'm using this script on a new project, and I faced an issue on Edge : It's not working there is an error in the console.

By going to the demo page with Edge :
https://van11y.net/downloads/hide-show/demo/index.html

0: van11y 'AccessibleHideShowAria' is not defined.

Updated Windows 10
Edge 44.18362
EdgeHTML 18.18

EDIT :
In my project (Gulp + Webpack with Babel etc.) I include the es6 file this is why I have the error, I think you also use this one on the demo.
By importing the simple .js file it's okay.

In https://van11y.net/downloads/hide-show/demo/index-fr.html if you click on "drop down" in the first example, it doesn't work on Chrome (works on Firefox).

Hi,

I'd like to implement this script, but my page already has a button with specific classes on it. How can I initialize the script and make it use the existing button, instead of creating a new button in a h* element?

Thanks

Your examples look nice, but they are failing the point of ARIA attributes completely. You link to the excellent inspiration, but the resulting markup is adding aria-expanded on the button instead of the expanded field. You're also not hiding the expandable in any way from screenreaders.

Current output code

<h2 class="js-expandmore" data-hideshow-prefix-class="animated">
  <button class="animated-expandmore__button js-expandmore-button" data-controls="expand_1ugacpb3ta" aria-expanded="true" id="label_expand_1ugacpb3ta" type="button"><span class="animated-expandmore__symbol" aria-hidden="true"></span>Example animated (opened by default)</button>
</h2>
<div class="js-to_expand animated-expandmore__to_expand" data-labelledby="label_expand_1ugacpb3ta" id="expand_1ugacpb3ta">
    <p>Yes, it rocks.</p>
 </div>

Because security/etc/

A main entry is missing from package.json:

missing main: https://github.com/nico3333fr/van11y-accessible-hide-show-aria/blob/master/package.json

has main: https://github.com/nico3333fr/van11y-accessible-modal-window-aria/blob/7e5d7b90c41d4990621e514b1669bf724fc68806/package.json#L5

The exclusion of the main key is causing webpack to throw an error: cannot resolve module van11y-accessible-hide-show-aria.

Thank you for all your work on this wonderful package.
Take care

TODO:

• scripts should work with webpack/gulp (with or without autoload),

• and "normal" guy which is not strong at JS should be able to take a built file (with or without autoload) and it works on a "classic" site.

• bonus: if we can move to gulp v4, this will be puuuurfect.

ping @dhoko