Giter VIP home page Giter VIP logo

contrast's People

Contributors

niklasbuschmann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

contrast's Issues

footer config option breaks post navigation

Hi Niklas,

the newly introduced footer config option breaks the post navigation. Maybe you can verify that and fix it? This also happens, when footer links are enabled the sidebar is enabled as well...

Best regards, Michi.

"Read more"?

One of the main reasons i chose to try out this theme was because on the screenshots it showed a part of the post, not all of it with a preview and allowed to "Read More".

Is there still any way to do it with Contrast? I've tried playing around with the amount of post per page, but that doesn't seem to change anything.

Liquid syntax error

Incremental build: disabled. Enable with --incremental Generating... Liquid Exception: Liquid syntax error (line 6): Tag '{%- assign date_format = site.date_format | default: "%B %d, %Y" -%}' was not properly terminated with regexp: /\%\}/ in _includes/meta.html, included in _layouts/post.html jekyll 3.1.6 | Error: Liquid syntax error (line 6): Tag '{%- assign date_format = site.date_format | default: "%B %d, %Y" -%}' was not properly terminated with regexp: /\%\}/

Above is the error i get when i run jekyll serve.

Sass Compilation Error in GitLab CI Pipeline

Hello,

I'm trying to use your Jekyll theme for my GitLab Pages site, but I'm encountering an issue when GitLab CI tries to build the site. The error occurs during the Sass compilation step and seems to be related to the use of Liquid syntax in the index.sass file.

Here's the error message I'm seeing:

Error: Expected newline.
  ╷
8padding: 1.75em calc(40% - 17em)
  │                                     ^
  ╵
  /builds/myusername/myproject/assets/css/index.sass 8:37  @import
  /builds/myusername/myproject/assets/css/frame.sass 1:9   root stylesheet 
  Conversion error: Jekyll::Converters::Sass encountered an error while converting 'assets/css/frame.sass':
                    Expected newline.

The issue seems to be that the Sass compiler is trying to process the file before the Liquid processing happens. This is unusual, as Jekyll should be processing the Liquid tags before the Sass compiler runs.

I'm using Ruby version 3.0.2 and Jekyll version 4.3.2. The issue occurs in a GitLab CI pipeline using the ruby:3.0.2 Docker image.

I've tried updating all my gems to their latest versions and checked my Jekyll configuration, but the issue persists. I'm not using any Sass plugins.

Any help would be greatly appreciated.

Thank you!

custom style and variables

Hi Niklas,
first of all i'd like to thank you for your great job! I use your theme since last years summer and it fits pretty good...
Now i found your redesign and started to adapt it (merge in my customisations). I'd like to collect all my changes in a custom style, which is not that difficult. So i created assets/css/custom.sass (based on assets/css/contrast.sass) and enabled it in _config.yml (style: custom). To overwrite some of the predefined variables i set it in custom.sass before @import anchor. This works in most cases, but not always. The "issues" i figured out are caused by assets/css/index.css and assets/css/default.css which load the default values via @import's as well.
because i wanted to change as little as possible of the original code, i assumed that i could do everything with my own style. but it looks like i'd have to directly adjust the values in _sass/variables.sass instead? Or do you see another option?
Thanks in advance and best regards, Michi.

Discuss comments

In order to enable the discuss comments, do I only need to uncomment discuss_shortname in the config and set that shortname? This didn't work for me, do I need to do anything else (e.g. add some config in the post)?

how to enable dark color for the footer?

Theme settings

hide_title: false # remove site heading in the header
hide_footer: false # hide the "previous" and "next" links at the end of each post
dark_theme: false # use the dark mode as default
dark_header: false # keep the header dark
dark_footer: true # keep the footer dark

style: minimal # use a simpler style inspired by the minima theme

footer to a dark theme doesn't work.

https://github.com/SeokLeeUS/seokleeus.github.io is my github.

Build error

Hi,

I have a build error

Liquid Exception: Liquid syntax error (line 37): Unknown tag 'gist' in contrast-master/_posts/2017-01-01-advanced-examples.md

-- Rafał

how do I use isso comments?

Hi,
I've read their docs but it tells me to install it on ubuntu and then embed the js on the website. You should include some examples on _config.yml to help beginners to understand more about this.
Thanks

mobile devices

Hi Nicklas. Thank you so much for making this theme available. I've added a several items to the navigation pane and now the navigation pane on the mobile version extends past the field of view on the right. I've tried to rectify this in the _sass/layout.sass file, by reducing the right margin and stack the items into rows using @media query and flexbox functions, but I'm struggling. Any advice would be greatly appreciated. Many thanks! -Ted

Favicons without <head> tag

I'm trying to figure out how to add Favicons to the site so they load correctly in light and dark themes. Since the theme doesn't have a head tag I'm not sure how to do this.

Images not supported with url

If I navigate to _posts/ in Github I can see the image I'm trying to display in my post but if I go to my deployed static github page, the image appears broken. I've tried jpg and png formats but the following markdown isn't working:

![500 Error](https://github.com/sbd/sbd.github.io/blob/master/assets/gremlin-shutdown-attack.jpg)

Only this worked:

![500 Error](/assets/gremlin-shutdown-attack.jpg)

Liquid Exception: Liquid syntax error (line 27)

Thanks for your work!
I've just met the error saying "Liquid Exception: Liquid syntax error (line 27): Expected end_of_string but found id in /_layouts/default.html" when I tried to use the theme.

Any suggestions?

Thanks again!

My github.io cannot be searched by google

I tried to build my personal homepage modified from this repo. However, I found my github.io cannot be searched by google. I tried to add my github.io to google console and after half a year it hasn't finished indexing. Until now, my personal homepage is not searchable by google but can be searched by bing.

Is there any way to make my homepage searchable by Google?

Missing <head> tag

Hey, great work on the theme. Started using it on my blog last night and it's been perfect 👍

One thing I did notice is that there appears to be no <head> tag wrapping the site's metadata/imports etc.

Thought I'd flag it in case it's just been overlooked.

All the best,
Colin

How can I get icons directly from icons.svg or icons.json?

I am trying to add a button in the menu to switch dark mode and light mode, and I want to use the moon icon in font-awesome. Thus I changed menu.html to the following:

<nav>
  {%- for item in include.menu -%}
  {%- assign node = site.pages | where: "name", item.file | first -%}
  {%- assign url = item.url | default: node.url -%}
  {%- assign title = item.title | default: node.title -%}
  <a href="{{ url | relative_url }}" {% if url==page.url %}class="selected" {% endif %}>
    {%- if item.icon -%}<svg aria-label="{{ title }}" class="icon">
      <use xlink:href="{{ "/assets/fontawesome/icons.svg" | relative_url }}#{{ item.icon }}"></use>
    </svg>{%- else -%}{{ title }}{%- endif -%}
  </a>
  {%- endfor -%}
  <a class="dark-mode-button">
    <svg class="icon">
      <use xlink:href="/assets/fontawesome/icons.svg#moon"></use>
    </svg>
  </a>
</nav>

But I cannot get the icon from it. I am really not sure about how to get the icon by just reading the json file.

the site title is displayed in different font families...

...depending on whether the sidebar is active or not

Hi Niklas,

the theme is getting nicer and nicer!

I don't know if it was intended that way, I personally would prefer it to look consistent ;-)

# assets/css/sidebar.sass, lines 51-54
{% if site.show_title %}

.title
  font-family: "PT Serif", Georgia

vs.

# _sass/basic.sass, lines 15-16
body
  font-family: "PT Sans", -apple-system, BlinkMacSystemFont, "Helvetica Neue", "Segoe UI", "Roboto", sans-serif

Best regards, Michi.

Update README.md to suggest commit pinning

Firstly, thanks for this great theme!

Unfortunately, while I was setting up my CD pipeline to automatically deploy this theme using the advertised remote-theme method. My builds started to break a (or rather look wrong) as they started using the latest version of your master which is very much evolving.

I suggest advising users to pin their remote theme to a specific git version (or perhaps even releases/tags if you prefer). Perhaps it would be great to include it here:
https://github.com/niklasbuschmann/contrast#installation-jekyll-remote-theme-method

Thanks

footer shadow, alignment, size issue

Hi Niklas,

great work! i like the revised theme and have done some tests with the latest version. maybe you can have a look at the following issue i found (see attached screenshot)?

it seems that in some cases the footer doesn't fit the whole width and isn't placed correctly for short posts. i'd like to suggest you to move the footer to the bottom in any case or remove the shadow at the bottom.

Thanks, Michi.

Latex inline with single $ not rendering, needs to use $$ as per katex

I want katex inline rendering of math with single $ to be enabled. All markdown editor such as VScode doesn't allow me to write inline math with single double $$ but this is default setting with this theme.

How to deal with that, kindly help me to disable that setting on katex css.

missing import of variables

Hi Niklas,

seems, there's an import of variables missing, while running jekyll serve on the latest version...

  Conversion error: Jekyll::Converters::Sass encountered an error while converting 'assets/css/classes.sass':
                    Undefined variable: "$light". on line 2
jekyll 3.8.5 | Error:  Undefined variable: "$light". on line 2

KaTeX broken on github.io due to Kramdown upgrade

Hello, I am a fan of the Contrast theme :-)

I noticed that the equations stopped working in the Jekyll generation process. Someone wrote an article on this problem.

It points to the culprit being this change to kramdown:

gettalong/kramdown@c3acf8d

(Though the change was in April, the breakage was more recent. I do see that github.io upgraded to Jekyll 3.9.0 which came out this month, so maybe they took that moment to bump the kramdown version too?)

In that change, it can be seen that lines related to support for KaTeX in the documentation are gone. So this means that server-side support for putting on the <script> tags is probably not happening. Fixes seem to be:

  1. A new version of KaTeX working without the tags (maybe this exists already?)
  2. Code up a shim script to put the tags on client-side in JS
  3. Put the tags on manually in the page source
  4. Switch to MathJax

Since I'm not really using the feature on my "blog" (only two articles at this moment), I took lazy option 3. But hopefully this information will save time for others looking into it!

bold text is not rendered correctly

Hi Niklas,

while putting the new version into production i recognised, that bold text doesn't differ from the normal one :-( maybe the standard font-weight has to be adjusted a little bit?

Best regards, Michi.

Wrong title in 404 page

Hey, nice job, template is nice though, but I caught a bug here, wrong title in 404 page, so here is the page
image
And here is the title:
image

Base url

My blog is in some folder, so the url of my blog is:

https://xyz.com/something

instead of just https://xyz.com

The problem is that all of the links on the website lead to https://xyz.com/post_name instead of https://xyz.com/something/post_name . For that reason CSS and links don't work.

I tried to set "baseUrl" config to '/something', but that didn't work. It worked in other themes like "Minima" for example.

Can I get this theme to work with a blog in a folder? What is the best way to do that?

Why can't I change the upper-case "A" on the About page to lower-case "a"?

I prefer to use lower case for all headers. I have been able to change all of the other headers to lower case and manually edited the index.html page in /about/ to lower case. But when I re-generate the Jekyll page on localhost, the upper-case "A" magically returns. Surely something so simple shouldn't be this difficult.

a

sorry, i remove all of these, never mind. just remove this issues.

flavicon.ico

ERROR `/favicon.ico' not found when starting local jekyll server

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.