nikolavp / approval Goto Github PK

We should be able to easily include a GUI tool that will be spawn instead of the current external reporters. This will make the library more cross platform. Something based on Eclipse RPC should be easy to develop

I think we can touch the files when we verify them. This way the user can then use something based on find + exec to purge files that weren't modified in a week(for example)

We have a lot of Reporters that shell out to external reporters for the verification. We should find a crossplatform way to check if an executable is found on the path before spawning it

In the conf.py, you have (l. 23)

javasphinx_command += ['-o', 'javadoc', '../../src/main/java/']

However, in ../.. there are these folders : approval-core, approval-json and approval-sesame, not src.

So the rst files can not be generated from java files with sphinx-build.

This should be included as a submodule:

1. Move the current main project as a submodule named approval-core
2. Create approval-json submodule that contains the json converter implementation

We are trying to create a better java port for the approval test library. The .NET port however is super mature and we should be able to get some ideas from them

A reporter that uses the reporter set from a system propert/environment variable

Document that it is a good idea to include it as a first reporter in firstworking

There are problems with the interactive reporter that uses the console. It doesn't work well when the test process is forked from the build system. We can use a GUI confirm dialog instead

Follow the guide at http://central.sonatype.org/pages/ossrh-guide.html. We might need some more metadata to the pom file.

It should be possible to run the library on android. Maybe the hard dependency on some jdk7 classes is a problem especially the java.nio.file api :(

This one is found in ApprovalTest although I am not sure how well it works. The ruby port has it documented and we can get ideas/code from there

Currently tracked as part of the documentation http://approval.readthedocs.org/en/latest/alternatives-and-differences.html

There are @nonnull and @nullable annotations but we should check them with an if statements, because java doesn't guarantees their correctness through the byte code

Currently this is stubbed to return true and there are problems when it is run in a CI environment

http://meldmerge.org/

I was going to use the slf4j library but it is currently the only dependency. We can easily use the java.util.logging and provide docs for different setups(even for slf4j through the jul-to-slf4j jar)