Comments (2)
Thank you for suggestion.
But can you be more precise in your advice?
What is your technical suggestion so that I can improve?
Thanks
from teampass.
I think this issue can be closed. There's no reason to get rid of globals for the sake of getting rid of globals - as long as they're used wisely and sparingly (among the dozens of great posts on this topic, http://tjhunt.blogspot.com/2009/04/php-global-variables-are-not.html is probably one of the best.)
I believe @syphernl is talking about things like
global $server, $user, $pass, $database, $pre;
at the start of admin.settings.php, but that isn't inherently bad.
Ignoring the installers and the 3rd party libraries, globals are used in:
- admin.settings.php
- includes/include.php
- sources/logs.queries.php
- sources/items.queries.php
- sources/find.queries.php
- sources/kb.queries.table.php
- sources/fpdf.php
- sources/main.queries.php
- sources/main.functions.php
- sources/export.queries.php
- sources/kb.queries.categories.php
And in these situations, it is always against the same variables.
My only suggestion, if someone else really feels the need to pick up this mantle, would be to merge "$server, $user, $pass, $database" into a single $dbConfig array and relabel $k to something more meaningful (such as $siteConfig.)
from teampass.
Related Issues (20)
- Other Teampass Manager can edit users
- Keepass import : XSS Vulnerability (Teampass 3.X, Teampass2.X)
- No new lines in generated email HOT 1
- Unable delete empty folder
- Impossible d'ajouter un dossier/sous dossier
- Items disappeared from Password menu. We can only see folders and new items. HOT 6
- Scheduler not working error with CronExpression.php
- Unable to sync passwords after changing it in Active Directory
- Timeout problem with connectivity test HOT 2
- Fresh Install LDAP Test connection Internal Server Error
- Roles -> LDAP Syncronization is not working because objectGUID is not integer in Active Directory HOT 1
- Which is the best way to migrate to a new server? HOT 1
- Encrypting user TeamPass HOT 3
- Improve slow sql queries
- error 500 and key regeneration hangs HOT 1
- Error in the scheduler due to data entered by a user
- LDAP connection error and error 500 on the web page
- ldap group issue
- After Upgrade to Teampass 3.1.2 index.php returns too many redirects error HOT 25
- Access Users list HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teampass.