ninjasort / metalpress Goto Github PK

https://github.com/kwizzn/metalsmith-kss

Hi there, I've noticed you depended on metalsmith-metallic. I've recently bumped the version to (and published) 1.0.0 with PR 8, as I felt the bugfix was semver-major, as it impacts consumers of the metalsmith chain I emit. I just wanted to let you know, in case updating it impacts your code in the future.

https://github.com/harttle/shopify-liquid

https://github.com/totocaster/metalsmith-tags

I'm wondering if the listed dependencies is accurate. For a simple static webpage that depends on this project, it takes awhile for a fresh install because of all dependencies:

$ time npm i
...

real    5m51.668s
user    1m8.121s
sys 0m22.777s

This is also somewhat alarming (but I guess not too surprising because of how npm works):

$ ls -aslh node_modules/ | wc -l
1075

https://github.com/pjeby/gulpsmith

https://github.com/RobinThrift/metalsmith-flexible-shortcodes

• Start with the {% picture %} tag
• Determine whether adding a metalsmith plugin or js file makes sense

Getting an active class is an annoyance and should be abstracted into a helper tag or filter. We need to know which url we're actually on which is defined from metalsmith-permalinks, or the title of the page, and should be passed into a filter {{ path | active_class }}, which looks through the site config navigation and tests if any of the path is defined. From there it will return a "", or "active" string.

Hello, I'm the author of metalsmith-imagemin and I just wanted to let you know, a new version is out, with some breaking changes (specifically usage and options) to align with the latest imagemin version and API change.

let me know if you run into any trouble with the update :)

If you pass in a webpack.config file and there is an error, the error is swallowed and your webpack config file isn't used, and you don't know there is an error.

The error is swallowed here: https://github.com/axisdefined/metalpress/blob/master/src/config/configure-webpack.js#L39

Metalpress is on it's way! But before we kick off the v1.0, this issue will outline everything that's coming and make sure all the features are correctly implemented.

Metalpress CLI

Metalpress will come bundled with a CLI to make development fast and simple. Here are a few of the commands with their description.

metalpress init

Initializes a .metalpress which has project settings in json

metalpress new

Creates a new metalpress project from a git repo starter boilerplate.

metalpress serve

Serves a metalpress project on a browser-sync server (default: http://localhost:3000)

metalpress deploy

Deploys a metalpress project to an AWS bucket (staging/production).

Update all tests with ava for performance reasons.

Since we're building the entire site statically, we can technically run tests over it using a library like cheerio to load in the markup and query for selectors. This could be interesting to set up and would allow for some precise calculations of layout to occur.

For example, if we knew that we had a container of 1140px, we calculate other elements with percentage-based or flexbox widths to make sure they are laid out correctly. If we load up the templates using something like karma or protractor, we should be able to run javascript and assert how our layout changes. Let's say we had a box on the page that animated on hover. We could trigger a hover from javascript on the box and measure the element's properties to see if it is responding properly. With karma, we can bundle those js builds with webpack as well. Look into this.

• add metadata from pages to metalsmith-pagination
• post issue in metalsmith-pagination about metadata

https://github.com/superwolff/metalsmith-cloudinary

https://github.com/CMClay/metalsmith-lunr

https://github.com/christophercliff/metalsmith-fingerprint

https://github.com/segmentio/metalsmith-prompt

• Figure out how to update outdated packages in npm
• Get tests to run with ava and babel
• Watch tutorial on using nyc for test coverage
• Watch tutorial on using semantic-release

Hi there,

We noticed that your repo has a high severity vulnerability:

• Regular Expression Denial of Service
• Affected package: minimatch <=3.0.1

Here is the test report for this repo.
If you’d like to fix this vulnerability, Snyk lets you generate a pull request that recommends the best upgrade path - there’s a link to fix this vulnerability on the test report.

Stay secure :-)

Ben from the Snyk team

1. Looks like metalpress-cli expects the metalpress config to be a json file, but your preMiddleware and postMiddleware blocks accept functions https://github.com/axisdefined/metalpress/blob/master/src/index.js#L203-L211.
2. This comment is wrong https://github.com/axisdefined/metalpress/blob/master/src/index.js#L151-L159
3. Should preMiddleware be defined in the middle? Or in the beginning? Right now this seems to be a bit of a weird spot.
4. The tests for middleware are all commented out.