nishanths / scrobble Goto Github PK

Apple Music scrobbling with beautiful album artwork.

License: BSD 2-Clause "Simplified" License

Go 38.20% Makefile 0.93% Swift 8.96% Objective-C 0.11% HTML 0.70% TypeScript 34.63% CSS 1.85% JavaScript 5.36% SCSS 9.26%

apple-music album-art scrobble

scrobble's People

Contributors

Stargazers

Watchers

Forkers

letenkov aliozanyerli

scrobble's Issues

server's username validation is weaker that client's validation

client code:

scrobble/web/components/dashboard/SetUsername.tsx

Line 87 in ae40a75

 const validateUsername = (u: string): ({ reason: "", ok: true } | { reason: string, ok: false }) => { 

the server code doesn't validate that the username doesn't contain the string "scrobble".

improve UI for macos client

Link to your scrobble page
Update text "Clear API Key" -> "Clear API key and Sign out"
Update text "Cancel" -> "Close" in dialog

store static nprogress.{js,css} files, not from node_modules

reduce scrobble upload frequency in macos client

fully migrate to go111 runtime

https://cloud.google.com/appengine/docs/standard/go111/go-differences
https://cloud.google.com/appengine/docs/standard/go111/runtime

address future play times in client tooltip also

see #2 for more context.

insights data may be accessible directly via google cloud storage url even if profile is private

This is noted in the privacy policy, but the issue can be truly fixed, too.

The crux of the issue is that, in the default selective-scrobble.appspot.com Cloud Storage bucket, the objects under stats/ (which contain the insights data) are currently publicly accessible. If these objects/paths are changed to be accessible only to the App Engine app, then the issue should be resolved.

Relatedly, read the source for the App Engine HTTP handlers in api_data.go; these handlers already correctly check for authentication before reverse-proxying GCS objects under stats/. So no changes are necessary in the handlers.

add a first played field in datastore for songs

The first played value can be computed from the last played value of the song, if the value is earlier in time than the current first played value, if any. To avoid computing poor first played values for existing songs ("poor" because, when computed this way, the first played value will just equal the last played value for existing songs), set the value only for songs that are seen for the first time after this feature is implemented.

deployed-commit server endpoint

move app domain to `scrobble.growl.space`

message in macos client when last scrobbling attempt failed

/api/v1/account/delete does not remove insights data

improve root page (both signed in and signed out)

Include feature descriptions when signed out, including an example interactive artwork. Make it like a landing page.

When signed in, make the user interface richer and terser than the current one.

improved getting started instructions on root page

song/album page

Add a way to display a specific song/album. The artwork would be the centerpiece of the page. Metadata such as title, links, and play counts can be present on the page. These pages' paths could be something like

/u/username/s/<id>

/u/username/<id>

/u/username/color/a/<id>