njcuk9999 / jwst-mtl Goto Github PK

from scipy.integrate._quadrature import AccuracyWarning, _romberg_diff throws a module does not exist error for me when trying to import TrpzOverlap from overlap.py.

If mask create 2 separate wavelength grids, create a bug. Need to solve the system only for valid wavelengths.

When using grid_from_map with out_col = True, the columns are sorted so they are not associated anymore to the grid (may be flipped). Need to change oversample to deal with columns simultaneously.

When using grid_from_map with out_col = True, the columns are sorted so they are not associated anymore to the grid (may be flipped). Need to change oversample to deal with columns simultaneously.

Right now, the count rate is in e- (ext_flux_rate * tot_exp). ami_sim expects e-/s as input. The count rate is also used to scale things when generating scenes in the wrapper, but ami_sim normalizes and rescales things any way so the change should not be a problem.

The fix is very simple (remove tot_exp from the calculation), but I'm opening an issue because I don't have time to do tests to make sure the change does not affect anything else.

Currently, I get an error when the output or psf directories are not created beforehand. I added a note in the example YAML to make sure users create them before running the wrapper. I can update the code soon to automatically create them.